From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10FA3C433F5 for ; Wed, 22 Dec 2021 19:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237724AbhLVT5Q (ORCPT ); Wed, 22 Dec 2021 14:57:16 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:58122 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345346AbhLVT5N (ORCPT ); Wed, 22 Dec 2021 14:57:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C82161CF1 for ; Wed, 22 Dec 2021 19:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89386C36AEB for ; Wed, 22 Dec 2021 19:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640203031; bh=vo+ANnKfigzQzAo0jwVxZr3VvLPILGV+V4D2g0cDOJo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HHxrgtCPmPXHz+fCsXIxU9gvKpwFtUl+/sSit1hSB20LIHQ0CwUG3DRvyzyF/+Xtl azm9i3QIznjWoESMqSvLxexoV8svAkhCsYMXGAi8pOSW5oiuIAxNwdp1ec72dJVz8G MLrDwB1cidAo4xb9BWLkgAd3zHcnWF6FI/si3e/ldQGCmUms38Y+sPqNbIkRAlUPiy G2RKLFyVo5Q6wd19UREl48K9GCiAQl/39sD6uTfngJMKMGOtDtuB4pxLarScPqU3eQ XLvJxu9SZ9h7oJfIzvWhiMZEA0X3f7yHru9faCoNYn9F+kk042poC7ta0bMs4QQcvu XxSoT5DsqB9Nw== Received: by mail-ed1-f53.google.com with SMTP id bm14so12837137edb.5 for ; Wed, 22 Dec 2021 11:57:11 -0800 (PST) X-Gm-Message-State: AOAM531SKxNeaV9/Dfk7UnlhDysMVBWnuwThyuWzuw9AM1yPuWARPUwE AoA5WZqUaK0Rtx5Nrdc/Q7EmmFsG6mAOVu00rg== X-Google-Smtp-Source: ABdhPJzwsbCZWdVn8cOcu5PGCVl4Axi+Ni8kjsGL4ubCS8dZgY8gPy7zwXj1bZMZYLolMdf6vi/pSdQRIPwxu9a9uQc= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr3667056eja.264.1640203029841; Wed, 22 Dec 2021 11:57:09 -0800 (PST) MIME-Version: 1.0 References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211222104736.GZ6003@pengutronix.de> <8156864.jFcTpQmkuZ@diego> In-Reply-To: <8156864.jFcTpQmkuZ@diego> From: Rob Herring Date: Wed, 22 Dec 2021 15:56:57 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Sascha Hauer , dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 22, 2021 at 3:40 PM Heiko St=C3=BCbner wrote: > > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= . You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > > > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. > > is "newer dt with old kernel" really a case these days? I've had complaints about it. In particular from SUSE folks that were shipping new dtbs with old (stable) kernels. > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. Yes, so update your firmware that contains a newer dtb and then you stop booting or a device stops working. > But which user would get the idea of updating only the devicetree > while staying with an older kernel? Any synchronization between firmware and OS updates is a problem. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1D48C433F5 for ; Wed, 22 Dec 2021 19:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bLv5FTOmjDruzU6giRhv1js7NujWYOHlXXXnX1V9H4g=; b=d+8BtMUVZU1McA 5hPvwzsp3w6Q2B/e/6w65jdEZ1EqQUhiKr2Fc97ccTgWfaAPU3fwj9iVizSpbVa5C75h41fexduCF q10zXQ+VK9zqLi10xqpIg1+RrGjSCxqOPjgK0owcErmGAGhjsYbWYYORuh2p0biOK10Y2sWot8lgb J6yX/vAdRAPRhCi+9m6wwLrReUMSjd7XbPHiWE9uFfyCfpg0dSvMl/GuYpC/SEqgwpA0g+K3HGfUV x39+aLib/AsQhiZ/QIpNINg+BTv30IN6Kp/n/1xWnmqttGaKivm37rSql4Ymj/0v6UwrU6xdRk/KN 9TiReWwnz9QTmxz8Dx4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07jo-00BHP7-S4; Wed, 22 Dec 2021 19:57:24 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07jc-00BHNJ-LU; Wed, 22 Dec 2021 19:57:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2825B61CEF; Wed, 22 Dec 2021 19:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86B0BC36AEA; Wed, 22 Dec 2021 19:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640203031; bh=vo+ANnKfigzQzAo0jwVxZr3VvLPILGV+V4D2g0cDOJo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HHxrgtCPmPXHz+fCsXIxU9gvKpwFtUl+/sSit1hSB20LIHQ0CwUG3DRvyzyF/+Xtl azm9i3QIznjWoESMqSvLxexoV8svAkhCsYMXGAi8pOSW5oiuIAxNwdp1ec72dJVz8G MLrDwB1cidAo4xb9BWLkgAd3zHcnWF6FI/si3e/ldQGCmUms38Y+sPqNbIkRAlUPiy G2RKLFyVo5Q6wd19UREl48K9GCiAQl/39sD6uTfngJMKMGOtDtuB4pxLarScPqU3eQ XLvJxu9SZ9h7oJfIzvWhiMZEA0X3f7yHru9faCoNYn9F+kk042poC7ta0bMs4QQcvu XxSoT5DsqB9Nw== Received: by mail-ed1-f47.google.com with SMTP id x15so12931686edv.1; Wed, 22 Dec 2021 11:57:11 -0800 (PST) X-Gm-Message-State: AOAM530XjTsNpIa3Iho7ngs5IJcyp/FfEMfxBd7pShYEadD+5Fhqnjoz pukMHkE447ExWX1FU8OR1w+lRmfPMMWlpP5PJg== X-Google-Smtp-Source: ABdhPJzwsbCZWdVn8cOcu5PGCVl4Axi+Ni8kjsGL4ubCS8dZgY8gPy7zwXj1bZMZYLolMdf6vi/pSdQRIPwxu9a9uQc= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr3667056eja.264.1640203029841; Wed, 22 Dec 2021 11:57:09 -0800 (PST) MIME-Version: 1.0 References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211222104736.GZ6003@pengutronix.de> <8156864.jFcTpQmkuZ@diego> In-Reply-To: <8156864.jFcTpQmkuZ@diego> From: Rob Herring Date: Wed, 22 Dec 2021 15:56:57 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Sascha Hauer , dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_115712_802741_F31FD795 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMjIsIDIwMjEgYXQgMzo0MCBQTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250 ZWNoLmRlPiB3cm90ZToKPgo+IEFtIE1pdHR3b2NoLCAyMi4gRGV6ZW1iZXIgMjAyMSwgMTQ6NTI6 NTEgQ0VUIHNjaHJpZWIgUm9iIEhlcnJpbmc6Cj4gPiBPbiBXZWQsIERlYyAyMiwgMjAyMSBhdCA2 OjQ3IEFNIFNhc2NoYSBIYXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4gPiA+ Cj4gPiA+IE9uIFR1ZSwgRGVjIDIxLCAyMDIxIGF0IDEwOjMxOjIzQU0gLTA0MDAsIFJvYiBIZXJy aW5nIHdyb3RlOgo+ID4gPiA+IE9uIE1vbiwgRGVjIDIwLCAyMDIxIGF0IDEyOjA2OjE2UE0gKzAx MDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPiA+ID4gPiA+ICJ2cGxsIiBpcyBhIG1pc25vbWVyLiBB IGNsb2NrIGlucHV0IHRvIGEgZGV2aWNlIHNob3VsZCBiZSBuYW1lZCBhZnRlcgo+ID4gPiA+ID4g dGhlIHVzYWdlIGluIHRoZSBkZXZpY2UsIG5vdCBhZnRlciB0aGUgY2xvY2sgdGhhdCBkcml2ZXMg aXQuIE9uIHRoZQo+ID4gPiA+ID4gcmszNTY4IHRoZSBzYW1lIGNsb2NrIGlzIGRyaXZlbiBieSB0 aGUgSFBMTC4KPiA+ID4gPiA+IFRvIGZpeCB0aGF0LCB0aGlzIHBhdGNoIHJlbmFtZXMgdGhlIHZw bGwgY2xvY2sgdG8gcmVmIGNsb2NrLgo+ID4gPiA+Cj4gPiA+ID4gVGhlIHByb2JsZW0gd2l0aCB0 aGlzIHNlcmllcyBpcyBpdCBicmVha3MgYW4gb2xkIGtlcm5lbCB3aXRoIG5ldyBkdC4gWW91Cj4g PiA+ID4gY2FuIHBhcnRpYWxseSBtaXRpZ2F0ZSB0aGF0IHdpdGggc3RhYmxlIGtlcm5lbCBiYWNr cG9ydCwgYnV0IElNTyBrZWVwaW5nCj4gPiA+ID4gdGhlIG9sZCBuYW1lIGlzIG5vdCBhIGJ1cmRl biB0byBtYWludGFpbi4KPiA+ID4KPiA+ID4gQXMgc3VnZ2VzdGVkIEkgb25seSByZW1vdmVkIHZw bGwgZnJvbSB0aGUgYmluZGluZyBkb2N1bWVudCwgYnV0IG5vdCBmcm9tCj4gPiA+IHRoZSBjb2Rl LiBUaGUgY29kZSBzdGlsbCBoYW5kbGVzIHRoZSBvbGQgYmluZGluZyBhcyB3ZWxsLgo+ID4KPiA+ IFRoZSBwcm9ibGVtIGlzIHVwZGF0aW5nIHJrMzM5OS5kdHNpLiBUaGF0IGNoYW5nZSB3b24ndCB3 b3JrIHdpdGggb2xkCj4gPiBrZXJuZWxzIGJlY2F1c2UgdGhleSB3b24ndCBsb29rIGZvciAncmVm Jy4gU2luY2UgeW91IHNob3VsZG4ndCBjaGFuZ2UKPiA+IGl0LCB0aGUgYmluZGluZyBuZWVkcyB0 byBjb3ZlciBib3RoIHRoZSBvbGQgYW5kIG5ldyBjYXNlcy4KPgo+IGlzICJuZXdlciBkdCB3aXRo IG9sZCBrZXJuZWwiIHJlYWxseSBhIGNhc2UgdGhlc2UgZGF5cz8KCkkndmUgaGFkIGNvbXBsYWlu dHMgYWJvdXQgaXQuIEluIHBhcnRpY3VsYXIgZnJvbSBTVVNFIGZvbGtzIHRoYXQgd2VyZQpzaGlw cGluZyBuZXcgZHRicyB3aXRoIG9sZCAoc3RhYmxlKSBrZXJuZWxzLgoKPiBJIGRvIHVuZGVyc3Rh bmQgdGhlIG5ldyBrZXJuZWwgb2xkIGR0IGNhc2UgLSBmb3IgZXhhbXBsZSB3aXRoIHRoZQo+IGR0 YiBiZWluZyBwcm92aWRlZCBieSBmaXJtd2FyZS4KClllcywgc28gdXBkYXRlIHlvdXIgZmlybXdh cmUgdGhhdCBjb250YWlucyBhIG5ld2VyIGR0YiBhbmQgdGhlbiB5b3UKc3RvcCBib290aW5nIG9y IGEgZGV2aWNlIHN0b3BzIHdvcmtpbmcuCgo+IEJ1dCB3aGljaCB1c2VyIHdvdWxkIGdldCB0aGUg aWRlYSBvZiB1cGRhdGluZyBvbmx5IHRoZSBkZXZpY2V0cmVlCj4gd2hpbGUgc3RheWluZyB3aXRo IGFuIG9sZGVyIGtlcm5lbD8KCkFueSBzeW5jaHJvbml6YXRpb24gYmV0d2VlbiBmaXJtd2FyZSBh bmQgT1MgdXBkYXRlcyBpcyBhIHByb2JsZW0uCgpSb2IKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51 eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35212C433EF for ; Wed, 22 Dec 2021 19:57:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3171210E293; Wed, 22 Dec 2021 19:57:14 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B50710E293 for ; Wed, 22 Dec 2021 19:57:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3886461CC9 for ; Wed, 22 Dec 2021 19:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 974FAC36AE8 for ; Wed, 22 Dec 2021 19:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640203031; bh=vo+ANnKfigzQzAo0jwVxZr3VvLPILGV+V4D2g0cDOJo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HHxrgtCPmPXHz+fCsXIxU9gvKpwFtUl+/sSit1hSB20LIHQ0CwUG3DRvyzyF/+Xtl azm9i3QIznjWoESMqSvLxexoV8svAkhCsYMXGAi8pOSW5oiuIAxNwdp1ec72dJVz8G MLrDwB1cidAo4xb9BWLkgAd3zHcnWF6FI/si3e/ldQGCmUms38Y+sPqNbIkRAlUPiy G2RKLFyVo5Q6wd19UREl48K9GCiAQl/39sD6uTfngJMKMGOtDtuB4pxLarScPqU3eQ XLvJxu9SZ9h7oJfIzvWhiMZEA0X3f7yHru9faCoNYn9F+kk042poC7ta0bMs4QQcvu XxSoT5DsqB9Nw== Received: by mail-ed1-f48.google.com with SMTP id j6so12707305edw.12 for ; Wed, 22 Dec 2021 11:57:11 -0800 (PST) X-Gm-Message-State: AOAM533qtlU0xzDnY4rmQaEub9JgXKWkW2850hbHtKmoQQJxVYazG+pd yyf8xegUfRnA6zPpnnhgrf4jos3C5m9S192tHw== X-Google-Smtp-Source: ABdhPJzwsbCZWdVn8cOcu5PGCVl4Axi+Ni8kjsGL4ubCS8dZgY8gPy7zwXj1bZMZYLolMdf6vi/pSdQRIPwxu9a9uQc= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr3667056eja.264.1640203029841; Wed, 22 Dec 2021 11:57:09 -0800 (PST) MIME-Version: 1.0 References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211222104736.GZ6003@pengutronix.de> <8156864.jFcTpQmkuZ@diego> In-Reply-To: <8156864.jFcTpQmkuZ@diego> From: Rob Herring Date: Wed, 22 Dec 2021 15:56:57 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel , "open list:ARM/Rockchip SoC..." , Michael Riesch , Sascha Hauer , Andy Yan , linux-arm-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 22, 2021 at 3:40 PM Heiko St=C3=BCbner wrote: > > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= . You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > > > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. > > is "newer dt with old kernel" really a case these days? I've had complaints about it. In particular from SUSE folks that were shipping new dtbs with old (stable) kernels. > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. Yes, so update your firmware that contains a newer dtb and then you stop booting or a device stops working. > But which user would get the idea of updating only the devicetree > while staying with an older kernel? Any synchronization between firmware and OS updates is a problem. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC63C433F5 for ; Wed, 22 Dec 2021 19:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0gGq5r1DdYpaZV895uJdeFCSRXBmXN3s9reH+hI+/gE=; b=m1MbWNXJYbo0B5 B41qLReUBI94TanTLHX0qN1ol/uxOO59gUoLp0x3kq6esL8vjllu55E+0/JB9YCRwUR/kSsv3flS+ BATQn7Ed/SBQ3UATkAMCwdQW+QHpuACjjeTB/uJZhV7QLswcMAylFKNuOmUBrMhV07hz3D09UFPqK Q1mhKbpeBy7WB+TvcrQuJ5HsBh9phWBwH6Yeextd1RABV40rwY+SVUJMtWMqBYtofc9KuohD3xl+I bgLddh57H9phowH3pWMxAhAQDCYAzpYRCMJiKh+Eh/5EALUEHVKnNRRbbA5kNCvaq6CI3AC9rzexw VWNr8xraP41lGtXuoN8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07jg-00BHNi-Ck; Wed, 22 Dec 2021 19:57:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07jc-00BHNJ-LU; Wed, 22 Dec 2021 19:57:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2825B61CEF; Wed, 22 Dec 2021 19:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86B0BC36AEA; Wed, 22 Dec 2021 19:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640203031; bh=vo+ANnKfigzQzAo0jwVxZr3VvLPILGV+V4D2g0cDOJo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HHxrgtCPmPXHz+fCsXIxU9gvKpwFtUl+/sSit1hSB20LIHQ0CwUG3DRvyzyF/+Xtl azm9i3QIznjWoESMqSvLxexoV8svAkhCsYMXGAi8pOSW5oiuIAxNwdp1ec72dJVz8G MLrDwB1cidAo4xb9BWLkgAd3zHcnWF6FI/si3e/ldQGCmUms38Y+sPqNbIkRAlUPiy G2RKLFyVo5Q6wd19UREl48K9GCiAQl/39sD6uTfngJMKMGOtDtuB4pxLarScPqU3eQ XLvJxu9SZ9h7oJfIzvWhiMZEA0X3f7yHru9faCoNYn9F+kk042poC7ta0bMs4QQcvu XxSoT5DsqB9Nw== Received: by mail-ed1-f47.google.com with SMTP id x15so12931686edv.1; Wed, 22 Dec 2021 11:57:11 -0800 (PST) X-Gm-Message-State: AOAM530XjTsNpIa3Iho7ngs5IJcyp/FfEMfxBd7pShYEadD+5Fhqnjoz pukMHkE447ExWX1FU8OR1w+lRmfPMMWlpP5PJg== X-Google-Smtp-Source: ABdhPJzwsbCZWdVn8cOcu5PGCVl4Axi+Ni8kjsGL4ubCS8dZgY8gPy7zwXj1bZMZYLolMdf6vi/pSdQRIPwxu9a9uQc= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr3667056eja.264.1640203029841; Wed, 22 Dec 2021 11:57:09 -0800 (PST) MIME-Version: 1.0 References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211222104736.GZ6003@pengutronix.de> <8156864.jFcTpQmkuZ@diego> In-Reply-To: <8156864.jFcTpQmkuZ@diego> From: Rob Herring Date: Wed, 22 Dec 2021 15:56:57 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Sascha Hauer , dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_115712_802741_F31FD795 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMjIsIDIwMjEgYXQgMzo0MCBQTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250 ZWNoLmRlPiB3cm90ZToKPgo+IEFtIE1pdHR3b2NoLCAyMi4gRGV6ZW1iZXIgMjAyMSwgMTQ6NTI6 NTEgQ0VUIHNjaHJpZWIgUm9iIEhlcnJpbmc6Cj4gPiBPbiBXZWQsIERlYyAyMiwgMjAyMSBhdCA2 OjQ3IEFNIFNhc2NoYSBIYXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4gPiA+ Cj4gPiA+IE9uIFR1ZSwgRGVjIDIxLCAyMDIxIGF0IDEwOjMxOjIzQU0gLTA0MDAsIFJvYiBIZXJy aW5nIHdyb3RlOgo+ID4gPiA+IE9uIE1vbiwgRGVjIDIwLCAyMDIxIGF0IDEyOjA2OjE2UE0gKzAx MDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPiA+ID4gPiA+ICJ2cGxsIiBpcyBhIG1pc25vbWVyLiBB IGNsb2NrIGlucHV0IHRvIGEgZGV2aWNlIHNob3VsZCBiZSBuYW1lZCBhZnRlcgo+ID4gPiA+ID4g dGhlIHVzYWdlIGluIHRoZSBkZXZpY2UsIG5vdCBhZnRlciB0aGUgY2xvY2sgdGhhdCBkcml2ZXMg aXQuIE9uIHRoZQo+ID4gPiA+ID4gcmszNTY4IHRoZSBzYW1lIGNsb2NrIGlzIGRyaXZlbiBieSB0 aGUgSFBMTC4KPiA+ID4gPiA+IFRvIGZpeCB0aGF0LCB0aGlzIHBhdGNoIHJlbmFtZXMgdGhlIHZw bGwgY2xvY2sgdG8gcmVmIGNsb2NrLgo+ID4gPiA+Cj4gPiA+ID4gVGhlIHByb2JsZW0gd2l0aCB0 aGlzIHNlcmllcyBpcyBpdCBicmVha3MgYW4gb2xkIGtlcm5lbCB3aXRoIG5ldyBkdC4gWW91Cj4g PiA+ID4gY2FuIHBhcnRpYWxseSBtaXRpZ2F0ZSB0aGF0IHdpdGggc3RhYmxlIGtlcm5lbCBiYWNr cG9ydCwgYnV0IElNTyBrZWVwaW5nCj4gPiA+ID4gdGhlIG9sZCBuYW1lIGlzIG5vdCBhIGJ1cmRl biB0byBtYWludGFpbi4KPiA+ID4KPiA+ID4gQXMgc3VnZ2VzdGVkIEkgb25seSByZW1vdmVkIHZw bGwgZnJvbSB0aGUgYmluZGluZyBkb2N1bWVudCwgYnV0IG5vdCBmcm9tCj4gPiA+IHRoZSBjb2Rl LiBUaGUgY29kZSBzdGlsbCBoYW5kbGVzIHRoZSBvbGQgYmluZGluZyBhcyB3ZWxsLgo+ID4KPiA+ IFRoZSBwcm9ibGVtIGlzIHVwZGF0aW5nIHJrMzM5OS5kdHNpLiBUaGF0IGNoYW5nZSB3b24ndCB3 b3JrIHdpdGggb2xkCj4gPiBrZXJuZWxzIGJlY2F1c2UgdGhleSB3b24ndCBsb29rIGZvciAncmVm Jy4gU2luY2UgeW91IHNob3VsZG4ndCBjaGFuZ2UKPiA+IGl0LCB0aGUgYmluZGluZyBuZWVkcyB0 byBjb3ZlciBib3RoIHRoZSBvbGQgYW5kIG5ldyBjYXNlcy4KPgo+IGlzICJuZXdlciBkdCB3aXRo IG9sZCBrZXJuZWwiIHJlYWxseSBhIGNhc2UgdGhlc2UgZGF5cz8KCkkndmUgaGFkIGNvbXBsYWlu dHMgYWJvdXQgaXQuIEluIHBhcnRpY3VsYXIgZnJvbSBTVVNFIGZvbGtzIHRoYXQgd2VyZQpzaGlw cGluZyBuZXcgZHRicyB3aXRoIG9sZCAoc3RhYmxlKSBrZXJuZWxzLgoKPiBJIGRvIHVuZGVyc3Rh bmQgdGhlIG5ldyBrZXJuZWwgb2xkIGR0IGNhc2UgLSBmb3IgZXhhbXBsZSB3aXRoIHRoZQo+IGR0 YiBiZWluZyBwcm92aWRlZCBieSBmaXJtd2FyZS4KClllcywgc28gdXBkYXRlIHlvdXIgZmlybXdh cmUgdGhhdCBjb250YWlucyBhIG5ld2VyIGR0YiBhbmQgdGhlbiB5b3UKc3RvcCBib290aW5nIG9y IGEgZGV2aWNlIHN0b3BzIHdvcmtpbmcuCgo+IEJ1dCB3aGljaCB1c2VyIHdvdWxkIGdldCB0aGUg aWRlYSBvZiB1cGRhdGluZyBvbmx5IHRoZSBkZXZpY2V0cmVlCj4gd2hpbGUgc3RheWluZyB3aXRo IGFuIG9sZGVyIGtlcm5lbD8KCkFueSBzeW5jaHJvbml6YXRpb24gYmV0d2VlbiBmaXJtd2FyZSBh bmQgT1MgdXBkYXRlcyBpcyBhIHByb2JsZW0uCgpSb2IKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK