All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Paul Cercueil <paul@crapouillou.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	od@zcrc.me, Linux PWM List <linux-pwm@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] dt-bindings: Remove unused compatible strings
Date: Mon, 12 Aug 2019 17:39:42 -0600	[thread overview]
Message-ID: <CAL_JsqJv8kv_xXwoOUa-avTZhq0NkkDHCUmA5HbQFydWKu=n-g@mail.gmail.com> (raw)
In-Reply-To: <20190808082829.i6enaout5ozvdnwj@pengutronix.de>

On Thu, Aug 8, 2019 at 2:28 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Mon, Jul 08, 2019 at 08:04:25PM -0600, Rob Herring wrote:
> > On Fri, Jun 07, 2019 at 05:44:05PM +0200, Paul Cercueil wrote:
> > > Right now none of the Ingenic-based boards probe this driver from
> > > devicetree. This driver defined three compatible strings for the exact
> > > same behaviour. Before these strings are used, we can remove two of
> > > them.
> > >
> > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > > ---
> > >
> > > Notes:
> > >     v2: Rebase on v5.2-rc3
> > >
> > >  Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt b/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
> > > index 7d9d3f90641b..493bec80d59b 100644
> > > --- a/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
> > > +++ b/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
> > > @@ -2,10 +2,7 @@ Ingenic JZ47xx PWM Controller
> > >  =============================
> > >
> > >  Required properties:
> > > -- compatible: One of:
> > > -  * "ingenic,jz4740-pwm"
> > > -  * "ingenic,jz4770-pwm"
> > > -  * "ingenic,jz4780-pwm"
> > > +- compatible: Should be "ingenic,jz4740-pwm"
> >
> > Are you sure all 3 chips are exactly the same features and bugs?
> >
> > The correct thing to do here generally is the 4770 and 4780 would also
> > have ingenic,jz4740-pwm as a fallback compatible. Then the driver can
> > match on that until you find some difference and can use the more
> > specific compatible.
>
> Note that Thierry already applied this patch before your concern reached
> the mailing list. Is this bad enough to revert
> 925488e8df4f396ad96ff008a84f5b14d8b73347?

It won't be my problem when you find and need to handle any of the
differences in the driver.

Rob

  reply	other threads:[~2019-08-12 23:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 15:44 [PATCH v2 0/6] PWM JZ4740 fixes and cleanups Paul Cercueil
2019-06-07 15:44 ` [PATCH v2 1/6] dt-bindings: Remove unused compatible strings Paul Cercueil
2019-07-09  2:04   ` Rob Herring
2019-07-09  3:18     ` Paul Cercueil
2019-07-09 15:46       ` Rob Herring
2019-08-08  8:28     ` Uwe Kleine-König
2019-08-12 23:39       ` Rob Herring [this message]
2019-06-07 15:44 ` [PATCH v2 2/6] pwm: jz4740: Remove unused devicetree " Paul Cercueil
2019-08-08  8:24   ` Uwe Kleine-König
2019-06-07 15:44 ` [PATCH v2 3/6] pwm: jz4740: Apply configuration atomically Paul Cercueil
2019-07-22 19:34   ` Uwe Kleine-König
2019-07-23 20:46     ` Paul Cercueil
2019-07-24  6:47       ` Uwe Kleine-König
2019-07-29 21:19         ` Paul Cercueil
2019-07-30 12:32           ` [PATCH] pwm: jz4740: document known limitations Uwe Kleine-König
2019-08-07 13:42             ` Paul Cercueil
2019-08-07 13:49               ` Uwe Kleine-König
2019-08-07 18:40                 ` Paul Cercueil
2019-08-09  0:08                 ` Paul Cercueil
2019-08-07 13:53             ` Paul Cercueil
2019-06-07 15:44 ` [PATCH v2 4/6] pwm: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
2019-06-07 15:44 ` [PATCH v2 5/6] pwm: jz4740: Force TCU2 channels to return to their init level Paul Cercueil
2019-06-07 15:44 ` [PATCH v2 6/6] pwm: jz4740: Use __init_or_module and __exit for .probe and .remove Paul Cercueil
2019-06-08 10:31   ` Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqJv8kv_xXwoOUa-avTZhq0NkkDHCUmA5HbQFydWKu=n-g@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.