From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbeDQNJa (ORCPT ); Tue, 17 Apr 2018 09:09:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:55342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbeDQNJ2 (ORCPT ); Tue, 17 Apr 2018 09:09:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D80CA2183C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AIpwx4/3kTwvTqgQ7d5VptHdwUW4+wK55gbHggNooUm/dBRc+bRRgixWPAzxNcO/F1OZkbiuPVao+m1IcpFXSe+AhnQ= MIME-Version: 1.0 In-Reply-To: <20180416225259.6571-1-eric@anholt.net> References: <20180416225259.6571-1-eric@anholt.net> From: Rob Herring Date: Tue, 17 Apr 2018 08:09:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. To: Eric Anholt Cc: dri-devel , Mark Rutland , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Stefan Wahren , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt wrote: > The GPU subsystem node was a workaround to have a central device to > bind V3D and display to. Following the lead of 246774d17fc0 > ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove > the subsystem node usage and just create a platform device for the DRM > device to attach to if any of the subsystem devices are present. > > v2: Simplify the DT walking code. > v3: Always put the node. > > Signed-off-by: Eric Anholt > --- > .../bindings/display/brcm,bcm-vc4.txt | 7 ----- > drivers/gpu/drm/vc4/vc4_drv.c | 28 +++++++++++++------ > drivers/gpu/drm/vc4/vc4_hvs.c | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 1 + > 4 files changed, 22 insertions(+), 15 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. Date: Tue, 17 Apr 2018 08:09:06 -0500 Message-ID: References: <20180416225259.6571-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180416225259.6571-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Scott Branden , Jon Mason , Ray Jui , Stefan Wahren , "linux-kernel@vger.kernel.org" , dri-devel , bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org T24gTW9uLCBBcHIgMTYsIDIwMTggYXQgNTo1MiBQTSwgRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4gd3JvdGU6Cj4gVGhlIEdQVSBzdWJzeXN0ZW0gbm9kZSB3YXMgYSB3b3JrYXJvdW5kIHRv IGhhdmUgYSBjZW50cmFsIGRldmljZSB0bwo+IGJpbmQgVjNEIGFuZCBkaXNwbGF5IHRvLiAgRm9s bG93aW5nIHRoZSBsZWFkIG9mIDI0Njc3NGQxN2ZjMAo+ICgiZHJtL2V0bmF2aXY6IHJlbW92ZSB0 aGUgbmVlZCBmb3IgYSBncHUtc3Vic3lzdGVtIERUIG5vZGUiKSwgcmVtb3ZlCj4gdGhlIHN1YnN5 c3RlbSBub2RlIHVzYWdlIGFuZCBqdXN0IGNyZWF0ZSBhIHBsYXRmb3JtIGRldmljZSBmb3IgdGhl IERSTQo+IGRldmljZSB0byBhdHRhY2ggdG8gaWYgYW55IG9mIHRoZSBzdWJzeXN0ZW0gZGV2aWNl cyBhcmUgcHJlc2VudC4KPgo+IHYyOiBTaW1wbGlmeSB0aGUgRFQgd2Fsa2luZyBjb2RlLgo+IHYz OiBBbHdheXMgcHV0IHRoZSBub2RlLgo+Cj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVy aWNAYW5ob2x0Lm5ldD4KPiAtLS0KPiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJjbSxiY20tdmM0 LnR4dCAgICAgICAgIHwgIDcgLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHJ2LmMg ICAgICAgICAgICAgICAgIHwgMjggKysrKysrKysrKysrKy0tLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF9odnMuYyAgICAgICAgICAgICAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2Ry bS92YzQvdmM0X3YzZC5jICAgICAgICAgICAgICAgICB8ICAxICsKPiAgNCBmaWxlcyBjaGFuZ2Vk LCAyMiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKClJldmlld2VkLWJ5OiBSb2IgSGVy cmluZyA8cm9iaEBrZXJuZWwub3JnPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh+dt@kernel.org (Rob Herring) Date: Tue, 17 Apr 2018 08:09:06 -0500 Subject: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node. In-Reply-To: <20180416225259.6571-1-eric@anholt.net> References: <20180416225259.6571-1-eric@anholt.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt wrote: > The GPU subsystem node was a workaround to have a central device to > bind V3D and display to. Following the lead of 246774d17fc0 > ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove > the subsystem node usage and just create a platform device for the DRM > device to attach to if any of the subsystem devices are present. > > v2: Simplify the DT walking code. > v3: Always put the node. > > Signed-off-by: Eric Anholt > --- > .../bindings/display/brcm,bcm-vc4.txt | 7 ----- > drivers/gpu/drm/vc4/vc4_drv.c | 28 +++++++++++++------ > drivers/gpu/drm/vc4/vc4_hvs.c | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 1 + > 4 files changed, 22 insertions(+), 15 deletions(-) Reviewed-by: Rob Herring