From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757301AbbEVTyh (ORCPT ); Fri, 22 May 2015 15:54:37 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:33727 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756048AbbEVTyd (ORCPT ); Fri, 22 May 2015 15:54:33 -0400 MIME-Version: 1.0 In-Reply-To: <555DD4C2.80406@ti.com> References: <1431557340-5421-1-git-send-email-robh@kernel.org> <1431557340-5421-5-git-send-email-robh@kernel.org> <555DD384.2090506@ti.com> <555DD4C2.80406@ti.com> From: Rob Herring Date: Fri, 22 May 2015 14:54:12 -0500 X-Google-Sender-Auth: OETK9cyN6QhJHY1owo7PRocvk1s Message-ID: Subject: Re: [PATCH 4/5] phy: add Marvell HSIC 28nm PHY To: Kishon Vijay Abraham I Cc: Greg Kroah-Hartman , Alan Stern , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Linux USB List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 7:51 AM, Kishon Vijay Abraham I wrote: > On Thursday 21 May 2015 06:15 PM, Kishon Vijay Abraham I wrote: >> >> Hi, >> >> On Thursday 14 May 2015 04:18 AM, Rob Herring wrote: >>> >>> Add PHY driver for the Marvell HSIC 28nm PHY. This PHY is found in >>> PXA1928 >>> SOC. [...] >>> + writel(readl(base + PHY_28NM_HSIC_CTRL) & >>> ~PHY_28NM_HSIC_S2H_HSIC_EN, >>> + base + PHY_28NM_HSIC_CTRL); >>> + >>> + clk_disable_unprepare(mv_phy->clk); >>> + return 0; >>> +} >>> + >>> +static const struct phy_ops hsic_ops = { >>> + .init = mv_hsic_phy_init, >>> + .power_on = mv_hsic_phy_power_on, >>> + .power_off = mv_hsic_phy_power_off, >> >> >> exit callback is missing? Shouldn't we turn off the PLLs in exit callback? I really don't understand the division of the ops functions. It seems backwards to me. Don't you need to power on the phy before you can initialize it? Or init is supposed to be s/w init of some kind. AFAICT, all the drivers just call init and power_on back to back. > > Also add the .owner member since this driver can be used as module. Strange. Generally an ops struct just has ops. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 4/5] phy: add Marvell HSIC 28nm PHY Date: Fri, 22 May 2015 14:54:12 -0500 Message-ID: References: <1431557340-5421-1-git-send-email-robh@kernel.org> <1431557340-5421-5-git-send-email-robh@kernel.org> <555DD384.2090506@ti.com> <555DD4C2.80406@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <555DD4C2.80406-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I Cc: Greg Kroah-Hartman , Alan Stern , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux USB List List-Id: devicetree@vger.kernel.org On Thu, May 21, 2015 at 7:51 AM, Kishon Vijay Abraham I wrote: > On Thursday 21 May 2015 06:15 PM, Kishon Vijay Abraham I wrote: >> >> Hi, >> >> On Thursday 14 May 2015 04:18 AM, Rob Herring wrote: >>> >>> Add PHY driver for the Marvell HSIC 28nm PHY. This PHY is found in >>> PXA1928 >>> SOC. [...] >>> + writel(readl(base + PHY_28NM_HSIC_CTRL) & >>> ~PHY_28NM_HSIC_S2H_HSIC_EN, >>> + base + PHY_28NM_HSIC_CTRL); >>> + >>> + clk_disable_unprepare(mv_phy->clk); >>> + return 0; >>> +} >>> + >>> +static const struct phy_ops hsic_ops = { >>> + .init = mv_hsic_phy_init, >>> + .power_on = mv_hsic_phy_power_on, >>> + .power_off = mv_hsic_phy_power_off, >> >> >> exit callback is missing? Shouldn't we turn off the PLLs in exit callback? I really don't understand the division of the ops functions. It seems backwards to me. Don't you need to power on the phy before you can initialize it? Or init is supposed to be s/w init of some kind. AFAICT, all the drivers just call init and power_on back to back. > > Also add the .owner member since this driver can be used as module. Strange. Generally an ops struct just has ops. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html