From: Rob Herring <robh@kernel.org>
To: Bharat Kumar Gogada <bharatku@xilinx.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Michal Simek <michals@xilinx.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string
Date: Tue, 19 Apr 2022 09:12:52 -0500 [thread overview]
Message-ID: <CAL_JsqJynvpmdF2cBFDQ3og4zgrx9UFtj4NkGUV20f61yc+YtA@mail.gmail.com> (raw)
In-Reply-To: <CH2PR02MB6952D1D0E6FA89ED25110AFFA5F29@CH2PR02MB6952.namprd02.prod.outlook.com>
On Tue, Apr 19, 2022 at 7:22 AM Bharat Kumar Gogada <bharatku@xilinx.com> wrote:
>
> > On Thu, Apr 14, 2022 at 02:46:25PM +0200, Michal Simek wrote:
> > > On 4/14/22 11:22, Bharat Kumar Gogada wrote:
> > > > Removing unnecessary version number in compatible string.
> > >
> > > I am missing reason for this in commit message.
> >
> > Agreed. The commit log for the pcie-xilinx-cpm.c change also needs to
> > explain why removing the version is useful and safe.
>
> HI Bjorn, Michal,
>
> The CPM block is hard block, Rob pointed out that versioning has no value here.
> Will resend patch with this detail.
I did not say to remove the existing version breaking compatibility.
Just don't continue to add new version numbers.
Rob
next prev parent reply other threads:[~2022-04-19 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 9:22 [PATCH v1 0/3] Remove unnecessary version number Bharat Kumar Gogada
2022-04-14 9:22 ` [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string Bharat Kumar Gogada
2022-04-14 12:46 ` Michal Simek
2022-04-14 16:45 ` Bjorn Helgaas
2022-04-19 12:22 ` Bharat Kumar Gogada
2022-04-19 14:12 ` Rob Herring [this message]
2022-04-26 4:04 ` Bharat Kumar Gogada
2022-04-14 9:22 ` [PATCH v1 2/3] " Bharat Kumar Gogada
2022-04-14 9:22 ` [PATCH v1 3/3] dt-bindings: PCI: xilinx-cpm: Change reg property order Bharat Kumar Gogada
2022-04-14 12:47 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJynvpmdF2cBFDQ3og4zgrx9UFtj4NkGUV20f61yc+YtA@mail.gmail.com \
--to=robh@kernel.org \
--cc=bharatku@xilinx.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.