From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA82CC433EF for ; Tue, 14 Dec 2021 15:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232881AbhLNPHx (ORCPT ); Tue, 14 Dec 2021 10:07:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbhLNPHw (ORCPT ); Tue, 14 Dec 2021 10:07:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE8A0C061574; Tue, 14 Dec 2021 07:07:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 83D31B81A26; Tue, 14 Dec 2021 15:07:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39B77C34608; Tue, 14 Dec 2021 15:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639494469; bh=rPVk2jDfAiR4nn6IGpYxU9DbCVEZmbX3NRqFQoR/jQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=n1a/Auo5GPfrYAN6BIrPFlMr16f70/duhx+xBXAmDtvldmoUfa1QwqdjTpNRonDpk 1NqP9cw8wUbGCyaH9EluR7qtxbvyP+pZE1MnP2C5tEBoMVMIdrc2V4ScPnf9cGqvwH x0OLd8CUlhkfeQqj+oXHwDgRvcyR9OGyQwgBvlHUNv9Zd0oKYawKSxFmwLLyZn61Ge 4MXLmhNrzDuzec3RJd+/iccHwz2kpNBbxxRtjRYKEaPxZx0utFHiynKNZ0R1q4SzeH lQgW6MUsLYDZzpzyecpyohd1DWFSrq+lruclmWBccK/wucP0SRKTBTRwnnm43hE7Rb jUf5oXYiW5zeg== Received: by mail-ed1-f44.google.com with SMTP id r11so63319103edd.9; Tue, 14 Dec 2021 07:07:49 -0800 (PST) X-Gm-Message-State: AOAM530goB/LFR0w9RAxU8tIZlGg/aTjCtj4hqjRzINAo0n9lnP2+8HU EO0Kn7WOF31F5NeB72FO3l2CdsS27xvSv1MJKA== X-Google-Smtp-Source: ABdhPJxf5YHSaPknEFNU2A9Af9vjayodsoldMQfptOk8XsIiNGL8Y+79xGZquCFPYdXox6JhXgRtWzFzb7ICr0iQ9pE= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr6246957eja.264.1639494466650; Tue, 14 Dec 2021 07:07:46 -0800 (PST) MIME-Version: 1.0 References: <20211214013800.2703568-1-vladimir.oltean@nxp.com> <20211214013800.2703568-2-vladimir.oltean@nxp.com> In-Reply-To: <20211214013800.2703568-2-vladimir.oltean@nxp.com> From: Rob Herring Date: Tue, 14 Dec 2021 09:07:33 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename "interrupt-map" OF property to "fsl,extirq-map" To: Vladimir Oltean Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Marc Zyngier , Shawn Guo , Li Yang , Biwen Li , Zhiqiang Hou , Kurt Kanzenbach , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 13, 2021 at 7:38 PM Vladimir Oltean wrote: > > This OF property was supposed to be named "fsl,extirq-map" since the > first patch submissions, but at Rob Herring's suggestion it was named > "interrupt-map": > https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/ I'm still not okay with a custom property. The fact that multiple platforms need the same thing is an indication this should be common. Other cases are being fixed by using 'interrupts', but that's going to take some cleanups[1]. > At that time, the "interrupt-map" was ignored by the core for OF nodes > that also had an "interrupt-controller" property, but that changed with > commit 041284181226 ("of/irq: Allow matching of an interrupt-map local > to an interrupt controller"), which made the consumer drivers of the > ls-extirq break. To work around this breakage, the OF bindings for IRQs > have introduced a table of "OF IRQ interrupt-map abusers". > This can be seen in commit de4adddcbcc2 ("of/irq: Add a quirk for > controllers with their own definition of interrupt-map"). > > To stop being abusers, let's go back to the original form of these > bindings, before Rob's review. Compatibility will be kept with the > current abusive bindings for a few more kernel cycles, to give people > some time to update. But to also give them an incentive, print a warning > that the support for "interrupt-map" will be removed. This will be seen > when running a new kernel with an old device tree. > > While the breakage was introduced relatively recently, the device tree > changes are intended to backport stable kernels for quicker conversion > to an acceptable set of bindings, and this driver will need to support > the updated stable bindings. Using 'interrupts' is not going to work backporting to stable, but I don't think trying to switch this is worth it. Rob [1] https://lore.kernel.org/all/CAL_Jsq+jyqbhA1jpgZ+yTwWGvCMRu9VmgoDq8MDM9SMqJ-XSBw@mail.gmail.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEA43C433F5 for ; Tue, 14 Dec 2021 15:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+P1Dx9iYVX16/gqBvoFTRmNSnklKX+21keAwO6MxmSA=; b=vVuLgkJ93fmZ61 UhKKFidbNenlWl5U95b9e0SXCV0wZPBL0JsDvJ9cEW11ldaT2BZl0IVrEDKvQemiCHA1xcfhF2S9l 80rfz1qdOk1NivxG11zaZ1tyts4Pbm5k78sQRAQprvrGfXlVhn84qq7XBdMBYDahasygHCfvubmIu 5xKepMlCoyYyBlbi5IGuHHh6i+76mEdrXwN0tf/1JiMB+gxr3Ej9Ud7K1wxKbjWsglhsl0WQGEadJ uK3TaVp/BOTFYDBkGxfRMG5Lirxoq8f4y5LTmhJSAPkC29yQ7faMP0V/VVip3+/ARY2SNoudT+F+1 9xlXnX1Hxnd+MwPskePQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9PN-00EaLx-Ax; Tue, 14 Dec 2021 15:08:01 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9PJ-00EaJH-8R for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 15:07:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01EC5B81A26 for ; Tue, 14 Dec 2021 15:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B6DC34601 for ; Tue, 14 Dec 2021 15:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639494474; bh=rPVk2jDfAiR4nn6IGpYxU9DbCVEZmbX3NRqFQoR/jQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QiOSR8KnLXPd/H9z7BnLTVpGWw0A2kW5JAgn5mJ5xnpDODI3c8GJNzX0OxNSQMjhn nMCybDQxzubVRSjsm+LT2rlMaUpDYDUdN0iV2XhY89WgKr3wWXfdGU4fE741XB2xoB /sX6SncElo3inOYPzQJwYplN/vJceqXCyqgG8kNNGYK+qNZRFHC9KumOT1bHbJiyi7 cuhAzjR1TsGnggKMZ7qK5Y6ZFpRnYWZ7Cw+0re12Pr3y61I13+MpOLsYtTxRWsyIqH OGBZaxMegCFxLKiNZfDCbW8fM13r3S6o9P0bIruV3FOVJFAaZ37oxWktNsMm7hbjPQ sbayLg+htrx4A== Received: by mail-ed1-f51.google.com with SMTP id z9so9406994edb.5 for ; Tue, 14 Dec 2021 07:07:54 -0800 (PST) X-Gm-Message-State: AOAM5328nxlUH1oPM/vv7Fz28ZrqCjTqqIYnGmsTpxnlkTT61GSGwHv7 JB+O55s1XThNqBX0wFkTaD4Bh1lJdzd3IYmcgw== X-Google-Smtp-Source: ABdhPJxf5YHSaPknEFNU2A9Af9vjayodsoldMQfptOk8XsIiNGL8Y+79xGZquCFPYdXox6JhXgRtWzFzb7ICr0iQ9pE= X-Received: by 2002:a17:906:229b:: with SMTP id p27mr6246957eja.264.1639494466650; Tue, 14 Dec 2021 07:07:46 -0800 (PST) MIME-Version: 1.0 References: <20211214013800.2703568-1-vladimir.oltean@nxp.com> <20211214013800.2703568-2-vladimir.oltean@nxp.com> In-Reply-To: <20211214013800.2703568-2-vladimir.oltean@nxp.com> From: Rob Herring Date: Tue, 14 Dec 2021 09:07:33 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH devicetree 01/10] irqchip/ls-extirq: rename "interrupt-map" OF property to "fsl,extirq-map" To: Vladimir Oltean Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Marc Zyngier , Shawn Guo , Li Yang , Biwen Li , Zhiqiang Hou , Kurt Kanzenbach , Rasmus Villemoes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_070757_596014_F669F3AE X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 13, 2021 at 7:38 PM Vladimir Oltean wrote: > > This OF property was supposed to be named "fsl,extirq-map" since the > first patch submissions, but at Rob Herring's suggestion it was named > "interrupt-map": > https://lore.kernel.org/lkml/20190927161118.GA19333@bogus/ I'm still not okay with a custom property. The fact that multiple platforms need the same thing is an indication this should be common. Other cases are being fixed by using 'interrupts', but that's going to take some cleanups[1]. > At that time, the "interrupt-map" was ignored by the core for OF nodes > that also had an "interrupt-controller" property, but that changed with > commit 041284181226 ("of/irq: Allow matching of an interrupt-map local > to an interrupt controller"), which made the consumer drivers of the > ls-extirq break. To work around this breakage, the OF bindings for IRQs > have introduced a table of "OF IRQ interrupt-map abusers". > This can be seen in commit de4adddcbcc2 ("of/irq: Add a quirk for > controllers with their own definition of interrupt-map"). > > To stop being abusers, let's go back to the original form of these > bindings, before Rob's review. Compatibility will be kept with the > current abusive bindings for a few more kernel cycles, to give people > some time to update. But to also give them an incentive, print a warning > that the support for "interrupt-map" will be removed. This will be seen > when running a new kernel with an old device tree. > > While the breakage was introduced relatively recently, the device tree > changes are intended to backport stable kernels for quicker conversion > to an acceptable set of bindings, and this driver will need to support > the updated stable bindings. Using 'interrupts' is not going to work backporting to stable, but I don't think trying to switch this is worth it. Rob [1] https://lore.kernel.org/all/CAL_Jsq+jyqbhA1jpgZ+yTwWGvCMRu9VmgoDq8MDM9SMqJ-XSBw@mail.gmail.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel