From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by gmr-mx.google.com with ESMTPS id f204si391883pfa.5.2020.12.10.14.57.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2020 14:57:09 -0800 (PST) MIME-Version: 1.0 References: <20201210192536.118432146@linutronix.de> <20201210194044.473308721@linutronix.de> In-Reply-To: <20201210194044.473308721@linutronix.de> From: Rob Herring Date: Thu, 10 Dec 2020 16:56:55 -0600 Message-ID: Subject: Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data() Content-Type: text/plain; charset="UTF-8" To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Marc Zyngier , Karthikeyan Mitran , Hou Zhiqiang , Lorenzo Pieralisi , Bjorn Helgaas , PCI , "James E.J. Bottomley" , Helge Deller , afzal mohammed , linux-parisc@vger.kernel.org, Russell King , linux-arm-kernel , Mark Rutland , Catalin Marinas , Will Deacon , Christian Borntraeger , Heiko Carstens , linux-s390@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Pankaj Bharadiya , Chris Wilson , Wambui Karuga , Intel Graphics , dri-devel , Tvrtko Ursulin , Linus Walleij , "open list:GPIO SUBSYSTEM" , Lee Jones , Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, Michal Simek , Tariq Toukan , "David S. Miller" , Jakub Kicinski , netdev , linux-rdma@vger.kernel.org, Saeed Mahameed , Leon Romanovsky , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org List-ID: On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant for the chip while using the irq descriptor variant > returns the irq chip data of the top level chip of a hierarchy. It does not > matter in this case because the chip is the top level chip, but that > doesn't make it more correct. > > Signed-off-by: Thomas Gleixner > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32228C4361B for ; Thu, 10 Dec 2020 22:57:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA5C023CD0 for ; Thu, 10 Dec 2020 22:57:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA5C023CD0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DCC36EB91; Thu, 10 Dec 2020 22:57:11 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB2246EB8E; Thu, 10 Dec 2020 22:57:09 +0000 (UTC) X-Gm-Message-State: AOAM531wzZ1XhmfyVP9RsfOK4frUz8Ig55UIGYOQJhKwL/8QJg4MvRCC xsg3o+aE3+CUkbSiS/5FZOsyO5ohFWFelICDcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607641029; bh=CumYBB9xVU4mI+ysFQ9GC3xvipGC4R7OnFI2Gfa5FNQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NX100t6gCQytNa7OiazwnNywlnnE3MGA+EwIsG1KwPo3g9YIMvMkZenkX6DPjonLX LgiB+WhmPpHDqq68su5+am2qlFC3dPRt63g4quEmvydBolDCLPaFApKatvOjZ8QpSh t8DP63zX380Hmbe21aY/TXXZZVUGRRb9HCRBFVBeJscvK+q7L14Fm/b/rqKNPyMDp7 LGbf/bPcWcrfMi1ra6Q9AGb5RMSUk/KMDinLe6YXNtA4nslj1hondib08OcOsoqaUl R8VDvstTAeLsboQByXDyHliDd1PrRisKjrGFVbj5XTLtWTbNK+FOWwSfjLDaWtlE1h FDGHWjLjPHW1g== X-Google-Smtp-Source: ABdhPJyKMB0fAO5ccR1ON7eKp3wop/g844H0Em6KIAw65vcwOioEZudsqFxyo2xMX2ascC0HxcRxz5ivmcQz5wtwB24= X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr8477099ejz.341.1607641026526; Thu, 10 Dec 2020 14:57:06 -0800 (PST) MIME-Version: 1.0 References: <20201210192536.118432146@linutronix.de> <20201210194044.473308721@linutronix.de> In-Reply-To: <20201210194044.473308721@linutronix.de> From: Rob Herring Date: Thu, 10 Dec 2020 16:56:55 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data() To: Thomas Gleixner X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Karthikeyan Mitran , Peter Zijlstra , Catalin Marinas , dri-devel , Chris Wilson , "James E.J. Bottomley" , Saeed Mahameed , netdev , Will Deacon , Michal Simek , linux-s390@vger.kernel.org, afzal mohammed , Lorenzo Pieralisi , Dave Jiang , xen-devel@lists.xenproject.org, Leon Romanovsky , linux-rdma@vger.kernel.org, Marc Zyngier , Helge Deller , Russell King , Christian Borntraeger , PCI , Jakub Kicinski , Heiko Carstens , Wambui Karuga , Allen Hubbe , Juergen Gross , Tvrtko Ursulin , Hou Zhiqiang , "open list:GPIO SUBSYSTEM" , Stefano Stabellini , Rodrigo Vivi , Bjorn Helgaas , Lee Jones , linux-arm-kernel , Boris Ostrovsky , David Airlie , linux-parisc@vger.kernel.org, Pankaj Bharadiya , LKML , Tariq Toukan , Jon Mason , linux-ntb@googlegroups.com, Intel Graphics , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant for the chip while using the irq descriptor variant > returns the irq chip data of the top level chip of a hierarchy. It does not > matter in this case because the chip is the top level chip, but that > doesn't make it more correct. > > Signed-off-by: Thomas Gleixner > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B081C433FE for ; Thu, 10 Dec 2020 22:57:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FA0123CD0 for ; Thu, 10 Dec 2020 22:57:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FA0123CD0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9486F6EB8E; Thu, 10 Dec 2020 22:57:10 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB2246EB8E; Thu, 10 Dec 2020 22:57:09 +0000 (UTC) X-Gm-Message-State: AOAM531wzZ1XhmfyVP9RsfOK4frUz8Ig55UIGYOQJhKwL/8QJg4MvRCC xsg3o+aE3+CUkbSiS/5FZOsyO5ohFWFelICDcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607641029; bh=CumYBB9xVU4mI+ysFQ9GC3xvipGC4R7OnFI2Gfa5FNQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NX100t6gCQytNa7OiazwnNywlnnE3MGA+EwIsG1KwPo3g9YIMvMkZenkX6DPjonLX LgiB+WhmPpHDqq68su5+am2qlFC3dPRt63g4quEmvydBolDCLPaFApKatvOjZ8QpSh t8DP63zX380Hmbe21aY/TXXZZVUGRRb9HCRBFVBeJscvK+q7L14Fm/b/rqKNPyMDp7 LGbf/bPcWcrfMi1ra6Q9AGb5RMSUk/KMDinLe6YXNtA4nslj1hondib08OcOsoqaUl R8VDvstTAeLsboQByXDyHliDd1PrRisKjrGFVbj5XTLtWTbNK+FOWwSfjLDaWtlE1h FDGHWjLjPHW1g== X-Google-Smtp-Source: ABdhPJyKMB0fAO5ccR1ON7eKp3wop/g844H0Em6KIAw65vcwOioEZudsqFxyo2xMX2ascC0HxcRxz5ivmcQz5wtwB24= X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr8477099ejz.341.1607641026526; Thu, 10 Dec 2020 14:57:06 -0800 (PST) MIME-Version: 1.0 References: <20201210192536.118432146@linutronix.de> <20201210194044.473308721@linutronix.de> In-Reply-To: <20201210194044.473308721@linutronix.de> From: Rob Herring Date: Thu, 10 Dec 2020 16:56:55 -0600 X-Gmail-Original-Message-ID: Message-ID: To: Thomas Gleixner Subject: Re: [Intel-gfx] [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Karthikeyan Mitran , Peter Zijlstra , Catalin Marinas , Linus Walleij , dri-devel , Chris Wilson , "James E.J. Bottomley" , Saeed Mahameed , netdev , Will Deacon , Michal Simek , linux-s390@vger.kernel.org, afzal mohammed , Lorenzo Pieralisi , Dave Jiang , xen-devel@lists.xenproject.org, Leon Romanovsky , linux-rdma@vger.kernel.org, Marc Zyngier , Helge Deller , Russell King , Christian Borntraeger , PCI , Jakub Kicinski , Heiko Carstens , Wambui Karuga , Allen Hubbe , Juergen Gross , Hou Zhiqiang , "open list:GPIO SUBSYSTEM" , Stefano Stabellini , Bjorn Helgaas , Lee Jones , linux-arm-kernel , Boris Ostrovsky , David Airlie , linux-parisc@vger.kernel.org, LKML , Tariq Toukan , Jon Mason , linux-ntb@googlegroups.com, Intel Graphics , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant for the chip while using the irq descriptor variant > returns the irq chip data of the top level chip of a hierarchy. It does not > matter in this case because the chip is the top level chip, but that > doesn't make it more correct. > > Signed-off-by: Thomas Gleixner > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by gmr-mx.google.com with ESMTPS id f204si391883pfa.5.2020.12.10.14.57.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2020 14:57:09 -0800 (PST) MIME-Version: 1.0 References: <20201210192536.118432146@linutronix.de> <20201210194044.473308721@linutronix.de> In-Reply-To: <20201210194044.473308721@linutronix.de> From: Rob Herring Date: Thu, 10 Dec 2020 16:56:55 -0600 Message-ID: Subject: Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data() Content-Type: text/plain; charset="UTF-8" To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Marc Zyngier , Karthikeyan Mitran , Hou Zhiqiang , Lorenzo Pieralisi , Bjorn Helgaas , PCI , "James E.J. Bottomley" , Helge Deller , afzal mohammed , linux-parisc@vger.kernel.org, Russell King , linux-arm-kernel , Mark Rutland , Catalin Marinas , Will Deacon , Christian Borntraeger , Heiko Carstens , linux-s390@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Pankaj Bharadiya , Chris Wilson , Wambui Karuga , Intel Graphics , dri-devel , Tvrtko Ursulin , Linus Walleij , "open list:GPIO SUBSYSTEM" , Lee Jones , Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, Michal Simek , Tariq Toukan , "David S. Miller" , Jakub Kicinski , netdev , linux-rdma@vger.kernel.org, Saeed Mahameed , Leon Romanovsky , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org List-ID: On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant for the chip while using the irq descriptor variant > returns the irq chip data of the top level chip of a hierarchy. It does not > matter in this case because the chip is the top level chip, but that > doesn't make it more correct. > > Signed-off-by: Thomas Gleixner > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring