From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver Date: Mon, 30 Jul 2018 16:06:14 -0600 Message-ID: References: <20180723214751.1733-1-jae.hyun.yoo@linux.intel.com> <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jae Hyun Yoo Cc: Mark Rutland , Andrew Lunn , Randy Dunlap , linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, fbarrat@linux.vnet.ibm.com, Mauro Carvalho Chehab , Lee Jones , Jason M Biils , sandeen@redhat.com, Lorenzo Pieralisi , Jonathan Corbet , OpenBMC Maillist , Linux Doc Mailing List , Kishon Vijay Abraham I , Joel Stanley , bryantly@linux.vnet.ibm.com, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , david.kershner@unisys.com, Guenter Roeck , Wu Hao , Linux HWMON List , Jean Delvare Arnd Bergmann List-Id: devicetree@vger.kernel.org On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo wrote: > > This commit adds PECI dimmtemp hwmon driver. > > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id peci_dimmtemp_of_table[] = { > + { .compatible = "intel,peci-dimmtemp" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table); > +#endif This should be removed. Same for cpu temp driver I'm guessing. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=robh+dt@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LYyUb4Nf"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41fYZ15ZYNzF14h; Tue, 31 Jul 2018 08:06:30 +1000 (AEST) Received: from mail-qt0-f180.google.com (mail-qt0-f180.google.com [209.85.216.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3752208C1; Mon, 30 Jul 2018 22:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532988388; bh=9ZdJs5meBKxWRx5UNIX0E7L78FwYjZbeBMPSbMUjI6I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LYyUb4NfjF6dYbt3xSZVLJuKx6g5xV3ooT0z+57K8PI/qJpDeZhFupK46cxvKbfAt m2eMbOQjuCiTH3HMt6g+Va2TJlbn0NbUWABZRPft7vmxhGNsICKX6dbnhObUdpSkNz qz7irutNKCccd3pD5A2wR0g6rZG0LCLEBDzYLay0= Received: by mail-qt0-f180.google.com with SMTP id q12-v6so13854409qtp.6; Mon, 30 Jul 2018 15:06:27 -0700 (PDT) X-Gm-Message-State: AOUpUlEfPQIv5v5xqpf/rdn5DNFd0MMpbL6QoIyPVlClHjxFSH/16MJ0 qzJzjik4hc3PuyOi0c5HTO8+hvAFz7MryoKggA== X-Google-Smtp-Source: AAOMgpfd9GZtkmuMU5VO2AiX5OfvVkeO9yzDxC2JLbph1ixxgtkhCSL7uC0UDMWINLElcU7dQZYBlx3+rLz4jT/Ddac= X-Received: by 2002:ac8:96b:: with SMTP id z40-v6mr18413901qth.362.1532988386011; Mon, 30 Jul 2018 15:06:26 -0700 (PDT) MIME-Version: 1.0 References: <20180723214751.1733-1-jae.hyun.yoo@linux.intel.com> <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> In-Reply-To: <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> From: Rob Herring Date: Mon, 30 Jul 2018 16:06:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver To: Jae Hyun Yoo Cc: Jean Delvare , Guenter Roeck , Mark Rutland , Lee Jones , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Greg Kroah-Hartman , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , darrick.wong@oracle.com, sandeen@redhat.com, Arnd Bergmann , Wu Hao , kusumi.tomohiro@gmail.com, bryantly@linux.vnet.ibm.com, fbarrat@linux.vnet.ibm.com, David Miller , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod , Stephen Boyd , david.kershner@unisys.com, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Sagar Dharia , Johan Hovold , Thomas Gleixner , jgross@suse.com, Cyrille Pitchen , Linux HWMON List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-aspeed@lists.ozlabs.org, Linux Doc Mailing List , OpenBMC Maillist , Alan Cox , Andy Shevchenko , Jason M Biils , Miguel Ojeda Sandonis , Andrew Lunn , Stef van Os Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 31 Jul 2018 10:00:14 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 22:06:35 -0000 On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo wrote: > > This commit adds PECI dimmtemp hwmon driver. > > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id peci_dimmtemp_of_table[] = { > + { .compatible = "intel,peci-dimmtemp" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table); > +#endif This should be removed. Same for cpu temp driver I'm guessing. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh+dt@kernel.org (Rob Herring) Date: Mon, 30 Jul 2018 16:06:14 -0600 Subject: [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver In-Reply-To: <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> References: <20180723214751.1733-1-jae.hyun.yoo@linux.intel.com> <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo wrote: > > This commit adds PECI dimmtemp hwmon driver. > > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id peci_dimmtemp_of_table[] = { > + { .compatible = "intel,peci-dimmtemp" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table); > +#endif This should be removed. Same for cpu temp driver I'm guessing. Rob