From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0067C433E0 for ; Thu, 14 May 2020 20:36:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ED412065C for ; Thu, 14 May 2020 20:36:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="n6NfkBni" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ED412065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED8A86E393; Thu, 14 May 2020 20:36:58 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id B70A46E393 for ; Thu, 14 May 2020 20:36:57 +0000 (UTC) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C44120709 for ; Thu, 14 May 2020 20:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589488617; bh=f1NuuVqza0Qs6n3g5b50kVYLmu7TLHdJRReJmIH2EDo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=n6NfkBni9fWlwknht2a8iYmGpICIZhiXjy164/rv+EeUuZVCnescceoveoxdclJAZ SveUeYlE6nZGoaJkwNbakhGTjYImZojaunoOkgh6f78wIdDOAv4Rp63pRZU2i4KRyh FNlOk/EZauoM5sxMgsMkGGpwafHTo+lJO8AB9I6M= Received: by mail-oi1-f175.google.com with SMTP id r25so247303oij.4 for ; Thu, 14 May 2020 13:36:57 -0700 (PDT) X-Gm-Message-State: AGi0PubG7nNa+PxnlFZMmjnfYGjr6YjQmBxgiiPCQS9lpxdRfkGwDnkC +LMqSRLJDWYblOqIPJl47al7giZqwB61Wppnog== X-Google-Smtp-Source: APiQypLzeQ50wbEw/x0qOorKXKApWmznb9uVAvVf3txqiFIx4a7ajD0bNZdMRFtO25r7ZbwPeU03grSHsPhn5R41akU= X-Received: by 2002:aca:1904:: with SMTP id l4mr32652485oii.106.1589488616799; Thu, 14 May 2020 13:36:56 -0700 (PDT) MIME-Version: 1.0 References: <20200513150312.21421-1-tzimmermann@suse.de> <20200513150312.21421-2-tzimmermann@suse.de> <20200514124050.GV206103@phenom.ffwll.local> In-Reply-To: <20200514124050.GV206103@phenom.ffwll.local> From: Rob Herring Date: Thu, 14 May 2020 15:36:45 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] drm/shmem: Use cached mappings by default To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sean Paul , Emil Velikov , dri-devel , Gerd Hoffmann , Thomas Zimmermann , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: > > On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: > > SHMEM-buffer backing storage is allocated from system memory; which is > > typically cachable. Currently, only virtio uses cachable mappings; udl > > uses its own vmap/mmap implementation for cachable mappings. Other > > drivers default to writecombine mappings. > > I'm pretty sure this breaks all these drivers. quick grep on a few > functions says this is used by lima, panfrost, v3d. And they definitely > need uncached/wc stuff afaiui. Or I'm completely missing something? Yes, that would be my guess. DMA is usually non-coherent on Arm. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel