From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbdBUOo1 (ORCPT ); Tue, 21 Feb 2017 09:44:27 -0500 Received: from mail.kernel.org ([198.145.29.136]:57006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdBUOoS (ORCPT ); Tue, 21 Feb 2017 09:44:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170208200010.21522-1-ulli.kroll@googlemail.com> <20170208200010.21522-3-ulli.kroll@googlemail.com> <20170215230042.4m3niqf5wizbrgb4@rob-hp-laptop> From: Rob Herring Date: Tue, 21 Feb 2017 08:43:53 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller To: Hans Ulli Kroll Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Linux USB List , Greg Kroah-Hartman , Mark Rutland , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 4:07 AM, Hans Ulli Kroll wrote: > Hi Rob, > > On Wed, 15 Feb 2017, Rob Herring wrote: > >> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote: >> > This adds DT bindings for the Faraday FOTG2 host controller. >> > >> > Signed-off-by: Hans Ulli Kroll >> > --- >> > Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt >> > >> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> > new file mode 100644 >> > index 000000000000..4c07566a4bf5 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> > @@ -0,0 +1,15 @@ >> > +Faraday FOTG Host controller >> > + >> > +Required properties: >> > + >> > +- compatible: should be "faraday,fotg210-hcd" >> >> hcd as in "host controller driver"? Bindings describe h/w not drivers. >> >> It's an OTG controller or host controller? >> > > here only the host controller part used. > > faraday fotg2 is a dual role hcd/otg device and here is only the > host part used. Because you don't care about device mode or restricted by the IP configuration or SoC integration? The former is a user choice and shouldn't be part of DT. The latter should be implied by an SoC specific compatible string. Using only a compatible string for a licensed IP is not specific enough as vendors use differing versions and integrate them in different ways. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Date: Tue, 21 Feb 2017 08:43:53 -0600 Message-ID: References: <20170208200010.21522-1-ulli.kroll@googlemail.com> <20170208200010.21522-3-ulli.kroll@googlemail.com> <20170215230042.4m3niqf5wizbrgb4@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans Ulli Kroll Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux USB List , Greg Kroah-Hartman , Mark Rutland , Linus Walleij List-Id: devicetree@vger.kernel.org On Fri, Feb 17, 2017 at 4:07 AM, Hans Ulli Kroll wrote: > Hi Rob, > > On Wed, 15 Feb 2017, Rob Herring wrote: > >> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote: >> > This adds DT bindings for the Faraday FOTG2 host controller. >> > >> > Signed-off-by: Hans Ulli Kroll >> > --- >> > Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt >> > >> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> > new file mode 100644 >> > index 000000000000..4c07566a4bf5 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> > @@ -0,0 +1,15 @@ >> > +Faraday FOTG Host controller >> > + >> > +Required properties: >> > + >> > +- compatible: should be "faraday,fotg210-hcd" >> >> hcd as in "host controller driver"? Bindings describe h/w not drivers. >> >> It's an OTG controller or host controller? >> > > here only the host controller part used. > > faraday fotg2 is a dual role hcd/otg device and here is only the > host part used. Because you don't care about device mode or restricted by the IP configuration or SoC integration? The former is a user choice and shouldn't be part of DT. The latter should be implied by an SoC specific compatible string. Using only a compatible string for a licensed IP is not specific enough as vendors use differing versions and integrate them in different ways. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html