From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] arm64: dts: rockchip: Add Beelink A1 Date: Mon, 7 Oct 2019 07:53:06 -0500 Message-ID: References: <9037b7edbbb41cbbf699ebe3a511daf22d886e7d.1570444695.git.robin.murphy@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9037b7edbbb41cbbf699ebe3a511daf22d886e7d.1570444695.git.robin.murphy@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robin Murphy Cc: devicetree@vger.kernel.org, "heiko@sntech.de" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:ARM/Rockchip SoC..." List-Id: devicetree@vger.kernel.org On Mon, Oct 7, 2019 at 6:33 AM Robin Murphy wrote: > > Beelink A1 is a TV box implementing the higher-end options of the > RK3328 reference design - the DTB from the stock Android firmware is > clearly the "rk3328-box-plus" variant from the Rockchip 3.10 BSP with > minor modifications to accommodate the USB WiFi module and additional > VFD-style LED driver. It features: > > - 4GB of 32-bit LPDDR3 > - 16GB of HS200 eMMC (newer models with 32GB also exist) > - Realtek RTL8211F phy for gigabit ethernet > - Fn-Link 6221E-UUC module (RealTek RTL8821CU) for 11ac WiFi and Bluetooth 4.2 > - HDMI and analog A/V > - 1x USB 3.0 type A host, 1x USB 2.0 type A OTG, 1x micro SD > - IR receiver and a neat little LED clock display. > > Signed-off-by: Robin Murphy > --- > > One question I'm wondering about is whether it's worth pushing the HDMI > and analog codec audio cards down into rk3328.dtsi (as with HDMI audio > on RK3399), since those audio pipelines are internal to the SoC and the > board only really governs whether the outputs are wired up or not. Seems reasonable. One other candidate below. > > .../devicetree/bindings/arm/rockchip.yaml | 5 + In the future, please split bindings to a separate patch. > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 399 ++++++++++++++++++ > 3 files changed, 405 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-a1.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index c82c5e57d44c..f27f7805f57e 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -40,6 +40,11 @@ properties: > - const: asus,rk3288-tinker-s > - const: rockchip,rk3288 > > + - description: Beelink A1 > + items: > + - const: azw,beelink-a1 > + - const: rockchip,rk3328 > + > - description: bq Curie 2 tablet > items: > - const: mundoreader,bq-curie2 > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 1f18a9392d15..a6f250e7cde2 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-a1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-rock64.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-cc.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts > new file mode 100644 > index 000000000000..03ad663ff821 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts > @@ -0,0 +1,399 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) > +// Copyright (c) 2017-2019 Arm Ltd. > + > +/dts-v1/; > +#include "rk3328.dtsi" > + > +/ { > + model = "Beelink A1"; > + compatible = "azw,beelink-a1", "rockchip,rk3328"; > + > + /* > + * UART pins, as viewed with bottom of case removed: > + * > + * Front > + * /------- > + * L / o <- Gnd > + * e / o <-- Rx > + * f / o <--- Tx > + * t / o <---- +3.3v > + * | > + */ > + chosen { > + stdout-path = "serial2:1500000n8"; > + }; > + > + gmac_clkin: external-gmac-clock { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "gmac_clkin"; > + #clock-cells = <0>; > + }; > + > + vcc_host_5v: usb3-current-switch { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb30_host_drv>; > + regulator-name = "vcc_host_5v"; > + vin-supply = <&vcc_sys>; > + }; > + > + vcc_sys: vcc-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_sys"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > + cpus { > + idle-states { > + entry-method = "arm,psci"; > + > + cpu_sleep: cpu-sleep { > + compatible = "arm,idle-state"; > + arm,psci-suspend-param = <0x0010000>; > + local-timer-stop; > + entry-latency-us = <120>; > + exit-latency-us = <250>; > + min-residency-us = <900>; This doesn't seem like something that's board specific, but I guess the regulator could have some influence on these times. If so, the board file could always override a default. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8BCECE58C for ; Mon, 7 Oct 2019 12:53:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE345205F4 for ; Mon, 7 Oct 2019 12:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cFFJH2v5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JX33LU9c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE345205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYuLwdtdFJDdYaInlnUZr9qWw2RADVihYkgCUVG147w=; b=cFFJH2v5ZE4OFC YUM1zJkN++0HwbkaMi1seePFzZ0vWNhuihZJsQCBw3yypJrWu8TQ+rjd/+yfRGL8BiiNVBsxD+li4 /T5VE/MaB4YfjocJgCtdioWcEaknONOf6FiNPcsH0yC0wRntXPJICPNRkdmeOObObwsl/tLZIlhlh X0eHZdkizbhlUjr2XXu5B8dMYSsa/sA2owoeWvehtYs2VosMC3nAZHEUIxOPAbwdZupRnU02O996w Y5l0uNwbxK7xKfaf+8MjJZ8Z6FQfmJyGKQxUoWr+1bH5aG1nwvKqPxyTKOyHqqak21bITtJES5i1V pnJnhgttwz85tc+fMCIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHSVv-00083r-JV; Mon, 07 Oct 2019 12:53:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHSVs-00083C-AG; Mon, 07 Oct 2019 12:53:21 +0000 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98CFC205F4; Mon, 7 Oct 2019 12:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570452798; bh=OcHeLP/qq1aPvsGSRiYbAIE/VJP24hQJgPul4zHU15w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JX33LU9cJQALFkkcYviaIM3iBwEAe/CidRD1RIZiJ4l4hgydMuVM+hRcJj4FSWTpN E7of9qQYmDsRsBy6+LfexyztiOnt27J7Zc+8NR1W02G1KOry0lpzH6Q0AVfJEyNEhe A8DpVEamD2GeSKLceSJlijpdcJ96X0FpBVMSbeJk= Received: by mail-qk1-f172.google.com with SMTP id h126so12378390qke.10; Mon, 07 Oct 2019 05:53:18 -0700 (PDT) X-Gm-Message-State: APjAAAVlKcFNrEbeWdl2MWxi6X2DGaTyGE9IHJdxInV4VQgXUh1WOtYu HSpAnLOwLkbaoD2oUZYb0g5bjDAI3g9VYKcMgA== X-Google-Smtp-Source: APXvYqwlKfXgpwy3ehPZWxTgG9eiCTZ6s5SoFYAM/1PDHBgNGMa6ZXPufLcYTCelh6Tj9O1lBlYZxD004Ih/FW/sVjg= X-Received: by 2002:a37:be87:: with SMTP id o129mr23745015qkf.254.1570452797681; Mon, 07 Oct 2019 05:53:17 -0700 (PDT) MIME-Version: 1.0 References: <9037b7edbbb41cbbf699ebe3a511daf22d886e7d.1570444695.git.robin.murphy@arm.com> In-Reply-To: <9037b7edbbb41cbbf699ebe3a511daf22d886e7d.1570444695.git.robin.murphy@arm.com> From: Rob Herring Date: Mon, 7 Oct 2019 07:53:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: Add Beelink A1 To: Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_055320_394067_0BE485AD X-CRM114-Status: GOOD ( 22.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "heiko@sntech.de" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 7, 2019 at 6:33 AM Robin Murphy wrote: > > Beelink A1 is a TV box implementing the higher-end options of the > RK3328 reference design - the DTB from the stock Android firmware is > clearly the "rk3328-box-plus" variant from the Rockchip 3.10 BSP with > minor modifications to accommodate the USB WiFi module and additional > VFD-style LED driver. It features: > > - 4GB of 32-bit LPDDR3 > - 16GB of HS200 eMMC (newer models with 32GB also exist) > - Realtek RTL8211F phy for gigabit ethernet > - Fn-Link 6221E-UUC module (RealTek RTL8821CU) for 11ac WiFi and Bluetooth 4.2 > - HDMI and analog A/V > - 1x USB 3.0 type A host, 1x USB 2.0 type A OTG, 1x micro SD > - IR receiver and a neat little LED clock display. > > Signed-off-by: Robin Murphy > --- > > One question I'm wondering about is whether it's worth pushing the HDMI > and analog codec audio cards down into rk3328.dtsi (as with HDMI audio > on RK3399), since those audio pipelines are internal to the SoC and the > board only really governs whether the outputs are wired up or not. Seems reasonable. One other candidate below. > > .../devicetree/bindings/arm/rockchip.yaml | 5 + In the future, please split bindings to a separate patch. > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 399 ++++++++++++++++++ > 3 files changed, 405 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-a1.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index c82c5e57d44c..f27f7805f57e 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -40,6 +40,11 @@ properties: > - const: asus,rk3288-tinker-s > - const: rockchip,rk3288 > > + - description: Beelink A1 > + items: > + - const: azw,beelink-a1 > + - const: rockchip,rk3328 > + > - description: bq Curie 2 tablet > items: > - const: mundoreader,bq-curie2 > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 1f18a9392d15..a6f250e7cde2 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-a1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-rock64.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-cc.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts > new file mode 100644 > index 000000000000..03ad663ff821 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts > @@ -0,0 +1,399 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) > +// Copyright (c) 2017-2019 Arm Ltd. > + > +/dts-v1/; > +#include "rk3328.dtsi" > + > +/ { > + model = "Beelink A1"; > + compatible = "azw,beelink-a1", "rockchip,rk3328"; > + > + /* > + * UART pins, as viewed with bottom of case removed: > + * > + * Front > + * /------- > + * L / o <- Gnd > + * e / o <-- Rx > + * f / o <--- Tx > + * t / o <---- +3.3v > + * | > + */ > + chosen { > + stdout-path = "serial2:1500000n8"; > + }; > + > + gmac_clkin: external-gmac-clock { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "gmac_clkin"; > + #clock-cells = <0>; > + }; > + > + vcc_host_5v: usb3-current-switch { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb30_host_drv>; > + regulator-name = "vcc_host_5v"; > + vin-supply = <&vcc_sys>; > + }; > + > + vcc_sys: vcc-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_sys"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > + cpus { > + idle-states { > + entry-method = "arm,psci"; > + > + cpu_sleep: cpu-sleep { > + compatible = "arm,idle-state"; > + arm,psci-suspend-param = <0x0010000>; > + local-timer-stop; > + entry-latency-us = <120>; > + exit-latency-us = <250>; > + min-residency-us = <900>; This doesn't seem like something that's board specific, but I guess the regulator could have some influence on these times. If so, the board file could always override a default. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel