From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A03FFC433EF for ; Tue, 14 Dec 2021 14:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235106AbhLNOzg (ORCPT ); Tue, 14 Dec 2021 09:55:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235094AbhLNOzf (ORCPT ); Tue, 14 Dec 2021 09:55:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E1AC061574; Tue, 14 Dec 2021 06:55:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0BA36B81A27; Tue, 14 Dec 2021 14:55:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4878C34608; Tue, 14 Dec 2021 14:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639493732; bh=C2LcvhA1apLsd/J3FjPL4byMqJQOhBWtjSWge+wo0os=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WZdob95b6Y8QdyEvI4JYHGBLLsENxY4e/ZAXWqdL6lLQURj0Pt+4jj8LRdCfrUKXN GuL+PksyAyQ0g5AWJye3bFXIc+af05uSx5oW5LQtTuGEzqAKGy5mcBkVC05XQwh+4i MvHzCRsKp5s8t8csmoD36SIZiTzhErAylsArbK/Qw4UBi+aM/QJkm1HzXvvxSgoE5O Ejk3NSYhlPE+qlT9Fm8/1dTliH8QF3ogx+8tHC35LN6pJttaeLXF2vogcHncmlcdGn P/PTwNK1HmUaiSeXI1LRzQ4LUZaTvXplODgnnzeGvqmzOsQ2czEoaq33KO1yyk9EpQ dOi0tK2rk42tw== Received: by mail-ed1-f44.google.com with SMTP id e3so64808145edu.4; Tue, 14 Dec 2021 06:55:32 -0800 (PST) X-Gm-Message-State: AOAM531JoinU+A+rBW3FwWAz1vX8LLRqumSTqguLewdZEibkROwlR7jQ R5+brgXAfWsxYarazwi2h6bAQ+q46HN/4L79AA== X-Google-Smtp-Source: ABdhPJxvID0st4brf7Pqm/fwq+GHY79flSCV18kMw4vXOMU73jEh+BwF4OfwrpHFrz1ypoRgiBnA6VMQSTNocFK6Hw4= X-Received: by 2002:a17:906:7945:: with SMTP id l5mr6347314ejo.82.1639493730755; Tue, 14 Dec 2021 06:55:30 -0800 (PST) MIME-Version: 1.0 References: <20211214040157.27443-1-kernelfans@gmail.com> <20211214040157.27443-3-kernelfans@gmail.com> In-Reply-To: <20211214040157.27443-3-kernelfans@gmail.com> From: Rob Herring Date: Tue, 14 Dec 2021 08:55:18 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/2] efi: apply memblock cap after memblock_add() To: Pingfan Liu Cc: devicetree@vger.kernel.org, linux-efi , Zhen Lei , Catalin Marinas , Will Deacon , Andrew Morton , Mike Rapoport , Geert Uytterhoeven , Frank Rowand , Ard Biesheuvel , Nick Terrell , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 13, 2021 at 10:02 PM Pingfan Liu wrote: > > On arm64, during kdump kernel saves vmcore, it runs into the following bu= g: > ... > [ 15.148919] usercopy: Kernel memory exposure attempt detected from SLU= B object 'kmem_cache_node' (offset 0, size 4096)! > [ 15.159707] ------------[ cut here ]------------ > [ 15.164311] kernel BUG at mm/usercopy.c:99! > [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP > [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha= 2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_km= s_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper t= tm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_co= re dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress = loop > [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 > [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 = (SCP: 1.5.20210426) 05/13/2021 > [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYP= E=3D--) > [ 15.228073] pc : usercopy_abort+0x9c/0xa0 > [ 15.232074] lr : usercopy_abort+0x9c/0xa0 > [ 15.236070] sp : ffff8000121abba0 > [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 000000000= 0000000 > [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 000000000= 0000000 > [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 000000000= 0000001 > [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: fffffffff= fffffff > [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 657463657= 4656420 > [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202= c302074 > [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04= 012812c > [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 000000000= 0000000 > [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 000000000= 0000000 > [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000= 000006b > [ 15.310593] Call trace: > [ 15.313027] usercopy_abort+0x9c/0xa0 > [ 15.316677] __check_heap_object+0xd4/0xf0 > [ 15.320762] __check_object_size.part.0+0x160/0x1e0 > [ 15.325628] __check_object_size+0x2c/0x40 > [ 15.329711] copy_oldmem_page+0x7c/0x140 > [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 > [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 > [ 15.342920] read_vmcore+0x28/0x34 > [ 15.346309] proc_reg_read+0xb4/0xf0 > [ 15.349871] vfs_read+0xb8/0x1f0 > [ 15.353088] ksys_read+0x74/0x100 > [ 15.356390] __arm64_sys_read+0x28/0x34 > ... > > This bug introduced by commit b261dba2fdb2 ("arm64: kdump: Remove custom > linux,usable-memory-range handling"), which moves > memblock_cap_memory_range() to fdt, but it breaches the rules that > memblock_cap_memory_range() should come after memblock_add() etc as said > in commit e888fa7bb882 ("memblock: Check memory add/cap ordering"). > > As a consequence, the virtual address set up by copy_oldmem_page() does > not bail out from the test of virt_addr_valid() in check_heap_object(), > and finally hits the BUG_ON(). > > Since memblock allocator has no idea about when the memblock is fully > populated, while efi_init() is aware, so tackling this issue by calling t= he > interface early_init_dt_check_for_usable_mem_range() exposed by of/fdt. > > Fixes: b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-ran= ge handling") > Signed-off-by: Pingfan Liu > Cc: Rob Herring > Cc: Zhen Lei > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Andrew Morton > Cc: Mike Rapoport > Cc: Geert Uytterhoeven > Cc: Frank Rowand > Cc: Ard Biesheuvel > Cc: Nick Terrell > Cc: linux-arm-kernel@lists.infradead.org > To: devicetree@vger.kernel.org > To: linux-efi@vger.kernel.org > --- > drivers/firmware/efi/efi-init.c | 7 +++++++ > drivers/of/fdt.c | 2 +- > include/linux/of_fdt.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/efi-init.c b/drivers/firmware/efi/efi-i= nit.c > index b19ce1a83f91..82d986016fa9 100644 > --- a/drivers/firmware/efi/efi-init.c > +++ b/drivers/firmware/efi/efi-init.c > @@ -235,6 +235,13 @@ void __init efi_init(void) > } > > reserve_regions(); > +#ifdef CONFIG_OF_FLATTREE Add a static inline stub to avoid this ifdef. > + /* > + * For memblock manipulation, the cap should come after the membl= ock_add(). > + * And now, memblock is fully populated, it is time to do capping= . > + */ > + early_init_dt_check_for_usable_mem_range(); > +#endif > efi_esrt_init(); > efi_mokvar_table_init(); > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 18a2df431bfd..aa07ef5cab5f 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -972,7 +972,7 @@ static unsigned long chosen_node_offset =3D -FDT_ERR_= NOTFOUND; > * location from flat tree > * @node: reference to node containing usable memory range location ('ch= osen') > */ > -static void __init early_init_dt_check_for_usable_mem_range(void) > +void __init early_init_dt_check_for_usable_mem_range(void) > { > const __be32 *prop; > int len; > diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h > index cf48983d3c86..1d5ee19fadf7 100644 > --- a/include/linux/of_fdt.h > +++ b/include/linux/of_fdt.h > @@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node= , const char *uname, > int depth, void *data); > extern int early_init_dt_scan_memory(unsigned long node, const char *una= me, > int depth, void *data); > +extern void early_init_dt_check_for_usable_mem_range(void); > extern int early_init_dt_scan_chosen_stdout(void); > extern void early_init_fdt_scan_reserved_mem(void); > extern void early_init_fdt_reserve_self(void); > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC023C433F5 for ; Tue, 14 Dec 2021 14:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=toJXtG8DdC1y8w8pXRb37HxKf3AkxZjIaIhivJ4sc2g=; b=PE+c6O4Bsd24d2 u6CoSf0Uon+Hezy0Bz6h2kXRi13sJb3N/Y55kAEJ051E/pmEgbkjbfmBGMn47SlubzovwejY3V1K+ 2oZgNdUefk/sQO1OFDYQz6q18+y60XJQ+n6r9G0aEaP/qeykwlXHrNddUcudzvmx5+sCOu8LyRPPx YD9DxIislBdu0LC7BcERG9VsvDMullU/WdDDJsDFQJuzk7WamcKKPFW0bZgilOpEVGIKVmQtel969 jQDvuKgtRvbXMZWrO1cN9i4E/tQEeODz2I85D8I6ZH2XjkVvUJjckyw7Sm0ecFk8kWfEMrG/U+XC2 PJDvpnOLu0PaQ38w5GGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9DR-00EXFy-6s; Tue, 14 Dec 2021 14:55:41 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9DL-00EXEM-RS for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 14:55:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C08BDB81A25 for ; Tue, 14 Dec 2021 14:55:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BC1EC34601 for ; Tue, 14 Dec 2021 14:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639493732; bh=C2LcvhA1apLsd/J3FjPL4byMqJQOhBWtjSWge+wo0os=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WZdob95b6Y8QdyEvI4JYHGBLLsENxY4e/ZAXWqdL6lLQURj0Pt+4jj8LRdCfrUKXN GuL+PksyAyQ0g5AWJye3bFXIc+af05uSx5oW5LQtTuGEzqAKGy5mcBkVC05XQwh+4i MvHzCRsKp5s8t8csmoD36SIZiTzhErAylsArbK/Qw4UBi+aM/QJkm1HzXvvxSgoE5O Ejk3NSYhlPE+qlT9Fm8/1dTliH8QF3ogx+8tHC35LN6pJttaeLXF2vogcHncmlcdGn P/PTwNK1HmUaiSeXI1LRzQ4LUZaTvXplODgnnzeGvqmzOsQ2czEoaq33KO1yyk9EpQ dOi0tK2rk42tw== Received: by mail-ed1-f45.google.com with SMTP id y13so63545034edd.13 for ; Tue, 14 Dec 2021 06:55:32 -0800 (PST) X-Gm-Message-State: AOAM532UtnaldHPC4QUoFzJiCBf4wRiizzPW8E+BC4oKid4LvrOb8ALN MkGQCK2B/REwfXI/GKFJNmsd2RRwAt9IKKGxpw== X-Google-Smtp-Source: ABdhPJxvID0st4brf7Pqm/fwq+GHY79flSCV18kMw4vXOMU73jEh+BwF4OfwrpHFrz1ypoRgiBnA6VMQSTNocFK6Hw4= X-Received: by 2002:a17:906:7945:: with SMTP id l5mr6347314ejo.82.1639493730755; Tue, 14 Dec 2021 06:55:30 -0800 (PST) MIME-Version: 1.0 References: <20211214040157.27443-1-kernelfans@gmail.com> <20211214040157.27443-3-kernelfans@gmail.com> In-Reply-To: <20211214040157.27443-3-kernelfans@gmail.com> From: Rob Herring Date: Tue, 14 Dec 2021 08:55:18 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/2] efi: apply memblock cap after memblock_add() To: Pingfan Liu Cc: devicetree@vger.kernel.org, linux-efi , Zhen Lei , Catalin Marinas , Will Deacon , Andrew Morton , Mike Rapoport , Geert Uytterhoeven , Frank Rowand , Ard Biesheuvel , Nick Terrell , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_065536_223446_AFAA5504 X-CRM114-Status: GOOD ( 31.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 13, 2021 at 10:02 PM Pingfan Liu wrote: > > On arm64, during kdump kernel saves vmcore, it runs into the following bug: > ... > [ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)! > [ 15.159707] ------------[ cut here ]------------ > [ 15.164311] kernel BUG at mm/usercopy.c:99! > [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP > [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop > [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1 > [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021 > [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 15.228073] pc : usercopy_abort+0x9c/0xa0 > [ 15.232074] lr : usercopy_abort+0x9c/0xa0 > [ 15.236070] sp : ffff8000121abba0 > [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000 > [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000 > [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001 > [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff > [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420 > [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074 > [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c > [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000 > [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000 > [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b > [ 15.310593] Call trace: > [ 15.313027] usercopy_abort+0x9c/0xa0 > [ 15.316677] __check_heap_object+0xd4/0xf0 > [ 15.320762] __check_object_size.part.0+0x160/0x1e0 > [ 15.325628] __check_object_size+0x2c/0x40 > [ 15.329711] copy_oldmem_page+0x7c/0x140 > [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0 > [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350 > [ 15.342920] read_vmcore+0x28/0x34 > [ 15.346309] proc_reg_read+0xb4/0xf0 > [ 15.349871] vfs_read+0xb8/0x1f0 > [ 15.353088] ksys_read+0x74/0x100 > [ 15.356390] __arm64_sys_read+0x28/0x34 > ... > > This bug introduced by commit b261dba2fdb2 ("arm64: kdump: Remove custom > linux,usable-memory-range handling"), which moves > memblock_cap_memory_range() to fdt, but it breaches the rules that > memblock_cap_memory_range() should come after memblock_add() etc as said > in commit e888fa7bb882 ("memblock: Check memory add/cap ordering"). > > As a consequence, the virtual address set up by copy_oldmem_page() does > not bail out from the test of virt_addr_valid() in check_heap_object(), > and finally hits the BUG_ON(). > > Since memblock allocator has no idea about when the memblock is fully > populated, while efi_init() is aware, so tackling this issue by calling the > interface early_init_dt_check_for_usable_mem_range() exposed by of/fdt. > > Fixes: b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling") > Signed-off-by: Pingfan Liu > Cc: Rob Herring > Cc: Zhen Lei > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Andrew Morton > Cc: Mike Rapoport > Cc: Geert Uytterhoeven > Cc: Frank Rowand > Cc: Ard Biesheuvel > Cc: Nick Terrell > Cc: linux-arm-kernel@lists.infradead.org > To: devicetree@vger.kernel.org > To: linux-efi@vger.kernel.org > --- > drivers/firmware/efi/efi-init.c | 7 +++++++ > drivers/of/fdt.c | 2 +- > include/linux/of_fdt.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/efi-init.c b/drivers/firmware/efi/efi-init.c > index b19ce1a83f91..82d986016fa9 100644 > --- a/drivers/firmware/efi/efi-init.c > +++ b/drivers/firmware/efi/efi-init.c > @@ -235,6 +235,13 @@ void __init efi_init(void) > } > > reserve_regions(); > +#ifdef CONFIG_OF_FLATTREE Add a static inline stub to avoid this ifdef. > + /* > + * For memblock manipulation, the cap should come after the memblock_add(). > + * And now, memblock is fully populated, it is time to do capping. > + */ > + early_init_dt_check_for_usable_mem_range(); > +#endif > efi_esrt_init(); > efi_mokvar_table_init(); > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 18a2df431bfd..aa07ef5cab5f 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND; > * location from flat tree > * @node: reference to node containing usable memory range location ('chosen') > */ > -static void __init early_init_dt_check_for_usable_mem_range(void) > +void __init early_init_dt_check_for_usable_mem_range(void) > { > const __be32 *prop; > int len; > diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h > index cf48983d3c86..1d5ee19fadf7 100644 > --- a/include/linux/of_fdt.h > +++ b/include/linux/of_fdt.h > @@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname, > int depth, void *data); > extern int early_init_dt_scan_memory(unsigned long node, const char *uname, > int depth, void *data); > +extern void early_init_dt_check_for_usable_mem_range(void); > extern int early_init_dt_scan_chosen_stdout(void); > extern void early_init_fdt_scan_reserved_mem(void); > extern void early_init_fdt_reserve_self(void); > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel