From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CBDC33CAF for ; Tue, 21 Jan 2020 23:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80FF224653 for ; Tue, 21 Jan 2020 23:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579648117; bh=isyJcTtmLqQY5h7KGj6x7ryAw2JabEkSkewbTWLPkqI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=DbvZCwwXiV31S1GNBJjI4ic8VWs1Yto8FD15wOA13uvKsKMiIkiLbTrKpM6oMPeXv 3aF7iB/lJrjWe5VJK/guTi4XDJqILe0wzHJVM6JiCyT4lFhSZQ5ZE1+29alRkShcXw X0up3NNpUaBk5mAfDvPNgMtPEs2meOE7THkRiwQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgAUXIg (ORCPT ); Tue, 21 Jan 2020 18:08:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:50644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbgAUXIg (ORCPT ); Tue, 21 Jan 2020 18:08:36 -0500 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC09524672; Tue, 21 Jan 2020 23:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579648116; bh=isyJcTtmLqQY5h7KGj6x7ryAw2JabEkSkewbTWLPkqI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TIHRX+PHjjNRSMOtnjbGuGVcseY9vip3xj4afElS8NZWdyJhL0t5iMH1/zbZ4n7Xq SocBH7nxq6j9a3R0gN20ug5W+gbVbmqk3wx9IoWLHCQfN48oxqNMJ1VdT+Flj6DWZ5 Eb5hn8Jyvue6vBUxFJSTGf+jUoOLMsr88O3yJjcI= Received: by mail-qt1-f171.google.com with SMTP id e5so4156349qtm.6; Tue, 21 Jan 2020 15:08:35 -0800 (PST) X-Gm-Message-State: APjAAAVZ7p3hjaGGS7dnN3GffDjY/DhHIkgnaMhBih9Moo040iyQlPuT GMhoC5XEqYP/GXwk7I6njPxv10bLiVK+x2OSNQ== X-Google-Smtp-Source: APXvYqwC/GoCff9pALlwjNcY5bRH4J0nuKhoikFBbQMufVBHG5zsv+j5mLtvw7EZee6cFsjyrV5aX0XhEmMo8ukFmmk= X-Received: by 2002:ac8:59:: with SMTP id i25mr7223067qtg.110.1579648115077; Tue, 21 Jan 2020 15:08:35 -0800 (PST) MIME-Version: 1.0 References: <20200115122908.16954-1-repk@triplefau.lt> <20200115122908.16954-3-repk@triplefau.lt> <20200121230512.GA4486@bogus> In-Reply-To: <20200121230512.GA4486@bogus> From: Rob Herring Date: Tue, 21 Jan 2020 17:08:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/7] dt-bindings: Add AXG shared MIPI/PCIE PHY bindings To: Remi Pommarel Cc: Kishon Vijay Abraham I , Yue Wang , Kevin Hilman , Lorenzo Pieralisi , Bjorn Helgaas , Neil Armstrong , Martin Blumenstingl , Jerome Brunet , "open list:ARM/Amlogic Meson..." , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 5:05 PM Rob Herring wrote: > > On Wed, Jan 15, 2020 at 01:29:03PM +0100, Remi Pommarel wrote: > > Add documentation for the shared MIPI/PCIE PHYs found in AXG SoCs. > > > > Signed-off-by: Remi Pommarel > > --- > > .../phy/amlogic,meson-axg-mipi-pcie.yaml | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > new file mode 100644 > > index 000000000000..3184146318cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright 2019 BayLibre, SAS > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-mipi-pcie.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Amlogic AXG shared MIPI/PCIE PHY > > + > > +maintainers: > > + - Remi Pommarel > > + > > +properties: > > + compatible: > > + const: amlogic,axg-mipi-pcie-phy > > + > > + reg: > > + maxItems: 1 > > + > > + "#phy-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - "#phy-cells" > > Add: > > additionalProperties: false > > > With that, > > Reviewed-by: Rob Herring I missed that I already ack'ed v5, but looks like the same comment applies to both DT patches. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A84C2D0CE for ; Tue, 21 Jan 2020 23:08:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC34A24672 for ; Tue, 21 Jan 2020 23:08:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dF0h34Gf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TIHRX+PH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC34A24672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=636WEFRM2E74jc9AMeKIYlA5H18gkLmJhCCBLprckcQ=; b=dF0h34GfTEgSdB 4hCNC+tS9VyJPyJ0QUEtiwgMzJtfnpdG84J5O8IWUqLTKwA4J+C4sRBrNwR/QCKG5ynw08NHnPpPq vW/CJhif37j68j/5vvEvqUhKlC/ehmAaUu7S72aM5MNqxu2qJ+qtK2OjwWbnvR73nPSp7v1aYmXUH s/wHVe5fdNRu5vh3bBMjJ0MdEQ8FZxoVbdxu4IQTQ9FdzLFFWA/KjZlGJq+y9N9Q9NsOANDP1hdDj jSYRck6LugZjtyrJ1yBDO9sngeDP6eqEz732R0cB+cnscNQoTRQVzxAl7ZcQcvmUYbalRoCgr834L nFLQiUz/VO/5vcth+krw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iu2dT-0003AH-Pz; Tue, 21 Jan 2020 23:08:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iu2dQ-00039a-Rc for linux-amlogic@lists.infradead.org; Tue, 21 Jan 2020 23:08:38 +0000 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA88E2465A for ; Tue, 21 Jan 2020 23:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579648116; bh=isyJcTtmLqQY5h7KGj6x7ryAw2JabEkSkewbTWLPkqI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TIHRX+PHjjNRSMOtnjbGuGVcseY9vip3xj4afElS8NZWdyJhL0t5iMH1/zbZ4n7Xq SocBH7nxq6j9a3R0gN20ug5W+gbVbmqk3wx9IoWLHCQfN48oxqNMJ1VdT+Flj6DWZ5 Eb5hn8Jyvue6vBUxFJSTGf+jUoOLMsr88O3yJjcI= Received: by mail-qt1-f180.google.com with SMTP id v25so4136499qto.7 for ; Tue, 21 Jan 2020 15:08:35 -0800 (PST) X-Gm-Message-State: APjAAAURbAbhOzliCGV0hH4pJJjbp3mZT/fBOEI4NbTsdAYWQQLlK/cN juznERZn7oQXrZrCJpp2v0N2vGLKL76ggstc/A== X-Google-Smtp-Source: APXvYqwC/GoCff9pALlwjNcY5bRH4J0nuKhoikFBbQMufVBHG5zsv+j5mLtvw7EZee6cFsjyrV5aX0XhEmMo8ukFmmk= X-Received: by 2002:ac8:59:: with SMTP id i25mr7223067qtg.110.1579648115077; Tue, 21 Jan 2020 15:08:35 -0800 (PST) MIME-Version: 1.0 References: <20200115122908.16954-1-repk@triplefau.lt> <20200115122908.16954-3-repk@triplefau.lt> <20200121230512.GA4486@bogus> In-Reply-To: <20200121230512.GA4486@bogus> From: Rob Herring Date: Tue, 21 Jan 2020 17:08:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/7] dt-bindings: Add AXG shared MIPI/PCIE PHY bindings To: Remi Pommarel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_150836_917591_0CA0D8E5 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , "linux-kernel@vger.kernel.org" , Yue Wang , Bjorn Helgaas , "open list:ARM/Amlogic Meson..." , Kishon Vijay Abraham I , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Jan 21, 2020 at 5:05 PM Rob Herring wrote: > > On Wed, Jan 15, 2020 at 01:29:03PM +0100, Remi Pommarel wrote: > > Add documentation for the shared MIPI/PCIE PHYs found in AXG SoCs. > > > > Signed-off-by: Remi Pommarel > > --- > > .../phy/amlogic,meson-axg-mipi-pcie.yaml | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > new file mode 100644 > > index 000000000000..3184146318cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright 2019 BayLibre, SAS > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-mipi-pcie.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Amlogic AXG shared MIPI/PCIE PHY > > + > > +maintainers: > > + - Remi Pommarel > > + > > +properties: > > + compatible: > > + const: amlogic,axg-mipi-pcie-phy > > + > > + reg: > > + maxItems: 1 > > + > > + "#phy-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - "#phy-cells" > > Add: > > additionalProperties: false > > > With that, > > Reviewed-by: Rob Herring I missed that I already ack'ed v5, but looks like the same comment applies to both DT patches. Rob _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic