From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 Date: Tue, 30 Oct 2018 14:22:48 -0500 References: <3bbfd02a59c0a9865cf63ac454408c87cd9c7427.1540921794.git.ren_guo@c-sky.com> In-Reply-To: Message-ID: Subject: Re: [PATCH V3 2/2] csky: use common dtb build rules From: Rob Herring Content-Type: text/plain; charset="UTF-8" To: Guo Ren Cc: Arnd Bergmann , "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org List-ID: On Tue, Oct 30, 2018 at 2:10 PM Rob Herring wrote: > > On Tue, Oct 30, 2018 at 12:50 PM Guo Ren wrote: > > > > Remove the Kbuild rules in arch/csky and use common dtb build rules. > > > > This modification is based on: > > > > commit 37c8a5fafa3b ("kbuild: consolidate Devicetree dtb build rules") > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > Cc: Arnd Bergmann > > --- > > arch/csky/Makefile | 11 +---------- > > arch/csky/boot/dts/Makefile | 3 --- > > 2 files changed, 1 insertion(+), 13 deletions(-) > > Reviewed-by: Rob Herring BTW, it's not very not clear what the change from v2 was. In the future, please include a change log in each patch. Also, Arnd acked v2, so you should add those when posting a new version unless there's major changes, but don't post new versions just to add the acks/reviewed-bys. It doesn't really matter in this case as you are the maintainer and have to collect them, but generally the maintainers only collect acks on the version they apply and don't go looking at prior versions. Rob