All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Collabora Kernel ML <kernel@collabora.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Simon Glass <sjg@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	devicetree@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2 3/3] mfd: google,cros-ec: add missing properties
Date: Fri, 9 Oct 2020 08:34:21 -0500	[thread overview]
Message-ID: <CAL_JsqKGSiHEon=R1vPPWvYVmzW2Ju-RrrVL05EW9OqRCHRSMw@mail.gmail.com> (raw)
In-Reply-To: <20201009054819.di4dlfljadsfs6cw@rcn-XPS-13-9360>

On Fri, Oct 9, 2020 at 12:48 AM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
>
> Hi Rob,
>
> Thanks for taking the time to review this. Find my answers below:
>
> On jue 08-10-2020 13:38:18, Rob Herring wrote:
> > > +  codecs:
> >
> > Doesn't moving this require a driver change?
>
> I studied the driver as thoroughly as I could (what
> sound/soc/codecs/cros_ec_codec.c:cros_ec_codec_platform_probe does) and
> I think the driver should still be able to handle this. Unfortunately, I
> can't test it. Can any of the driver maintainers share their
> input about this? I'm adding Cheng-Yi Chiang to cc as well.

The question is not what cros_ec_codec_platform_probe does, but how
the platform device is created by the mfd driver. I think that's just
a call to of_platform_populate which will only create immediate child
devices unless there's a simple-bus or simple-mfd compatible. So I
guess you could also add 'simple-mfd' rather than a driver change.
However, there could be some expectation in the codec driver that the
immediate parent is the EC node.

> > If you only need 1 codec, then just drop the unit-address.
>
> Thank you. Yes, as far as I can tell there's only this codec (so far).

I would probably go this route. You could add this level if there's
ever more than one codec. However, I'm still not clear what the
address represents for the codec. Is it needed? The address
space/format is defined by the parent node. So is this defined by the
EC? If so, other components don't have an address?

Rob

  reply	other threads:[~2020-10-09 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 10:28 [PATCH v2 0/3] Fix checker warnings related to cros-ec binding Ricardo Cañuelo
2020-10-08 10:28 ` [PATCH v2 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema Ricardo Cañuelo
2020-10-11 11:17   ` Enric Balletbo i Serra
2020-10-08 10:28 ` [PATCH v2 2/3] dt-bindings: input: convert cros-ec-keyb " Ricardo Cañuelo
2020-10-08 18:32   ` Rob Herring
2020-10-09  5:28     ` Ricardo Cañuelo
2020-10-09 13:23       ` Rob Herring
2020-10-08 10:28 ` [PATCH v2 3/3] mfd: google,cros-ec: add missing properties Ricardo Cañuelo
2020-10-08 18:38   ` Rob Herring
2020-10-09  5:48     ` Ricardo Cañuelo
2020-10-09 13:34       ` Rob Herring [this message]
2020-10-13  6:46         ` Ricardo Cañuelo
2020-10-14  2:18           ` Tzung-Bi Shih
2020-10-15  6:52             ` Ricardo Cañuelo
2020-10-15  8:25               ` Enric Balletbo i Serra
2020-10-15  9:50                 ` Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqKGSiHEon=R1vPPWvYVmzW2Ju-RrrVL05EW9OqRCHRSMw@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=bleung@chromium.org \
    --cc=cychiang@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=kernel@collabora.com \
    --cc=ricardo.canuelo@collabora.com \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.