From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08999C433E6 for ; Mon, 15 Mar 2021 19:44:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C075764F4A for ; Mon, 15 Mar 2021 19:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233190AbhCOTo0 (ORCPT ); Mon, 15 Mar 2021 15:44:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:42326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhCOToQ (ORCPT ); Mon, 15 Mar 2021 15:44:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7AD164E4D; Mon, 15 Mar 2021 19:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615837456; bh=UAce/rGcdj2/yYhiWLiUo6Z/rclaCY8iTSRrttyY9Js=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iYuhGzFo37VYinzSH3h0VG2lzkaXa0JQ8P/+RyjgWBcasBEtjqWxDWUSsvub9WW1M xtwVlMTGuK4FsRr7mQ97N06nx+w0Q0kypFCxv6xCDu1byA9l6bW8mqg5Psq6DCMUoq muGhumLARaJbJDjjxN0+remrzFlpZpY1YJAaqGE+i/8f9UxOifl+GskcTx6oabN+fB w9PcbzYZkIZNi/o2JVjMxkpN1gHLzPKV+wUrWD2Afj+62aDbKjG3L4FvhcyqalFtFp HFMoc+FfxnD+aU/Xe0J81LVZT6Fxt0n7SwOMwuD9I4Us5YBFlbnBcSxb5xehrS96Fj 05XYigcur4+UQ== Received: by mail-ej1-f50.google.com with SMTP id lr13so68362512ejb.8; Mon, 15 Mar 2021 12:44:15 -0700 (PDT) X-Gm-Message-State: AOAM531NaMSCLuHAB1gpppuBv4XOIDNJUdkifQm5W+yoAxeTuJiFCPdP Z7C8GfIQplCeozpSGKBzI/eewLOl1TpfXJdDKQ== X-Google-Smtp-Source: ABdhPJwOS7Jdo9j/ce2nXz+gkKLZmvlJsRCR0zozStd99u3lWkjUNzfzn0f2xRfxZhJydPmR4YU5q2fU4n/Qp6eBQJQ= X-Received: by 2002:a17:906:c405:: with SMTP id u5mr25581082ejz.341.1615837454425; Mon, 15 Mar 2021 12:44:14 -0700 (PDT) MIME-Version: 1.0 References: <20210312154357.1561730-1-sebastian.reichel@collabora.com> In-Reply-To: <20210312154357.1561730-1-sebastian.reichel@collabora.com> From: Rob Herring Date: Mon, 15 Mar 2021 13:44:02 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/38] Convert power-supply DT bindings to YAML To: Sebastian Reichel Cc: Sebastian Reichel , "open list:THERMAL" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Collabora Kernel ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel wrote: > > Hi, > > I keep getting patches for existing drivers, that modify DT behaviour > without updating the binding file. Let's move everything to DT schema > files, so that this can easily be cached automatically by dtbs_check. > > After this series only three bindings are left unconverted: > > 1. max8925_battery.txt > This describes a node below the PMIC, which does not have its own > compatible value. It needs to be described in the PMIC binding > file, which has not yet been converted. > > 2. stericsson,ab8500-battery.txt > This also describes a node below the PMIC, which does not have > its own compatible value. The same applies. > > 3. charger-manager.txt > This is far more complex to convert than the other files, due > to the 'cm-regulator-name' / "<>-supply" thing. I skipped it > for now. > > I tested the series using dt-validate 2021.3.dev6+g38efe3f and nothing > is reported when running dtbs_check like this: > > make -s -j42 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/power/supply/*.yaml" > > Also nothing is reported when checking the power-supply binding files > like this: > > for file in Documentation/devicetree/bindings/power/supply/*yaml ; do > make -s -j42 dt_binding_check DT_SCHEMA_FILES=$file ; > done > > This is also available as 'psy-yaml-binding' branch from my repository: > > https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git > > Thanks for reviewing it, Thanks for doing this. Other than the couple of things I pointed out, looks good overall. Rob