From: Rob Herring <robh+dt@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-spi <linux-spi@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: spi: Add YAML DT binding document for trivial devices
Date: Thu, 7 Apr 2022 15:35:42 -0500 [thread overview]
Message-ID: <CAL_JsqKRMrCdz4L6c2CyR1y+Wj7LG0NB4r9dm72gktmV08whyg@mail.gmail.com> (raw)
In-Reply-To: <20220407194936.223041-1-marex@denx.de>
On Thu, Apr 7, 2022 at 2:49 PM Marek Vasut <marex@denx.de> wrote:
>
'dt-bindings' pretty much implies or says 'YAML DT binding document'
already. Given limited subject line, don't repeat yourself.
> Document trivial SPI devices in single YAML DT binding document.
> Currently this overlaps Linux kernel spidev.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-spi@vger.kernel.org
> ---
> .../devicetree/bindings/spi/trivial.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/trivial.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/trivial.yaml b/Documentation/devicetree/bindings/spi/trivial.yaml
> new file mode 100644
> index 0000000000000..6d6e682948dfc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/trivial.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/trivial.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Trivial SPI device DT bindings
> +
Add 'description' and describe what devices do and don't qualify as
trivial. (And you can't say 'spidev' :)).
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> + - Mark Brown <broonie@kernel.org>
> +
> +properties:
> + compatible:
> + enum:
> + - cisco,spi-petra
> + - dh,dhcom-board
> + - lineartechnology,ltc2488
> + - lwn,bk4
This one is a *board*!. Wait, and a device... I suppose that's
possible if the board can be a device in another system. Except both
are used in the same dts file. That should create some nice warnings,
but I'm not sure anyone is paying attention to fsl.yaml warnings.
In any case, we're left with
Documentation/devicetree/bindings/misc/lwn-bk4.txt. That and any other
cases need to be deleted.
> + - menlo,m53cpld
> + - micron,spi-authenta
> + - rohm,dh2228fv
This is a DAC. We have lots of DACs in trivial-devices.yaml already.
How does one decide where to document?
> + - semtech,sx1301
> +
> + reg:
> + description: Chip select
> + maxItems: 1
> +
> + spi-max-frequency: true
> + spi-cs-high: true
Reference spi-peripheral-props.yaml and drop these. Will also need to
use unevaluatedProperties.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + spidev@0 {
dac@0
> + compatible = "rohm,dh2228fv";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + };
> + };
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-07 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 19:49 [PATCH] dt-bindings: spi: Add YAML DT binding document for trivial devices Marek Vasut
2022-04-07 20:35 ` Rob Herring [this message]
2022-04-07 21:03 ` Marek Vasut
2022-04-08 0:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKRMrCdz4L6c2CyR1y+Wj7LG0NB4r9dm72gktmV08whyg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.