From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbcGYP07 (ORCPT ); Mon, 25 Jul 2016 11:26:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:52790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbcGYP0y (ORCPT ); Mon, 25 Jul 2016 11:26:54 -0400 MIME-Version: 1.0 In-Reply-To: <1469454609-62256-1-git-send-email-lpc.li@hisilicon.com> References: <1469454609-62256-1-git-send-email-lpc.li@hisilicon.com> From: Rob Herring Date: Mon, 25 Jul 2016 10:26:29 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [PATCH v3] phy: add phy hisi inno usb2 To: Pengcheng Li Cc: Kishon Vijay Abraham I , Mark Rutland , "linux-kernel@vger.kernel.org" , xuejiancheng@hisilicon.com, Dongpo Li , zhangzhenxing@hisilicon.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 8:50 AM, Pengcheng Li wrote: > Add support for inno usb2 phy integrated on some hisilicon SOCs. Bindings need to be sent to DT list. > > Signed-off-by: Pengcheng Li > --- > change log: > v3: > 1. inno phy do not use phy framework, remove it. > --- > .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 48 ++++ > drivers/phy/Kconfig | 10 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-hisi-inno-usb2.c | 290 +++++++++++++++++++++ > 4 files changed, 349 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > create mode 100644 drivers/phy/phy-hisi-inno-usb2.c > > diff --git a/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > new file mode 100644 > index 0000000..59eaf73 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > @@ -0,0 +1,48 @@ > +HiSilicon INNO USB2 PHY > +----------------------- > +Required properties: > +- compatible: Should be "hisilicon,inno_usb2_phy" Use '-', not '_'. > +- #phy-cells: Must be 0 > +- hisilicon,peripheral-syscon: Phandle of syscon used to control phy. > +- hisilicon,reg-num: Number of phy registers which should be configured > +at phy intialization stage > +- hisilicon,reg-seq: Sequence of triplets of (address, value, delay-us). > +The number of triplets is equal to "hisilicon,reg-num". Each triplet is > +used to write one phy register. The delay-us cell represents the delay > +time in microseconds to be applied after each write. Don't create a scripting language in DT. The programming needed should be defined by the compatible string and possibly some specific properties of things that vary board to board. Rob