All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	linux-pci@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Jon Mason <jonmason@broadcom.com>
Subject: Re: [PATCH 7/9] PCI: improve host drivers compile test coverage
Date: Fri, 16 Mar 2018 14:53:16 -0500	[thread overview]
Message-ID: <CAL_JsqKemmq8nucjVavhdSahx5NaGupzSt4cNkqvsCpSGMNHWw@mail.gmail.com> (raw)
In-Reply-To: <368a94dc-72d3-9365-447b-07e9e811ade3@broadcom.com>

On Wed, Mar 7, 2018 at 11:57 AM, Scott Branden
<scott.branden@broadcom.com> wrote:
> Hi Rob,
>
> Change to PCIE_IPROC_BCMA to be made.
>
>
> On 18-03-07 07:42 AM, Rob Herring wrote:
>>
>> Add COMPILE_TEST on driver config options with it. Some ARM drivers
>> still have arch dependencies, so we have to keep those dependent on ARM.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>>   drivers/pci/dwc/Kconfig  | 24 ++++++++++++------------
>>   drivers/pci/host/Kconfig | 33 +++++++++++++++------------------
>>   2 files changed, 27 insertions(+), 30 deletions(-)

[...]

>> @@ -127,7 +126,7 @@ config PCIE_IPROC_PLATFORM
>>     config PCIE_IPROC_BCMA
>>         tristate "Broadcom iProc PCIe BCMA bus driver"
>> -       depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
>> +       depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>>         select PCIE_IPROC
>>         select BCMA
>>         default ARCH_BCM_5301X
>
> The was intentionally depending on ARM (as it does not apply to ARM64 which
> ARCH_BCM__IPROC also applies to).  Please keep that in place.
> depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST

Indeed.

Lorenzo, can you fix up or want me to send a new version?

Rob

  reply	other threads:[~2018-03-16 20:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 15:42 [PATCH 0/9] PCI DT header refactoring and compile test improvements Rob Herring
2018-03-07 15:42 ` [PATCH 1/9] PCI: kirin: remove unnecessary asm/compiler.h include Rob Herring
2018-03-07 15:42 ` [PATCH 2/9] PCI: iproc: remove dependency on ARM specific struct pci_sys_data Rob Herring
2018-03-07 17:58   ` Scott Branden
2018-03-07 15:42 ` [PATCH 3/9] PCI: kirin: fix missing dependency on PCI_MSI_IRQ_DOMAIN Rob Herring
2018-03-07 15:42 ` [PATCH 4/9] PCI: kirin_pcie_driver can be static Rob Herring
2018-03-08 17:51   ` Lorenzo Pieralisi
2018-03-07 15:42 ` [PATCH 5/9] PCI: rcar: fix semicolon.cocci warnings Rob Herring
2018-03-07 15:42 ` [PATCH 6/9] PCI: v3-semi: " Rob Herring
2018-03-07 15:42 ` [PATCH 7/9] PCI: improve host drivers compile test coverage Rob Herring
2018-03-07 17:57   ` Scott Branden
2018-03-16 19:53     ` Rob Herring [this message]
2018-03-19 18:05       ` Lorenzo Pieralisi
2018-03-19 18:11         ` Scott Branden
2018-03-07 15:42 ` [PATCH 8/9] PCI: dw: move CONFIG_PCI depends to menu Rob Herring
2018-03-07 15:42 ` [PATCH 9/9] PCI: move private DT related functions into private header Rob Herring
2018-03-20 18:18 ` [PATCH 0/9] PCI DT header refactoring and compile test improvements Lorenzo Pieralisi
2018-03-20 18:34   ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqKemmq8nucjVavhdSahx5NaGupzSt4cNkqvsCpSGMNHWw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=jonmason@broadcom.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.