From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Herring <robh@kernel.org>
Date: Fri, 30 Jan 2015 08:20:16 -0600
Subject: [U-Boot] [PATCH 1/2] fastboot: add "fastboot oem" command
	support
In-Reply-To: <20150129093027.1aba1a15@amdc2363>
References: <1422308941-23543-1-git-send-email-robh@kernel.org>
 <1422308941-23543-2-git-send-email-robh@kernel.org>
 <20150129093027.1aba1a15@amdc2363>
Message-ID: <CAL_JsqKfebG=KYKBmRy6ags-OVvt52bdf+3yN0yAzStDQ+u93A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, Jan 29, 2015 at 2:30 AM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Rob,
>
>> From: Michael Scott <michael.scott@linaro.org>
>>
>> Add code stub to handle "fastboot oem __" command. As unlock is a
>> common fastboot command, distinguish that it is not implemented.
>>
>> Signed-off-by: Michael Scott <michael.scott@linaro.org>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>>  drivers/usb/gadget/f_fastboot.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/f_fastboot.c
>> b/drivers/usb/gadget/f_fastboot.c index 310175a..e2fda86 100644
>> --- a/drivers/usb/gadget/f_fastboot.c
>> +++ b/drivers/usb/gadget/f_fastboot.c
>> @@ -513,6 +513,17 @@ static void cb_flash(struct usb_ep *ep, struct
>> usb_request *req) }
>>  #endif
>>
>> +static void cb_oem(struct usb_ep *ep, struct usb_request *req)
>> +{
>> +     char *cmd = req->buf;
>> +     if (strncmp("unlock", cmd + 4, 8) == 0) {
>> +             fastboot_tx_write_str("FAILnot implemented");
>> +     }
>> +     else {
>> +             fastboot_tx_write_str("FAILunknown oem command");
>> +     }
>
> Just a minor comment - those braces could be removed.

When the format command is added in the next patch, then they need to
be added back if you want all clauses to be the same (braces or not).

Rob

> BTW: Marek shall I take those patches to dfu tree or would you take
> them to -usb tree ?
>
>> +}
>> +
>>  struct cmd_dispatch_info {
>>       char *cmd;
>>       void (*cb)(struct usb_ep *ep, struct usb_request *req);
>> @@ -541,6 +552,10 @@ static const struct cmd_dispatch_info
>> cmd_dispatch_info[] = { .cb = cb_flash,
>>       },
>>  #endif
>> +     {
>> +             .cmd = "oem",
>> +             .cb = cb_oem,
>> +     },
>>  };
>>
>>  static void rx_handler_command(struct usb_ep *ep, struct usb_request
>> *req)
>
>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group