From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36940C4332F for ; Fri, 18 Nov 2022 21:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbiKRVkV (ORCPT ); Fri, 18 Nov 2022 16:40:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbiKRVkH (ORCPT ); Fri, 18 Nov 2022 16:40:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189685E9FE; Fri, 18 Nov 2022 13:40:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7DF5625DC; Fri, 18 Nov 2022 21:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15EDCC43140; Fri, 18 Nov 2022 21:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668807603; bh=YKUHTSPq5IDGNDGLjf/sjbiqE0AZozBsTwTI13qMcZU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDveWRKNOZyZVU+/76UW6M5Q/08kv/yJiaBcxH6kTaAvK0EC/0oB/lPwlzQXRfmt6 Zm/6M8sSh3ksyjPfsLmQgNXmslxy66uL5hS1qxIj6follviijaqOxF2Ylk8xrW33Tq tROHgNpz9156QXsea3C6WmNgnCpvTK33f5e0Kl8qKFQujqsYAELF2CIoRERiHLZSQS RWX1QktikpkEd0k51tItGSYnnudBdJPC0ZiXCrXF9/tj55S2jo8fCS6mpcV6k2X5mq 2BxJRJFcUCadrZkCMXM/Y8JSeEMHRoKa07VJ9fAMRabmA+AXFrZYTMVzJX+sgyxq1O erfDoFG1bweNQ== Received: by mail-lf1-f42.google.com with SMTP id a29so10243073lfj.9; Fri, 18 Nov 2022 13:40:02 -0800 (PST) X-Gm-Message-State: ANoB5pm9vecbdu77tVVB6cesyfMA80EX0F1B3J1ariFKWxfLoDbWQB6m qmHvwP+KNdTOQAdgNCzWeeS7nL0el4YY0cx/zw== X-Google-Smtp-Source: AA0mqf4W7viCQPe0UTFofFT1SvVUt8YX11fzG82T1MZfAN+7A17E35zovc3VtyGLwVD/L6iRCqAuOeEDvppeVb0p8zA= X-Received: by 2002:a05:6512:b97:b0:4a4:6ee3:f57b with SMTP id b23-20020a0565120b9700b004a46ee3f57bmr2843395lfv.17.1668807600996; Fri, 18 Nov 2022 13:40:00 -0800 (PST) MIME-Version: 1.0 References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> In-Reply-To: <20221118190126.100895-12-linux@fw-web.de> From: Rob Herring Date: Fri, 18 Nov 2022 15:39:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays To: Frank Wunderlich Cc: linux-mediatek@lists.infradead.org, Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: > > From: Frank Wunderlich > > Add devicetree overlays for using nand and nor on BPI-R3. Can you not tell at runtime which one you booted from? If not, how does one choose which overlay to apply? If you can, why not populate both nodes and enable the right one? IMO, if all h/w is present, it should all be in the DT. Selecting what h/w to use is a separate problem and overlays aren't a great solution for that. > Signed-off-by: Frank Wunderlich > --- > maybe rename to dtso? > > "kbuild: Allow DTB overlays to built from .dtso named source files" > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > more comments about the dt overlay-support: > > https://patchwork.kernel.org/comment/25092116/ > https://patchwork.kernel.org/comment/25085681/ > --- > v4: > - drop compile-comment from overlays > - add author-information to dt-overlays > --- > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 55 +++++++++++++++ > .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 69 +++++++++++++++++++ > 3 files changed, 126 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index e8902f2cc58f..d42208c4090d 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo These need rules to apply them to the base dtb(s). You just need: full.dtb := base.dtb overlay.dtb dtb-y += full.dtb Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7256CC43217 for ; Fri, 18 Nov 2022 21:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z+xwnrsoUobmreQpAn1cmLZ/77U1MlbEyuwhh2UKlVo=; b=WdSn0VFaURxsfDlmVV0IO165J0 eu0sQiWQcOiX7jaPIZfscUT1Z6WTfqovRtoX99Wp75toWkCcuidAeO/u0J0Ws+YjDb1CrR/wL0E9b A0eVdWuFlDVHLm1C8s+mAxemwQh/2dxneEbVLl0pTTs6FTUamTmCR8qUpKASVsG8sxDOvNNV/mHlx enUsAVdPpcp3JHspAnFtqWnX4l7EF2hbiCpusrteteuDd4fF6V/CbfS3LLXKQzDeAIcSbQZW8O3eT c66+/FnADfGOhH9vxGZ2OvIaXkkvFZeWJ8JPMtw72V0YGdTR7zqusRvqMne3+fVuJhk05UHvgVAEF 8bKhSpWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95w-008GVk-Qy; Fri, 18 Nov 2022 21:40:20 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95i-008GPe-FF; Fri, 18 Nov 2022 21:40:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BA2DDCE2285; Fri, 18 Nov 2022 21:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04117C433D7; Fri, 18 Nov 2022 21:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668807603; bh=YKUHTSPq5IDGNDGLjf/sjbiqE0AZozBsTwTI13qMcZU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDveWRKNOZyZVU+/76UW6M5Q/08kv/yJiaBcxH6kTaAvK0EC/0oB/lPwlzQXRfmt6 Zm/6M8sSh3ksyjPfsLmQgNXmslxy66uL5hS1qxIj6follviijaqOxF2Ylk8xrW33Tq tROHgNpz9156QXsea3C6WmNgnCpvTK33f5e0Kl8qKFQujqsYAELF2CIoRERiHLZSQS RWX1QktikpkEd0k51tItGSYnnudBdJPC0ZiXCrXF9/tj55S2jo8fCS6mpcV6k2X5mq 2BxJRJFcUCadrZkCMXM/Y8JSeEMHRoKa07VJ9fAMRabmA+AXFrZYTMVzJX+sgyxq1O erfDoFG1bweNQ== Received: by mail-lf1-f54.google.com with SMTP id d6so10277989lfs.10; Fri, 18 Nov 2022 13:40:02 -0800 (PST) X-Gm-Message-State: ANoB5pnLbasRjOwdtlIR849AC7+M2c552AtEJMuWAxTp0D1tYUJ7nqqx yJq3+15J7saEFncPSOOhwqcDKRd6ulumWt29sQ== X-Google-Smtp-Source: AA0mqf4W7viCQPe0UTFofFT1SvVUt8YX11fzG82T1MZfAN+7A17E35zovc3VtyGLwVD/L6iRCqAuOeEDvppeVb0p8zA= X-Received: by 2002:a05:6512:b97:b0:4a4:6ee3:f57b with SMTP id b23-20020a0565120b9700b004a46ee3f57bmr2843395lfv.17.1668807600996; Fri, 18 Nov 2022 13:40:00 -0800 (PST) MIME-Version: 1.0 References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> In-Reply-To: <20221118190126.100895-12-linux@fw-web.de> From: Rob Herring Date: Fri, 18 Nov 2022 15:39:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays To: Frank Wunderlich Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_134006_910784_3B0AAE2A X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ryder Lee , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Kishon Vijay Abraham I , Jianjun Wang , Chunfeng Yun , Vinod Koul , Bo Jiao , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , linux-pci@vger.kernel.org, Bjorn Helgaas , Paolo Abeni , Lorenzo Bianconi , linux-arm-kernel@lists.infradead.org, Matthias Brugger Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: > > From: Frank Wunderlich > > Add devicetree overlays for using nand and nor on BPI-R3. Can you not tell at runtime which one you booted from? If not, how does one choose which overlay to apply? If you can, why not populate both nodes and enable the right one? IMO, if all h/w is present, it should all be in the DT. Selecting what h/w to use is a separate problem and overlays aren't a great solution for that. > Signed-off-by: Frank Wunderlich > --- > maybe rename to dtso? > > "kbuild: Allow DTB overlays to built from .dtso named source files" > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > more comments about the dt overlay-support: > > https://patchwork.kernel.org/comment/25092116/ > https://patchwork.kernel.org/comment/25085681/ > --- > v4: > - drop compile-comment from overlays > - add author-information to dt-overlays > --- > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 55 +++++++++++++++ > .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 69 +++++++++++++++++++ > 3 files changed, 126 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index e8902f2cc58f..d42208c4090d 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo These need rules to apply them to the base dtb(s). You just need: full.dtb := base.dtb overlay.dtb dtb-y += full.dtb Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 213CEC4332F for ; Fri, 18 Nov 2022 21:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QKSxRkGE125wvUIobmp0mHvqqY0Y2xU4KSdSj8LAsGk=; b=uuD03eMqbE3lDA T7mxuRsbqlkuAowsJCfWN5xeWz+/exh62GYjLVH6i4pcNgpvGC8BEAYrlx8lFFxa42kqFVWYRF7Z2 f0fPb7cCKNlQmvv7VbUe/dNEzVLOygwTXkovJ0fXSpb4KJ8r+jQxKXGAlgHaBkYjH58SZHfinrHEk pYOl0GzAKU1iFFHd4MuMdP1DjQN3NccmSJkhdR+aS0jf9DqN2h/tCC/KVms65iUjhcfkSXEPgTn2C 8hbvT5xlRI9A9H2/hXJFyZ3jBgl5ZjeU3LVxUgHS9O5tnKbFr4ckPCXs5XlisA7mHdK8WUhSn9oLh CD5PgVeb76jrOY49g/Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95x-008GW6-Hl; Fri, 18 Nov 2022 21:40:21 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95i-008GPe-FF; Fri, 18 Nov 2022 21:40:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BA2DDCE2285; Fri, 18 Nov 2022 21:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04117C433D7; Fri, 18 Nov 2022 21:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668807603; bh=YKUHTSPq5IDGNDGLjf/sjbiqE0AZozBsTwTI13qMcZU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDveWRKNOZyZVU+/76UW6M5Q/08kv/yJiaBcxH6kTaAvK0EC/0oB/lPwlzQXRfmt6 Zm/6M8sSh3ksyjPfsLmQgNXmslxy66uL5hS1qxIj6follviijaqOxF2Ylk8xrW33Tq tROHgNpz9156QXsea3C6WmNgnCpvTK33f5e0Kl8qKFQujqsYAELF2CIoRERiHLZSQS RWX1QktikpkEd0k51tItGSYnnudBdJPC0ZiXCrXF9/tj55S2jo8fCS6mpcV6k2X5mq 2BxJRJFcUCadrZkCMXM/Y8JSeEMHRoKa07VJ9fAMRabmA+AXFrZYTMVzJX+sgyxq1O erfDoFG1bweNQ== Received: by mail-lf1-f54.google.com with SMTP id d6so10277989lfs.10; Fri, 18 Nov 2022 13:40:02 -0800 (PST) X-Gm-Message-State: ANoB5pnLbasRjOwdtlIR849AC7+M2c552AtEJMuWAxTp0D1tYUJ7nqqx yJq3+15J7saEFncPSOOhwqcDKRd6ulumWt29sQ== X-Google-Smtp-Source: AA0mqf4W7viCQPe0UTFofFT1SvVUt8YX11fzG82T1MZfAN+7A17E35zovc3VtyGLwVD/L6iRCqAuOeEDvppeVb0p8zA= X-Received: by 2002:a05:6512:b97:b0:4a4:6ee3:f57b with SMTP id b23-20020a0565120b9700b004a46ee3f57bmr2843395lfv.17.1668807600996; Fri, 18 Nov 2022 13:40:00 -0800 (PST) MIME-Version: 1.0 References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> In-Reply-To: <20221118190126.100895-12-linux@fw-web.de> From: Rob Herring Date: Fri, 18 Nov 2022 15:39:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays To: Frank Wunderlich Cc: linux-mediatek@lists.infradead.org, Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_134006_910784_3B0AAE2A X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: > > From: Frank Wunderlich > > Add devicetree overlays for using nand and nor on BPI-R3. Can you not tell at runtime which one you booted from? If not, how does one choose which overlay to apply? If you can, why not populate both nodes and enable the right one? IMO, if all h/w is present, it should all be in the DT. Selecting what h/w to use is a separate problem and overlays aren't a great solution for that. > Signed-off-by: Frank Wunderlich > --- > maybe rename to dtso? > > "kbuild: Allow DTB overlays to built from .dtso named source files" > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > more comments about the dt overlay-support: > > https://patchwork.kernel.org/comment/25092116/ > https://patchwork.kernel.org/comment/25085681/ > --- > v4: > - drop compile-comment from overlays > - add author-information to dt-overlays > --- > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 55 +++++++++++++++ > .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 69 +++++++++++++++++++ > 3 files changed, 126 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index e8902f2cc58f..d42208c4090d 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo These need rules to apply them to the base dtb(s). You just need: full.dtb := base.dtb overlay.dtb dtb-y += full.dtb Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14036C4332F for ; Fri, 18 Nov 2022 21:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+7tHkxkduFxjE0yl9idWJl6/SJPy7iAVn4zXGvjZLN0=; b=uME6UxruyZmrHu lrS+gYVIht1hpg8/YbMNyW5f5IS7l5raSiyr0c740SEGUWHyaXSSIfcrWxGbMUjevAyD1Z7nIiqm9 JBrBtEOzoctdM6mFWv3OTZRa+2kdqMDHT11o5Dglf5HH0Ht0jI6kb3uAOzT44eoMjcEvFYP1xO0ll dk3KWzvZPCfOi4CUZRMDD935ZMEQLsMte84Kqm5yooEufI4LbxsAqQ1vKXEiJO577y0dJ5tz6BGuB c/ZiNix0iv+/0Z2wy5YQXiwTMGaGWbPkxqKlgaLvYRzkpUVhFEGqMT6JrQo5B8ixZojURGkNghYGT qDxvVuV/EMnN3uyCGS/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95m-008GRl-4V; Fri, 18 Nov 2022 21:40:10 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow95i-008GPe-FF; Fri, 18 Nov 2022 21:40:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BA2DDCE2285; Fri, 18 Nov 2022 21:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04117C433D7; Fri, 18 Nov 2022 21:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668807603; bh=YKUHTSPq5IDGNDGLjf/sjbiqE0AZozBsTwTI13qMcZU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDveWRKNOZyZVU+/76UW6M5Q/08kv/yJiaBcxH6kTaAvK0EC/0oB/lPwlzQXRfmt6 Zm/6M8sSh3ksyjPfsLmQgNXmslxy66uL5hS1qxIj6follviijaqOxF2Ylk8xrW33Tq tROHgNpz9156QXsea3C6WmNgnCpvTK33f5e0Kl8qKFQujqsYAELF2CIoRERiHLZSQS RWX1QktikpkEd0k51tItGSYnnudBdJPC0ZiXCrXF9/tj55S2jo8fCS6mpcV6k2X5mq 2BxJRJFcUCadrZkCMXM/Y8JSeEMHRoKa07VJ9fAMRabmA+AXFrZYTMVzJX+sgyxq1O erfDoFG1bweNQ== Received: by mail-lf1-f54.google.com with SMTP id d6so10277989lfs.10; Fri, 18 Nov 2022 13:40:02 -0800 (PST) X-Gm-Message-State: ANoB5pnLbasRjOwdtlIR849AC7+M2c552AtEJMuWAxTp0D1tYUJ7nqqx yJq3+15J7saEFncPSOOhwqcDKRd6ulumWt29sQ== X-Google-Smtp-Source: AA0mqf4W7viCQPe0UTFofFT1SvVUt8YX11fzG82T1MZfAN+7A17E35zovc3VtyGLwVD/L6iRCqAuOeEDvppeVb0p8zA= X-Received: by 2002:a05:6512:b97:b0:4a4:6ee3:f57b with SMTP id b23-20020a0565120b9700b004a46ee3f57bmr2843395lfv.17.1668807600996; Fri, 18 Nov 2022 13:40:00 -0800 (PST) MIME-Version: 1.0 References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> In-Reply-To: <20221118190126.100895-12-linux@fw-web.de> From: Rob Herring Date: Fri, 18 Nov 2022 15:39:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays To: Frank Wunderlich Cc: linux-mediatek@lists.infradead.org, Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_134006_910784_3B0AAE2A X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: > > From: Frank Wunderlich > > Add devicetree overlays for using nand and nor on BPI-R3. Can you not tell at runtime which one you booted from? If not, how does one choose which overlay to apply? If you can, why not populate both nodes and enable the right one? IMO, if all h/w is present, it should all be in the DT. Selecting what h/w to use is a separate problem and overlays aren't a great solution for that. > Signed-off-by: Frank Wunderlich > --- > maybe rename to dtso? > > "kbuild: Allow DTB overlays to built from .dtso named source files" > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > more comments about the dt overlay-support: > > https://patchwork.kernel.org/comment/25092116/ > https://patchwork.kernel.org/comment/25085681/ > --- > v4: > - drop compile-comment from overlays > - add author-information to dt-overlays > --- > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 55 +++++++++++++++ > .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 69 +++++++++++++++++++ > 3 files changed, 126 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index e8902f2cc58f..d42208c4090d 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo These need rules to apply them to the base dtb(s). You just need: full.dtb := base.dtb overlay.dtb dtb-y += full.dtb Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel