From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B13C43463 for ; Fri, 18 Sep 2020 16:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD99A206A4 for ; Fri, 18 Sep 2020 16:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445286; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QsHh37maS91HZ4soRTVd298tNfjcGtVXbZN4sU8twP3x0R/oRSZ3TgHDXPBYioyyQ j5ABZlnbD4kW+as/STyzdNiE08bACTU7q1Di/GaxEEdiYBMXnYL6YH5pnXcQPWWvHa XRoieSdqnpagtLUiSn76ae3ceVm6M3xA2iVy6Gxo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbgIRQIG (ORCPT ); Fri, 18 Sep 2020 12:08:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:55374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIRQIF (ORCPT ); Fri, 18 Sep 2020 12:08:05 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06D37238E6; Fri, 18 Sep 2020 16:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445284; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=emUrEqNiAaIypaaqR0DFyojY3bKTuLzedv4LJNpN6r92gOZux9m/t+i1gDj1JpGUw XdzfnJhSce31jn8yRunVP1TffGoAH3jyT3yCKqPfFryCodyr5Ku1NvsvKOnpWwHFs+ 9mXeIHyvZEiaP3nGp2V20W14pf9i4HBfMJMoBQV8= Received: by mail-ot1-f51.google.com with SMTP id u25so5877282otq.6; Fri, 18 Sep 2020 09:08:04 -0700 (PDT) X-Gm-Message-State: AOAM533VSNj/ijoXeEHV4diRaslxHgYQJaDG1LQjeSCoSjFU+0cEtVnv oXZfNFot6kvZII9E/Dc75CcNNHuM3pyBL6RUNA== X-Google-Smtp-Source: ABdhPJwgdQQ94kk1CAJVTaLgyAzK5jSLiZzPbGFE5cSpTlp+14Bb87D1OUAiLGeIZ3x+kwKNZ39GOoJ1D5VzhOMWVEw= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21705872otp.107.1600445283255; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com> <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03> In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03> From: Rob Herring Date: Fri, 18 Sep 2020 10:07:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Linux IOMMU , Youlin Pei , Nicolas Boichat , Anan Sun , Chao Hao , Ming-Fan Chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > [...] > > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt2701-m4u #mt2701 generation one HW > > > + - mediatek,mt2712-m4u #mt2712 generation two HW > > > + - mediatek,mt6779-m4u #mt6779 generation two HW > > > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW > > > > This is not right. > > > > items: > > - const: mediatek,mt7623-m4u > > - const: mediatek,mt2701-m4u > > > > And that has to be under a 'oneOf' with the rest of this. > > Thanks for the review. Is this OK? > > compatible: > oneOf: > - const: mediatek,mt2701-m4u # mt2701 generation one HW > - const: mediatek,mt2712-m4u # mt2712 generation two HW > - const: mediatek,mt6779-m4u # mt6779 generation two HW > - const: mediatek,mt8173-m4u # mt8173 generation two HW > - const: mediatek,mt8183-m4u # mt8183 generation two HW > - const: mediatek,mt8192-m4u # mt8192 generation two HW It is correct, but I prefer all these to be a single enum. So 'oneOf' would have 2 entries. > - description: mt7623 generation one HW > items: > - const: mediatek,mt7623-m4u > - const: mediatek,mt2701-m4u > > > > > > + - mediatek,mt8173-m4u #mt8173 generation two HW > > > + - mediatek,mt8183-m4u #mt8183 generation two HW > > > + > > > + reg: > > > + maxItems: 1 > > [snip] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83007C43464 for ; Fri, 18 Sep 2020 16:08:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1990E23888 for ; Fri, 18 Sep 2020 16:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="emUrEqNi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1990E23888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B816A20405; Fri, 18 Sep 2020 16:08:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id acvlJEaRGJQR; Fri, 18 Sep 2020 16:08:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id A382420334; Fri, 18 Sep 2020 16:08:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 927BDC0888; Fri, 18 Sep 2020 16:08:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9CECDC0051 for ; Fri, 18 Sep 2020 16:08:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 49E9820334 for ; Fri, 18 Sep 2020 16:08:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bpW3OX+AfNYW for ; Fri, 18 Sep 2020 16:08:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 8292C1FD16 for ; Fri, 18 Sep 2020 16:08:04 +0000 (UTC) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2D9B2389F for ; Fri, 18 Sep 2020 16:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445284; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=emUrEqNiAaIypaaqR0DFyojY3bKTuLzedv4LJNpN6r92gOZux9m/t+i1gDj1JpGUw XdzfnJhSce31jn8yRunVP1TffGoAH3jyT3yCKqPfFryCodyr5Ku1NvsvKOnpWwHFs+ 9mXeIHyvZEiaP3nGp2V20W14pf9i4HBfMJMoBQV8= Received: by mail-ot1-f45.google.com with SMTP id e23so5850568otk.7 for ; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) X-Gm-Message-State: AOAM533mXtmBtlTG0G3ne0fh7D6nOV5ITuza5uhV2qDGUD6TpYbvOwq2 ++tcrHpFKeRfnAuLBDgE1Q0sRAgc/YP8ZsWPyA== X-Google-Smtp-Source: ABdhPJwgdQQ94kk1CAJVTaLgyAzK5jSLiZzPbGFE5cSpTlp+14Bb87D1OUAiLGeIZ3x+kwKNZ39GOoJ1D5VzhOMWVEw= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21705872otp.107.1600445283255; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com> <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03> In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03> From: Rob Herring Date: Fri, 18 Sep 2020 10:07:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu Cc: Youlin Pei , devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream , Chao Hao , Robin Murphy , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , Linux IOMMU , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Ming-Fan Chen , Anan Sun , Will Deacon , linux-arm-kernel X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > [...] > > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt2701-m4u #mt2701 generation one HW > > > + - mediatek,mt2712-m4u #mt2712 generation two HW > > > + - mediatek,mt6779-m4u #mt6779 generation two HW > > > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW > > > > This is not right. > > > > items: > > - const: mediatek,mt7623-m4u > > - const: mediatek,mt2701-m4u > > > > And that has to be under a 'oneOf' with the rest of this. > > Thanks for the review. Is this OK? > > compatible: > oneOf: > - const: mediatek,mt2701-m4u # mt2701 generation one HW > - const: mediatek,mt2712-m4u # mt2712 generation two HW > - const: mediatek,mt6779-m4u # mt6779 generation two HW > - const: mediatek,mt8173-m4u # mt8173 generation two HW > - const: mediatek,mt8183-m4u # mt8183 generation two HW > - const: mediatek,mt8192-m4u # mt8192 generation two HW It is correct, but I prefer all these to be a single enum. So 'oneOf' would have 2 entries. > - description: mt7623 generation one HW > items: > - const: mediatek,mt7623-m4u > - const: mediatek,mt2701-m4u > > > > > > + - mediatek,mt8173-m4u #mt8173 generation two HW > > > + - mediatek,mt8183-m4u #mt8183 generation two HW > > > + > > > + reg: > > > + maxItems: 1 > > [snip] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60B5C43463 for ; Fri, 18 Sep 2020 16:08:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6590D2388B for ; Fri, 18 Sep 2020 16:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G5H43EaH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="emUrEqNi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6590D2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j9hAPYjylCpR1S2B3GQklVAl1mVhdUKM/JqXLc8Ky2s=; b=G5H43EaHgCoIfsVADVt1v4IOK MdJlU6zoVVTTorDSFyHvS308pJz82aZRnygE9z0uGSmbOr3spMfacR8psrgZF+QTjG39r/yXolhsP SKWFurn+2IC0IYABWooe/a4ypSoIcSyexQ/73YFeZDvl9GzP5YpZJnKRx2IvBOFPh9i6u6mmi54m6 F/XBk+wiwq5Jdg+khvl8Jd4z1yXRz7Fo4SY4OUousyfJ9cnthHN9LtksinKsbAWmpb8NByBqjS7j6 wdDX1pBTTHQto/c/TmX8ohUIkfhWNd3MGzh3ETeknP5RuIVtQbFyetPaCO2oNKtTUQrUgjhiS0l67 u/xz5gyXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIvm-0007GP-0w; Fri, 18 Sep 2020 16:08:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIvd-0007Ca-C1; Fri, 18 Sep 2020 16:08:06 +0000 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED12A2389E; Fri, 18 Sep 2020 16:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445284; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=emUrEqNiAaIypaaqR0DFyojY3bKTuLzedv4LJNpN6r92gOZux9m/t+i1gDj1JpGUw XdzfnJhSce31jn8yRunVP1TffGoAH3jyT3yCKqPfFryCodyr5Ku1NvsvKOnpWwHFs+ 9mXeIHyvZEiaP3nGp2V20W14pf9i4HBfMJMoBQV8= Received: by mail-ot1-f47.google.com with SMTP id m12so5891907otr.0; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) X-Gm-Message-State: AOAM531Jur4Ady7/yV948tBpGCTx9st/WxxahTRABC60EldDWWGHBDtx IyW6KUjHUBhsGHv4dCd8tPM6SMhaqNgE4CnZfA== X-Google-Smtp-Source: ABdhPJwgdQQ94kk1CAJVTaLgyAzK5jSLiZzPbGFE5cSpTlp+14Bb87D1OUAiLGeIZ3x+kwKNZ39GOoJ1D5VzhOMWVEw= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21705872otp.107.1600445283255; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com> <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03> In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03> From: Rob Herring Date: Fri, 18 Sep 2020 10:07:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_120805_529603_C764473C X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Youlin Pei , devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream , Chao Hao , Robin Murphy , Joerg Roedel , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , Linux IOMMU , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Ming-Fan Chen , Anan Sun , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > [...] > > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt2701-m4u #mt2701 generation one HW > > > + - mediatek,mt2712-m4u #mt2712 generation two HW > > > + - mediatek,mt6779-m4u #mt6779 generation two HW > > > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW > > > > This is not right. > > > > items: > > - const: mediatek,mt7623-m4u > > - const: mediatek,mt2701-m4u > > > > And that has to be under a 'oneOf' with the rest of this. > > Thanks for the review. Is this OK? > > compatible: > oneOf: > - const: mediatek,mt2701-m4u # mt2701 generation one HW > - const: mediatek,mt2712-m4u # mt2712 generation two HW > - const: mediatek,mt6779-m4u # mt6779 generation two HW > - const: mediatek,mt8173-m4u # mt8173 generation two HW > - const: mediatek,mt8183-m4u # mt8183 generation two HW > - const: mediatek,mt8192-m4u # mt8192 generation two HW It is correct, but I prefer all these to be a single enum. So 'oneOf' would have 2 entries. > - description: mt7623 generation one HW > items: > - const: mediatek,mt7623-m4u > - const: mediatek,mt2701-m4u > > > > > > + - mediatek,mt8173-m4u #mt8173 generation two HW > > > + - mediatek,mt8183-m4u #mt8183 generation two HW > > > + > > > + reg: > > > + maxItems: 1 > > [snip] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8967C43464 for ; Fri, 18 Sep 2020 16:09:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78D9123787 for ; Fri, 18 Sep 2020 16:09:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="POXb+VrW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="emUrEqNi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78D9123787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WCkkYJSQ9s/RUpftGUBuJArT0rOHrUlw7uxF2FV5cYI=; b=POXb+VrWKmpL0dgjmzpaED4Fw zKn3GtlJeceO0c6ywRutFRfyGmSioC6YdqGn7pCPQ0TldGTUu9iZ/2kS9y2GOdL1xRQdAUE9ZuOA+ F24tv81XS9oq3sV+rZmGqaV7T/rMPnyCz78DvwktCjAMs+7Y3C14Vat1oEluJ/3PjUXVLvoBDil7F tG96IM7FTV0aTary3vtxv1lr9ZcUuBlnySN2kP5ZITORJROVcrImdJkPtGRJNdja3qVgztRWBrqgy fIXsLIHaYM+NSmQnig8tdzqKVr2/ymZ1PkLEwfhhyFAYrgYJ0IZFSbuY6NdNih4GiBlohAPKSkgQY A+xPRq6oA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIvg-0007Du-0B; Fri, 18 Sep 2020 16:08:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIvd-0007Ca-C1; Fri, 18 Sep 2020 16:08:06 +0000 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED12A2389E; Fri, 18 Sep 2020 16:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445284; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=emUrEqNiAaIypaaqR0DFyojY3bKTuLzedv4LJNpN6r92gOZux9m/t+i1gDj1JpGUw XdzfnJhSce31jn8yRunVP1TffGoAH3jyT3yCKqPfFryCodyr5Ku1NvsvKOnpWwHFs+ 9mXeIHyvZEiaP3nGp2V20W14pf9i4HBfMJMoBQV8= Received: by mail-ot1-f47.google.com with SMTP id m12so5891907otr.0; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) X-Gm-Message-State: AOAM531Jur4Ady7/yV948tBpGCTx9st/WxxahTRABC60EldDWWGHBDtx IyW6KUjHUBhsGHv4dCd8tPM6SMhaqNgE4CnZfA== X-Google-Smtp-Source: ABdhPJwgdQQ94kk1CAJVTaLgyAzK5jSLiZzPbGFE5cSpTlp+14Bb87D1OUAiLGeIZ3x+kwKNZ39GOoJ1D5VzhOMWVEw= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21705872otp.107.1600445283255; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com> <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03> In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03> From: Rob Herring Date: Fri, 18 Sep 2020 10:07:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_120805_529603_C764473C X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Youlin Pei , devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream , Chao Hao , Robin Murphy , Joerg Roedel , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , Linux IOMMU , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Ming-Fan Chen , Anan Sun , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > [...] > > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt2701-m4u #mt2701 generation one HW > > > + - mediatek,mt2712-m4u #mt2712 generation two HW > > > + - mediatek,mt6779-m4u #mt6779 generation two HW > > > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW > > > > This is not right. > > > > items: > > - const: mediatek,mt7623-m4u > > - const: mediatek,mt2701-m4u > > > > And that has to be under a 'oneOf' with the rest of this. > > Thanks for the review. Is this OK? > > compatible: > oneOf: > - const: mediatek,mt2701-m4u # mt2701 generation one HW > - const: mediatek,mt2712-m4u # mt2712 generation two HW > - const: mediatek,mt6779-m4u # mt6779 generation two HW > - const: mediatek,mt8173-m4u # mt8173 generation two HW > - const: mediatek,mt8183-m4u # mt8183 generation two HW > - const: mediatek,mt8192-m4u # mt8192 generation two HW It is correct, but I prefer all these to be a single enum. So 'oneOf' would have 2 entries. > - description: mt7623 generation one HW > items: > - const: mediatek,mt7623-m4u > - const: mediatek,mt2701-m4u > > > > > > + - mediatek,mt8173-m4u #mt8173 generation two HW > > > + - mediatek,mt8183-m4u #mt8183 generation two HW > > > + > > > + reg: > > > + maxItems: 1 > > [snip] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel