From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 3/7] of: reserved_mem: add support for named reserved mem nodes Date: Wed, 30 Dec 2015 17:25:04 -0600 Message-ID: References: <1450280249-24681-1-git-send-email-m.szyprowski@samsung.com> <1450280249-24681-4-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1450280249-24681-4-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Marek Szyprowski Cc: "linux-media@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Sylwester Nawrocki , Kamil Debski , Laurent Pinchart , Andrzej Hajda , Kukjin Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Frank Rowand , Grant Likely List-Id: devicetree@vger.kernel.org On Wed, Dec 16, 2015 at 9:37 AM, Marek Szyprowski wrote: > This patch allows device drivers to initialize more than one reserved > memory region assigned to given device. When driver needs to use more > than one reserved memory region, it should allocate child devices and > initialize regions by index or name for each of its child devices. > > Signed-off-by: Marek Szyprowski > --- > .../bindings/reserved-memory/reserved-memory.txt | 2 + > .../devicetree/bindings/resource-names.txt | 1 + > drivers/of/of_reserved_mem.c | 104 +++++++++++++++++---- > include/linux/of_reserved_mem.h | 31 +++++- > 4 files changed, 115 insertions(+), 23 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > index 3da0ebdba8d9..43a14957fd64 100644 > --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > @@ -74,6 +74,8 @@ Regions in the /reserved-memory node may be referenced by other device > nodes by adding a memory-region property to the device node. > > memory-region (optional) - phandle, specifier pairs to children of /reserved-memory > +memory-region-names (optional) - supplemental names property, provide array of > + names to identify memory regions > > Example > ------- > diff --git a/Documentation/devicetree/bindings/resource-names.txt b/Documentation/devicetree/bindings/resource-names.txt > index e280fef6f265..51823e99b983 100644 > --- a/Documentation/devicetree/bindings/resource-names.txt > +++ b/Documentation/devicetree/bindings/resource-names.txt > @@ -12,6 +12,7 @@ Resource Property Supplemental Names Property > reg reg-names > clocks clock-names > interrupts interrupt-names > +memory-region memory-region-names The other cases of *-names should correspond to actual h/w names for a h/w block. memory-regions are not really h/w. So I'd prefer to not add memory-region-names. If you want a name for the region, put it in the region node. The name for each client node is not going to be different. Rob