From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9E5C43387 for ; Thu, 20 Dec 2018 13:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7776A21852 for ; Thu, 20 Dec 2018 13:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545313743; bh=/yCjwrulphD2Ub/SJaKoA4YCvHnIDETP1sWJiQIgqqs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Bs68I9RTNxHL0J5zhYNdCVD4fVpsdSLIrJa1l9TTSgM2fmsHvHDUUc3JUpVXrPfeL BVpcDx9c22vnFvJJ8HO0WG5BVGY1DQAUUQU60L86vWANLyeoGrb+92XyUqNABJ1Js+ SYsCiEcbaH5NbY2Ta1rm9+LOeEa5ZpKa/t0UmH+U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387425AbeLTNtC (ORCPT ); Thu, 20 Dec 2018 08:49:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:39736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733309AbeLTNs5 (ORCPT ); Thu, 20 Dec 2018 08:48:57 -0500 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAD69218AE; Thu, 20 Dec 2018 13:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545313735; bh=/yCjwrulphD2Ub/SJaKoA4YCvHnIDETP1sWJiQIgqqs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AbneHcqpFOnHLNaK2zIrV5FSiWQzjAshS6FEHF2Y2SuzdgNrLwyZFNP9ned/Sg7gE qgfWh6O5OL2YNs12yaZ6yadG0FtgpDEmrqb0AEFRVqAMRMyAlT++6Ppap8BRRZtaka I1VZxvH32QtiX4C7f8g6PkUGyIgpL/nlQ9+53chA= Received: by mail-qt1-f178.google.com with SMTP id v11so1839944qtc.2; Thu, 20 Dec 2018 05:48:55 -0800 (PST) X-Gm-Message-State: AA+aEWbDINonTvXQUEmK3Mzvo2tmnP4ibDktECZ30HbXm+AnwHmFu/1F lukfu/CkjnvNube26/A8OUJ4+Po0LF3+20DpJQ== X-Google-Smtp-Source: AFSGD/U6DXCG168neThkYAkaCKk5p9JOzPkqJ0RwyBvfcsyIkuR/iQgiIFpRh6FVOyckXOXFkRrTe/tx/eoU4I6CpWI= X-Received: by 2002:a0c:e2ca:: with SMTP id t10mr26787364qvl.77.1545313734888; Thu, 20 Dec 2018 05:48:54 -0800 (PST) MIME-Version: 1.0 References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-2-chenyu56@huawei.com> <33cda716-d09c-28e7-d4b4-26f246786f5e@huawei.com> <680c5b9f-e2c7-926d-7d10-4ce2cd091282@cogentembedded.com> <20181219140953.GA9910@bogus> <87y38ku24b.fsf@linux.intel.com> In-Reply-To: <87y38ku24b.fsf@linux.intel.com> From: Rob Herring Date: Thu, 20 Dec 2018 07:48:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs To: Felipe Balbi Cc: Chen Yu , Sergei Shtylyov , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Wangbinghui , Suzhuangluan , kongfei@hisilicon.com, Greg Kroah-Hartman , Mark Rutland , John Stultz Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 12:46 AM Felipe Balbi wrote: > > > Hi, > > Rob Herring writes: > >> >>>> +Example: > >> >>>> + usb3: hisi_dwc3 { > >> >>>> + compatible = "hisilicon,hi3660-dwc3"; > >> >>>> + #address-cells = <2>; > >> >>>> + #size-cells = <2>; > >> >>>> + ranges; > >> >>>> + > >> >>>> + clocks = <&crg_ctrl HI3660_CLK_ABB_USB>, > >> >>>> + <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; > >> >>>> + clock-names = "clk_usb3phy_ref", "aclk_usb3otg"; > >> >>>> + assigned-clocks = <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; > >> >>>> + assigned-clock-rates = <229000000>; > >> >>>> + resets = <&crg_rst 0x90 8>, > >> >>>> + <&crg_rst 0x90 7>, > >> >>>> + <&crg_rst 0x90 6>, > >> >>>> + <&crg_rst 0x90 5>; > >> >>>> + > >> >>>> + dwc3: dwc3@ff100000 { > > > > Please combine these into a single node. Unless you have a wrapper with > > registers, you don't need these 2 nodes. Clocks and reset can go in the > > dwc3 node. > > > >> >>> > >> >>> According to the DT spec, the node names should be generic, not chip specific, i.e. usb@ff100000 in this case. > >> >>> > >> >> > >> >> Do you mean it should be usb@ff100000: dwc3@ff100000 ? > >> > > >> > dwc3: usb@ff100000 > >> > > >> > "dwc3:" is a label, not name. > >> > >> I use the node name "dwc3@ff100000" according to Documentation/devicetree/bindings/usb/dwc3.txt > >> and documentations of vendor drivers, i.e. qcom,dwc3.txt, rockchip,dwc3.txt. > >> > >> In these documentations, the dwc3 sub-node name uses "dwc3@xxxxxxxx". > >> > >> I think it is better to be same as the other vendor's dwc3 drivers. > > > > It's not. The other bindings are wrong. Follow the DT Spec. > > what's wrong about them? They clearly describe the HW: > > 1) a company-specific glue/adaptation/integration IP > 2) a generic licensed IP inside it That is *every* licensed IP block and DWC3 is the oddball where we did this 2 node thing. It is not a pattern we should continue. If there's registers in the wrapper, then yes, having 2 nodes makes sense. But just additional clocks or resets, no. I would guess these extra clocks and resets are inter-connect related and are needed as an artifact of not describing and managing inter-connects. I can just as easily argue it doesn't describe the hardware. I'm pretty sure the DWC3 has clocks and resets yet there are none in the DWC3 node. How can it operate with no clocks? > dwc3.ko is compatible with Synopsys' documentation and there's only one > incarnation of dwc3. Everything that can be detected in runtime, we do > so. Everything that can't, we use quirk flags. Keep in mind dwc3.ko is > also used as is by non-DT systems where we can't simply change a > compatible flag. Linux driver architecture doesn't dictate bindings. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs From: Rob Herring Message-Id: Date: Thu, 20 Dec 2018 07:48:43 -0600 To: Felipe Balbi Cc: Chen Yu , Sergei Shtylyov , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Wangbinghui , Suzhuangluan , kongfei@hisilicon.com, Greg Kroah-Hartman , Mark Rutland , John Stultz List-ID: T24gVGh1LCBEZWMgMjAsIDIwMTggYXQgMTI6NDYgQU0gRmVsaXBlIEJhbGJpCjxmZWxpcGUuYmFs YmlAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+Cj4gSGksCj4KPiBSb2IgSGVycmluZyA8cm9i aEBrZXJuZWwub3JnPiB3cml0ZXM6Cj4gPj4gPj4+PiArRXhhbXBsZToKPiA+PiA+Pj4+ICsgICAg dXNiMzogaGlzaV9kd2MzIHsKPiA+PiA+Pj4+ICsgICAgICAgIGNvbXBhdGlibGUgPSAiaGlzaWxp Y29uLGhpMzY2MC1kd2MzIjsKPiA+PiA+Pj4+ICsgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+ Owo+ID4+ID4+Pj4gKyAgICAgICAgI3NpemUtY2VsbHMgPSA8Mj47Cj4gPj4gPj4+PiArICAgICAg ICByYW5nZXM7Cj4gPj4gPj4+PiArCj4gPj4gPj4+PiArICAgICAgICBjbG9ja3MgPSA8JmNyZ19j dHJsIEhJMzY2MF9DTEtfQUJCX1VTQj4sCj4gPj4gPj4+PiArICAgICAgICAgICAgIDwmY3JnX2N0 cmwgSEkzNjYwX0FDTEtfR0FURV9VU0IzT1RHPjsKPiA+PiA+Pj4+ICsgICAgICAgIGNsb2NrLW5h bWVzID0gImNsa191c2IzcGh5X3JlZiIsICJhY2xrX3VzYjNvdGciOwo+ID4+ID4+Pj4gKyAgICAg ICAgYXNzaWduZWQtY2xvY2tzID0gPCZjcmdfY3RybCBISTM2NjBfQUNMS19HQVRFX1VTQjNPVEc+ Owo+ID4+ID4+Pj4gKyAgICAgICAgYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8MjI5MDAwMDAwPjsK PiA+PiA+Pj4+ICsgICAgICAgIHJlc2V0cyA9IDwmY3JnX3JzdCAweDkwIDg+LAo+ID4+ID4+Pj4g KyAgICAgICAgICAgICA8JmNyZ19yc3QgMHg5MCA3PiwKPiA+PiA+Pj4+ICsgICAgICAgICAgICAg PCZjcmdfcnN0IDB4OTAgNj4sCj4gPj4gPj4+PiArICAgICAgICAgICAgIDwmY3JnX3JzdCAweDkw IDU+Owo+ID4+ID4+Pj4gKwo+ID4+ID4+Pj4gKyAgICAgICAgZHdjMzogZHdjM0BmZjEwMDAwMCB7 Cj4gPgo+ID4gUGxlYXNlIGNvbWJpbmUgdGhlc2UgaW50byBhIHNpbmdsZSBub2RlLiBVbmxlc3Mg eW91IGhhdmUgYSB3cmFwcGVyIHdpdGgKPiA+IHJlZ2lzdGVycywgeW91IGRvbid0IG5lZWQgdGhl c2UgMiBub2Rlcy4gQ2xvY2tzIGFuZCByZXNldCBjYW4gZ28gaW4gdGhlCj4gPiBkd2MzIG5vZGUu Cj4gPgo+ID4+ID4+Pgo+ID4+ID4+PiAgICAgIEFjY29yZGluZyB0byB0aGUgRFQgc3BlYywgdGhl IG5vZGUgbmFtZXMgc2hvdWxkIGJlIGdlbmVyaWMsIG5vdCBjaGlwIHNwZWNpZmljLCBpLmUuIHVz YkBmZjEwMDAwMCBpbiB0aGlzIGNhc2UuCj4gPj4gPj4+Cj4gPj4gPj4KPiA+PiA+PiBEbyB5b3Ug bWVhbiBpdCBzaG91bGQgYmUgdXNiQGZmMTAwMDAwOiBkd2MzQGZmMTAwMDAwID8KPiA+PiA+Cj4g Pj4gPiAgICAgZHdjMzogdXNiQGZmMTAwMDAwCj4gPj4gPgo+ID4+ID4gICAgImR3YzM6IiBpcyBh IGxhYmVsLCBub3QgbmFtZS4KPiA+Pgo+ID4+IEkgdXNlIHRoZSBub2RlIG5hbWUgImR3YzNAZmYx MDAwMDAiIGFjY29yZGluZyB0byBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNi L2R3YzMudHh0Cj4gPj4gYW5kIGRvY3VtZW50YXRpb25zIG9mIHZlbmRvciBkcml2ZXJzLCBpLmUu IHFjb20sZHdjMy50eHQsIHJvY2tjaGlwLGR3YzMudHh0Lgo+ID4+Cj4gPj4gSW4gdGhlc2UgZG9j dW1lbnRhdGlvbnMsIHRoZSBkd2MzIHN1Yi1ub2RlIG5hbWUgdXNlcyAiZHdjM0B4eHh4eHh4eCIu Cj4gPj4KPiA+PiBJIHRoaW5rIGl0IGlzIGJldHRlciB0byBiZSBzYW1lIGFzIHRoZSBvdGhlciB2 ZW5kb3IncyBkd2MzIGRyaXZlcnMuCj4gPgo+ID4gSXQncyBub3QuIFRoZSBvdGhlciBiaW5kaW5n cyBhcmUgd3JvbmcuIEZvbGxvdyB0aGUgRFQgU3BlYy4KPgo+IHdoYXQncyB3cm9uZyBhYm91dCB0 aGVtPyBUaGV5IGNsZWFybHkgZGVzY3JpYmUgdGhlIEhXOgo+Cj4gMSkgYSBjb21wYW55LXNwZWNp ZmljIGdsdWUvYWRhcHRhdGlvbi9pbnRlZ3JhdGlvbiBJUAo+IDIpIGEgZ2VuZXJpYyBsaWNlbnNl ZCBJUCBpbnNpZGUgaXQKClRoYXQgaXMgKmV2ZXJ5KiBsaWNlbnNlZCBJUCBibG9jayBhbmQgRFdD MyBpcyB0aGUgb2RkYmFsbCB3aGVyZSB3ZSBkaWQKdGhpcyAyIG5vZGUgdGhpbmcuIEl0IGlzIG5v dCBhIHBhdHRlcm4gd2Ugc2hvdWxkIGNvbnRpbnVlLiBJZiB0aGVyZSdzCnJlZ2lzdGVycyBpbiB0 aGUgd3JhcHBlciwgdGhlbiB5ZXMsIGhhdmluZyAyIG5vZGVzIG1ha2VzIHNlbnNlLiBCdXQKanVz dCBhZGRpdGlvbmFsIGNsb2NrcyBvciByZXNldHMsIG5vLiBJIHdvdWxkIGd1ZXNzIHRoZXNlIGV4 dHJhIGNsb2NrcwphbmQgcmVzZXRzIGFyZSBpbnRlci1jb25uZWN0IHJlbGF0ZWQgYW5kIGFyZSBu ZWVkZWQgYXMgYW4gYXJ0aWZhY3Qgb2YKbm90IGRlc2NyaWJpbmcgYW5kIG1hbmFnaW5nIGludGVy LWNvbm5lY3RzLgoKSSBjYW4ganVzdCBhcyBlYXNpbHkgYXJndWUgaXQgZG9lc24ndCBkZXNjcmli ZSB0aGUgaGFyZHdhcmUuIEknbQpwcmV0dHkgc3VyZSB0aGUgRFdDMyBoYXMgY2xvY2tzIGFuZCBy ZXNldHMgeWV0IHRoZXJlIGFyZSBub25lIGluIHRoZQpEV0MzIG5vZGUuIEhvdyBjYW4gaXQgb3Bl cmF0ZSB3aXRoIG5vIGNsb2Nrcz8KCj4gZHdjMy5rbyBpcyBjb21wYXRpYmxlIHdpdGggU3lub3Bz eXMnIGRvY3VtZW50YXRpb24gYW5kIHRoZXJlJ3Mgb25seSBvbmUKPiBpbmNhcm5hdGlvbiBvZiBk d2MzLiBFdmVyeXRoaW5nIHRoYXQgY2FuIGJlIGRldGVjdGVkIGluIHJ1bnRpbWUsIHdlIGRvCj4g c28uIEV2ZXJ5dGhpbmcgdGhhdCBjYW4ndCwgd2UgdXNlIHF1aXJrIGZsYWdzLiBLZWVwIGluIG1p bmQgZHdjMy5rbyBpcwo+IGFsc28gdXNlZCBhcyBpcyBieSBub24tRFQgc3lzdGVtcyB3aGVyZSB3 ZSBjYW4ndCBzaW1wbHkgY2hhbmdlIGEKPiBjb21wYXRpYmxlIGZsYWcuCgpMaW51eCBkcml2ZXIg YXJjaGl0ZWN0dXJlIGRvZXNuJ3QgZGljdGF0ZSBiaW5kaW5ncy4KClJvYgo=