From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] SATA: OCTEON: support SATA on OCTEON platform Date: Mon, 19 Jan 2015 14:30:22 -0600 Message-ID: References: <1421681040-3392-1-git-send-email-aleksey.makarov@auriga.com> <20150119154357.GH21553@leverpostej> <54BD580C.6030701@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-we0-f181.google.com ([74.125.82.181]:39045 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbbASUao (ORCPT ); Mon, 19 Jan 2015 15:30:44 -0500 In-Reply-To: <54BD580C.6030701@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Daney Cc: Mark Rutland , Aleksey Makarov , "linux-ide@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-kernel@vger.kernel.org" , David Daney , Anton Vorontsov , Vinita Gupta , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Ralf Baechle , Tejun Heo , Hans de Goede , "devicetree@vger.kernel.org" On Mon, Jan 19, 2015 at 1:16 PM, David Daney wrote: > On 01/19/2015 07:43 AM, Mark Rutland wrote: >> >> On Mon, Jan 19, 2015 at 03:23:58PM +0000, Aleksey Makarov wrote: >>> >>> The OCTEON SATA controller is currently found on cn71XX devices. [...] >>> + >>> + /* Set a good dma_mask */ >>> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(64); >>> + pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; >> >> >> I thought a dma-ranges property in the DT could be used to set up the >> DMA mask appropriately? > > > The DT contains no dma-ranges property, and we know a priori, that it should > be 64-bits. Neither this code nor dma-ranges should be necessary. The AHCI core code will set the mask to 32 or 64 bits based on the AHCI Capabilities register. Rob