From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D55722194D3B3 for ; Thu, 6 Dec 2018 16:41:59 -0800 (PST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71CA22146F for ; Fri, 7 Dec 2018 00:41:59 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id a132so1545023qkg.1 for ; Thu, 06 Dec 2018 16:41:59 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Thu, 6 Dec 2018 18:41:46 -0600 Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-ID: On Wed, Dec 5, 2018 at 5:43 PM Brendan Higgins wrote: > > On Tue, Dec 4, 2018 at 5:41 AM Rob Herring wrote: > > > > On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins > > wrote: > > > > > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > > >> index ad3fcad4d75b8..f309399deac20 100644 > > > > >> --- a/drivers/of/Kconfig > > > > >> +++ b/drivers/of/Kconfig > > > > >> @@ -15,6 +15,7 @@ if OF > > > > >> config OF_UNITTEST > > > > >> bool "Device Tree runtime unit tests" > > > > >> depends on !SPARC > > > > >> + depends on KUNIT > > > > > Unless KUNIT has depends, better to be a select here. > > > > > > > > That's just style or taste. I would prefer to use depends > > > > instead of select, but that's also just my preference. > > > > > > I prefer depends too, but Rob is the maintainer here. > > > > Well, we should be consistent, not the follow the whims of each maintainer. > > Sorry, I don't think that came out the way I meant it. I don't really > think we are consistent on this point across the kernel, and I don't > feel very strongly about the point, so I was just looking to follow > the path of least resistance. (I also just assumed Rob would keep us > consistent within drivers/of/.) I meant across unittests, we should be consistent. All unittests do either "depends on KUNIT" or "select KUNIT". The question I would ask is does KUNIT need to be user visible or is useful to enable without any unittests enabled? With depends, a user has 2 options to go enable vs. 1 with select. But if you want a global kill switch to turn off all unittests, then depends works better. > I figure if we are running unit tests from the test runner script or > from an automated system, you won't be hunting for dependencies for a > single test every time you want to run a test, so select doesn't make > it easier to configure in most imagined use cases. > > KUNIT hypothetically should not depend on anything, so select should > be safe to use. > > On the other hand, if we end up being wrong on this point and KUnit > gains widespread adoption, I would prefer not to be in a position > where I have to change a bunch of configs all over the kernel because > this example got copied and pasted. You'll be so happy that 100s of tests have been created using kunit, it won't be a big deal. :) In any case, I wouldn't spend more time on this. Rob _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B86C04EB8 for ; Fri, 7 Dec 2018 00:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D517E20989 for ; Fri, 7 Dec 2018 00:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544143321; bh=vqp8LjO/eMXwBlhMDX3QdEwSenFyWd4X75HHYRPAels=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Esl1IwdjGrmEEcWCUVBNSWfl0SiQJnoxaC9bag0TMtYa7aaVlPwpQtDZZaOyz4rGj kOHkU4RarigYlxAx0s2I13MuGPp6mBTnIPz6FipOGuXgxaVoj7Bp5TFV+D6NwC9f2Z xEGmMNM53Qccz50JBX/uOR24pA0lmMTL/ho8XUN4= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D517E20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725978AbeLGAmA (ORCPT ); Thu, 6 Dec 2018 19:42:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:54622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbeLGAl7 (ORCPT ); Thu, 6 Dec 2018 19:41:59 -0500 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FAED2146D; Fri, 7 Dec 2018 00:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544143318; bh=vqp8LjO/eMXwBlhMDX3QdEwSenFyWd4X75HHYRPAels=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LMIdoN64gZ3+E4s9S6nSnbOT3yGBylkLJ6fLubvRXjc1u5igW4FxS4Lu5IfsUzQGn Pp37FjBBWAkqcgQUdF/FY1USQX6OTsw6Q99p2UX7yQCDxU3G+drWYW4CR3Fvpkz5wU JByKJMPgQX9IA7O4ODVfKs3qF5u6NWdFNQT5afSM= Received: by mail-qk1-f178.google.com with SMTP id n12so1507351qkh.11; Thu, 06 Dec 2018 16:41:58 -0800 (PST) X-Gm-Message-State: AA+aEWaXfkz+Z6hvubPUi0V3Shtt9MizuqW/fN9FMpTtp69z7xwiw4q9 iGbQM7EsbUu+tOEtBgntumfDJpgioQldTYyoTw== X-Google-Smtp-Source: AFSGD/V5c0Rcj8uh4ezUc6Ji6kbJVtMeogNVfn9uDAETaZ+bmWVWfNjwQMLiTaaKFzCYvamqdvTH1D6+zQjV8NUDFlU= X-Received: by 2002:a37:7682:: with SMTP id r124mr92987qkc.79.1544143317614; Thu, 06 Dec 2018 16:41:57 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Thu, 6 Dec 2018 18:41:46 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit To: Brendan Higgins Cc: Randy Dunlap , Greg Kroah-Hartman , Kees Cook , "Luis R. Rodriguez" , shuah@kernel.org, Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, "linux-kernel@vger.kernel.org" , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Dan Williams , linux-nvdimm , Kieran Bingham , Frank Rowand , knut.omang@oracle.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 5, 2018 at 5:43 PM Brendan Higgins wrote: > > On Tue, Dec 4, 2018 at 5:41 AM Rob Herring wrote: > > > > On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins > > wrote: > > > > > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > > >> index ad3fcad4d75b8..f309399deac20 100644 > > > > >> --- a/drivers/of/Kconfig > > > > >> +++ b/drivers/of/Kconfig > > > > >> @@ -15,6 +15,7 @@ if OF > > > > >> config OF_UNITTEST > > > > >> bool "Device Tree runtime unit tests" > > > > >> depends on !SPARC > > > > >> + depends on KUNIT > > > > > Unless KUNIT has depends, better to be a select here. > > > > > > > > That's just style or taste. I would prefer to use depends > > > > instead of select, but that's also just my preference. > > > > > > I prefer depends too, but Rob is the maintainer here. > > > > Well, we should be consistent, not the follow the whims of each maintainer. > > Sorry, I don't think that came out the way I meant it. I don't really > think we are consistent on this point across the kernel, and I don't > feel very strongly about the point, so I was just looking to follow > the path of least resistance. (I also just assumed Rob would keep us > consistent within drivers/of/.) I meant across unittests, we should be consistent. All unittests do either "depends on KUNIT" or "select KUNIT". The question I would ask is does KUNIT need to be user visible or is useful to enable without any unittests enabled? With depends, a user has 2 options to go enable vs. 1 with select. But if you want a global kill switch to turn off all unittests, then depends works better. > I figure if we are running unit tests from the test runner script or > from an automated system, you won't be hunting for dependencies for a > single test every time you want to run a test, so select doesn't make > it easier to configure in most imagined use cases. > > KUNIT hypothetically should not depend on anything, so select should > be safe to use. > > On the other hand, if we end up being wrong on this point and KUnit > gains widespread adoption, I would prefer not to be in a position > where I have to change a bunch of configs all over the kernel because > this example got copied and pasted. You'll be so happy that 100s of tests have been created using kunit, it won't be a big deal. :) In any case, I wouldn't spend more time on this. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh at kernel.org (Rob Herring) Date: Thu, 6 Dec 2018 18:41:46 -0600 Subject: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Message-ID: On Wed, Dec 5, 2018 at 5:43 PM Brendan Higgins wrote: > > On Tue, Dec 4, 2018 at 5:41 AM Rob Herring wrote: > > > > On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins > > wrote: > > > > > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > > >> index ad3fcad4d75b8..f309399deac20 100644 > > > > >> --- a/drivers/of/Kconfig > > > > >> +++ b/drivers/of/Kconfig > > > > >> @@ -15,6 +15,7 @@ if OF > > > > >> config OF_UNITTEST > > > > >> bool "Device Tree runtime unit tests" > > > > >> depends on !SPARC > > > > >> + depends on KUNIT > > > > > Unless KUNIT has depends, better to be a select here. > > > > > > > > That's just style or taste. I would prefer to use depends > > > > instead of select, but that's also just my preference. > > > > > > I prefer depends too, but Rob is the maintainer here. > > > > Well, we should be consistent, not the follow the whims of each maintainer. > > Sorry, I don't think that came out the way I meant it. I don't really > think we are consistent on this point across the kernel, and I don't > feel very strongly about the point, so I was just looking to follow > the path of least resistance. (I also just assumed Rob would keep us > consistent within drivers/of/.) I meant across unittests, we should be consistent. All unittests do either "depends on KUNIT" or "select KUNIT". The question I would ask is does KUNIT need to be user visible or is useful to enable without any unittests enabled? With depends, a user has 2 options to go enable vs. 1 with select. But if you want a global kill switch to turn off all unittests, then depends works better. > I figure if we are running unit tests from the test runner script or > from an automated system, you won't be hunting for dependencies for a > single test every time you want to run a test, so select doesn't make > it easier to configure in most imagined use cases. > > KUNIT hypothetically should not depend on anything, so select should > be safe to use. > > On the other hand, if we end up being wrong on this point and KUnit > gains widespread adoption, I would prefer not to be in a position > where I have to change a bunch of configs all over the kernel because > this example got copied and pasted. You'll be so happy that 100s of tests have been created using kunit, it won't be a big deal. :) In any case, I wouldn't spend more time on this. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Thu, 6 Dec 2018 18:41:46 -0600 Subject: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20181207004146.9PZYywfMXmknbYEH4KNpt2Z05KQfObuU93oHFRcI8aI@z> On Wed, Dec 5, 2018 at 5:43 PM Brendan Higgins wrote: > > On Tue, Dec 4, 2018@5:41 AM Rob Herring wrote: > > > > On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins > > wrote: > > > > > > On Thu, Nov 29, 2018@4:40 PM Randy Dunlap wrote: > > > > > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > > >> index ad3fcad4d75b8..f309399deac20 100644 > > > > >> --- a/drivers/of/Kconfig > > > > >> +++ b/drivers/of/Kconfig > > > > >> @@ -15,6 +15,7 @@ if OF > > > > >> config OF_UNITTEST > > > > >> bool "Device Tree runtime unit tests" > > > > >> depends on !SPARC > > > > >> + depends on KUNIT > > > > > Unless KUNIT has depends, better to be a select here. > > > > > > > > That's just style or taste. I would prefer to use depends > > > > instead of select, but that's also just my preference. > > > > > > I prefer depends too, but Rob is the maintainer here. > > > > Well, we should be consistent, not the follow the whims of each maintainer. > > Sorry, I don't think that came out the way I meant it. I don't really > think we are consistent on this point across the kernel, and I don't > feel very strongly about the point, so I was just looking to follow > the path of least resistance. (I also just assumed Rob would keep us > consistent within drivers/of/.) I meant across unittests, we should be consistent. All unittests do either "depends on KUNIT" or "select KUNIT". The question I would ask is does KUNIT need to be user visible or is useful to enable without any unittests enabled? With depends, a user has 2 options to go enable vs. 1 with select. But if you want a global kill switch to turn off all unittests, then depends works better. > I figure if we are running unit tests from the test runner script or > from an automated system, you won't be hunting for dependencies for a > single test every time you want to run a test, so select doesn't make > it easier to configure in most imagined use cases. > > KUNIT hypothetically should not depend on anything, so select should > be safe to use. > > On the other hand, if we end up being wrong on this point and KUnit > gains widespread adoption, I would prefer not to be in a position > where I have to change a bunch of configs all over the kernel because > this example got copied and pasted. You'll be so happy that 100s of tests have been created using kunit, it won't be a big deal. :) In any case, I wouldn't spend more time on this. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit Date: Thu, 6 Dec 2018 18:41:46 -0600 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2B676E690 for ; Fri, 7 Dec 2018 00:41:58 +0000 (UTC) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88F0A2151B for ; Fri, 7 Dec 2018 00:41:58 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id w204so1538052qka.2 for ; Thu, 06 Dec 2018 16:41:58 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird, Timothy" , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Michael Ellerman , Joe Perches List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgNSwgMjAxOCBhdCA1OjQzIFBNIEJyZW5kYW4gSGlnZ2lucwo8YnJlbmRhbmhp Z2dpbnNAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4KPiBPbiBUdWUsIERlYyA0LCAyMDE4IGF0IDU6NDEg QU0gUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gTW9uLCBE ZWMgMywgMjAxOCBhdCA2OjE0IFBNIEJyZW5kYW4gSGlnZ2lucwo+ID4gPGJyZW5kYW5oaWdnaW5z QGdvb2dsZS5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBUaHUsIE5vdiAyOSwgMjAxOCBhdCA0 OjQwIFBNIFJhbmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPiB3cm90ZToKPiA+ID4g Pgo+ID4gPiA+IE9uIDExLzI4LzE4IDEyOjU2IFBNLCBSb2IgSGVycmluZyB3cm90ZToKPiA+ID4g PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9vZi9LY29uZmlnIGIvZHJpdmVycy9vZi9LY29uZmln Cj4gPiA+ID4gPj4gaW5kZXggYWQzZmNhZDRkNzViOC4uZjMwOTM5OWRlYWMyMCAxMDA2NDQKPiA+ ID4gPiA+PiAtLS0gYS9kcml2ZXJzL29mL0tjb25maWcKPiA+ID4gPiA+PiArKysgYi9kcml2ZXJz L29mL0tjb25maWcKPiA+ID4gPiA+PiBAQCAtMTUsNiArMTUsNyBAQCBpZiBPRgo+ID4gPiA+ID4+ ICBjb25maWcgT0ZfVU5JVFRFU1QKPiA+ID4gPiA+PiAgICAgICAgIGJvb2wgIkRldmljZSBUcmVl IHJ1bnRpbWUgdW5pdCB0ZXN0cyIKPiA+ID4gPiA+PiAgICAgICAgIGRlcGVuZHMgb24gIVNQQVJD Cj4gPiA+ID4gPj4gKyAgICAgICBkZXBlbmRzIG9uIEtVTklUCj4gPiA+ID4gPiBVbmxlc3MgS1VO SVQgaGFzIGRlcGVuZHMsIGJldHRlciB0byBiZSBhIHNlbGVjdCBoZXJlLgo+ID4gPiA+Cj4gPiA+ ID4gVGhhdCdzIGp1c3Qgc3R5bGUgb3IgdGFzdGUuICBJIHdvdWxkIHByZWZlciB0byB1c2UgZGVw ZW5kcwo+ID4gPiA+IGluc3RlYWQgb2Ygc2VsZWN0LCBidXQgdGhhdCdzIGFsc28ganVzdCBteSBw cmVmZXJlbmNlLgo+ID4gPgo+ID4gPiBJIHByZWZlciBkZXBlbmRzIHRvbywgYnV0IFJvYiBpcyB0 aGUgbWFpbnRhaW5lciBoZXJlLgo+ID4KPiA+IFdlbGwsIHdlIHNob3VsZCBiZSBjb25zaXN0ZW50 LCBub3QgdGhlIGZvbGxvdyB0aGUgd2hpbXMgb2YgZWFjaCBtYWludGFpbmVyLgo+Cj4gU29ycnks IEkgZG9uJ3QgdGhpbmsgdGhhdCBjYW1lIG91dCB0aGUgd2F5IEkgbWVhbnQgaXQuIEkgZG9uJ3Qg cmVhbGx5Cj4gdGhpbmsgd2UgYXJlIGNvbnNpc3RlbnQgb24gdGhpcyBwb2ludCBhY3Jvc3MgdGhl IGtlcm5lbCwgYW5kIEkgZG9uJ3QKPiBmZWVsIHZlcnkgc3Ryb25nbHkgYWJvdXQgdGhlIHBvaW50 LCBzbyBJIHdhcyBqdXN0IGxvb2tpbmcgdG8gZm9sbG93Cj4gdGhlIHBhdGggb2YgbGVhc3QgcmVz aXN0YW5jZS4gKEkgYWxzbyBqdXN0IGFzc3VtZWQgUm9iIHdvdWxkIGtlZXAgdXMKPiBjb25zaXN0 ZW50IHdpdGhpbiBkcml2ZXJzL29mLy4pCgpJIG1lYW50IGFjcm9zcyB1bml0dGVzdHMsIHdlIHNo b3VsZCBiZSBjb25zaXN0ZW50LiBBbGwgdW5pdHRlc3RzIGRvCmVpdGhlciAiZGVwZW5kcyBvbiBL VU5JVCIgb3IgInNlbGVjdCBLVU5JVCIuIFRoZSBxdWVzdGlvbiBJIHdvdWxkIGFzawppcyBkb2Vz IEtVTklUIG5lZWQgdG8gYmUgdXNlciB2aXNpYmxlIG9yIGlzIHVzZWZ1bCB0byBlbmFibGUgd2l0 aG91dAphbnkgdW5pdHRlc3RzIGVuYWJsZWQ/IFdpdGggZGVwZW5kcywgYSB1c2VyIGhhcyAyIG9w dGlvbnMgdG8gZ28gZW5hYmxlCnZzLiAxIHdpdGggc2VsZWN0LgoKQnV0IGlmIHlvdSB3YW50IGEg Z2xvYmFsIGtpbGwgc3dpdGNoIHRvIHR1cm4gb2ZmIGFsbCB1bml0dGVzdHMsIHRoZW4KZGVwZW5k cyB3b3JrcyBiZXR0ZXIuCgo+IEkgZmlndXJlIGlmIHdlIGFyZSBydW5uaW5nIHVuaXQgdGVzdHMg ZnJvbSB0aGUgdGVzdCBydW5uZXIgc2NyaXB0IG9yCj4gZnJvbSBhbiBhdXRvbWF0ZWQgc3lzdGVt LCB5b3Ugd29uJ3QgYmUgaHVudGluZyBmb3IgZGVwZW5kZW5jaWVzIGZvciBhCj4gc2luZ2xlIHRl c3QgZXZlcnkgdGltZSB5b3Ugd2FudCB0byBydW4gYSB0ZXN0LCBzbyBzZWxlY3QgZG9lc24ndCBt YWtlCj4gaXQgZWFzaWVyIHRvIGNvbmZpZ3VyZSBpbiBtb3N0IGltYWdpbmVkIHVzZSBjYXNlcy4K Pgo+IEtVTklUIGh5cG90aGV0aWNhbGx5IHNob3VsZCBub3QgZGVwZW5kIG9uIGFueXRoaW5nLCBz byBzZWxlY3Qgc2hvdWxkCj4gYmUgc2FmZSB0byB1c2UuCj4KPiBPbiB0aGUgb3RoZXIgaGFuZCwg aWYgd2UgZW5kIHVwIGJlaW5nIHdyb25nIG9uIHRoaXMgcG9pbnQgYW5kIEtVbml0Cj4gZ2FpbnMg d2lkZXNwcmVhZCBhZG9wdGlvbiwgSSB3b3VsZCBwcmVmZXIgbm90IHRvIGJlIGluIGEgcG9zaXRp b24KPiB3aGVyZSBJIGhhdmUgdG8gY2hhbmdlIGEgYnVuY2ggb2YgY29uZmlncyBhbGwgb3ZlciB0 aGUga2VybmVsIGJlY2F1c2UKPiB0aGlzIGV4YW1wbGUgZ290IGNvcGllZCBhbmQgcGFzdGVkLgoK WW91J2xsIGJlIHNvIGhhcHB5IHRoYXQgMTAwcyBvZiB0ZXN0cyBoYXZlIGJlZW4gY3JlYXRlZCB1 c2luZyBrdW5pdCwKaXQgd29uJ3QgYmUgYSBiaWcgZGVhbC4gOikKCkluIGFueSBjYXNlLCBJIHdv dWxkbid0IHNwZW5kIG1vcmUgdGltZSBvbiB0aGlzLgoKUm9iCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gV4Db-0001La-8a for linux-um@lists.infradead.org; Fri, 07 Dec 2018 00:42:15 +0000 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 923142154B for ; Fri, 7 Dec 2018 00:41:58 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id r71so1512129qkr.10 for ; Thu, 06 Dec 2018 16:41:58 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Thu, 6 Dec 2018 18:41:46 -0600 Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On Wed, Dec 5, 2018 at 5:43 PM Brendan Higgins wrote: > > On Tue, Dec 4, 2018 at 5:41 AM Rob Herring wrote: > > > > On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins > > wrote: > > > > > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > > >> index ad3fcad4d75b8..f309399deac20 100644 > > > > >> --- a/drivers/of/Kconfig > > > > >> +++ b/drivers/of/Kconfig > > > > >> @@ -15,6 +15,7 @@ if OF > > > > >> config OF_UNITTEST > > > > >> bool "Device Tree runtime unit tests" > > > > >> depends on !SPARC > > > > >> + depends on KUNIT > > > > > Unless KUNIT has depends, better to be a select here. > > > > > > > > That's just style or taste. I would prefer to use depends > > > > instead of select, but that's also just my preference. > > > > > > I prefer depends too, but Rob is the maintainer here. > > > > Well, we should be consistent, not the follow the whims of each maintainer. > > Sorry, I don't think that came out the way I meant it. I don't really > think we are consistent on this point across the kernel, and I don't > feel very strongly about the point, so I was just looking to follow > the path of least resistance. (I also just assumed Rob would keep us > consistent within drivers/of/.) I meant across unittests, we should be consistent. All unittests do either "depends on KUNIT" or "select KUNIT". The question I would ask is does KUNIT need to be user visible or is useful to enable without any unittests enabled? With depends, a user has 2 options to go enable vs. 1 with select. But if you want a global kill switch to turn off all unittests, then depends works better. > I figure if we are running unit tests from the test runner script or > from an automated system, you won't be hunting for dependencies for a > single test every time you want to run a test, so select doesn't make > it easier to configure in most imagined use cases. > > KUNIT hypothetically should not depend on anything, so select should > be safe to use. > > On the other hand, if we end up being wrong on this point and KUnit > gains widespread adoption, I would prefer not to be in a position > where I have to change a bunch of configs all over the kernel because > this example got copied and pasted. You'll be so happy that 100s of tests have been created using kunit, it won't be a big deal. :) In any case, I wouldn't spend more time on this. Rob _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um