All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH REBASE] dt-bindings: pinctrl: use pinctrl.yaml
Date: Tue, 7 Dec 2021 09:17:02 -0600	[thread overview]
Message-ID: <CAL_JsqKzv4GLN8bmskKcA6HE+6nqDwOz=1oGW+z7r6joBFjKLA@mail.gmail.com> (raw)
In-Reply-To: <c2afe6fe-d4d2-c9c3-eb36-90969a0b657d@gmail.com>

On Tue, Dec 7, 2021 at 2:47 AM Rafał Miłecki <zajec5@gmail.com> wrote:
>
> On 06.12.2021 23:50, Rob Herring wrote:
> > On Thu, Dec 2, 2021 at 12:32 AM Rafał Miłecki <zajec5@gmail.com> wrote:
> >>
> >> From: Rafał Miłecki <rafal@milecki.pl>
> >>
> >> Also fix some examples to avoid warnings like:
> >> brcm,ns-pinmux.example.dt.yaml: pin-controller@1800c1c0: $nodename:0: 'pin-controller@1800c1c0' does not match '^pinctrl|pinmux@[0-9a-f]+$'
> >
> > I think you missed some. linux-next now has these warnings:
>
> Oops, sorry, I think I didn't test MFD bindings *after* modifying
> pinctrl bindings.
>
>
> > /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/cirrus,madera.example.dt.yaml:
> > codec@1a: $nodename:0: 'codec@1a' does not match
> > '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> >  From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
>
> I'm not sure how to deal with this one. If you take a look at
> cirrus,madera.yaml it seems to be some complex MFD that is a sound
> device with pin controller and regulator.
>
> I'm not sure: is using pinctrl@ node for that hardware is a correct
> choice?

No, I think you have to drop specifying the node name.

Rob

      parent reply	other threads:[~2021-12-07 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  6:32 [PATCH REBASE] dt-bindings: pinctrl: use pinctrl.yaml Rafał Miłecki
2021-12-05  0:31 ` Linus Walleij
2021-12-06 22:50 ` Rob Herring
2021-12-07  8:47   ` Rafał Miłecki
2021-12-07 10:03     ` Charles Keepax
2021-12-07 15:17     ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqKzv4GLN8bmskKcA6HE+6nqDwOz=1oGW+z7r6joBFjKLA@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.