From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbcEMSNp (ORCPT ); Fri, 13 May 2016 14:13:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:49486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbcEMSNn (ORCPT ); Fri, 13 May 2016 14:13:43 -0400 MIME-Version: 1.0 In-Reply-To: <1463133808-10630-11-git-send-email-rogerq@ti.com> References: <1463133808-10630-1-git-send-email-rogerq@ti.com> <1463133808-10630-11-git-send-email-rogerq@ti.com> From: Rob Herring Date: Fri, 13 May 2016 13:13:19 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 10/14] usb: otg: add hcd companion support To: Roger Quadros Cc: Peter Chen , balbi@kernel.org, Tony Lindgren , Greg Kroah-Hartman , Dan Williams , Mathias Nyman , Joao Pinto , Sergei Shtylyov , Li Jun , Grygorii Strashko , "Shimoda, Yoshihiro" , Sekhar Nori , Bin Liu , Linux USB List , linux-omap , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 5:03 AM, Roger Quadros wrote: > From: Yoshihiro Shimoda > > Since some host controller (e.g. EHCI) needs a companion host controller > (e.g. OHCI), this patch adds such a configuration to use it in the OTG > core. > > Signed-off-by: Yoshihiro Shimoda > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/generic.txt | 3 +++ > drivers/usb/common/usb-otg.c | 32 ++++++++++++++++------- > include/linux/usb/otg.h | 7 ++++- > 3 files changed, 32 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt > index f6866c1..1db1c33 100644 > --- a/Documentation/devicetree/bindings/usb/generic.txt > +++ b/Documentation/devicetree/bindings/usb/generic.txt > @@ -27,6 +27,9 @@ Optional properties: > - otg-controller: phandle to otg controller. Host or gadget controllers can > contain this property to link it to a particular OTG > controller. > + - hcd-needs-companion: must be present if otg controller is dealing with > + EHCI host controller that needs a companion OHCI host > + controller. I thought the conclusion was this is not needed? One thing that is not clear here is otg-controller is a host or device property while hcd-needs-companion is an OTG controller property. These lists should be separated. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v8 10/14] usb: otg: add hcd companion support Date: Fri, 13 May 2016 13:13:19 -0500 Message-ID: References: <1463133808-10630-1-git-send-email-rogerq@ti.com> <1463133808-10630-11-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1463133808-10630-11-git-send-email-rogerq-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roger Quadros Cc: Peter Chen , balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Tony Lindgren , Greg Kroah-Hartman , Dan Williams , Mathias Nyman , Joao Pinto , Sergei Shtylyov , Li Jun , Grygorii Strashko , "Shimoda, Yoshihiro" , Sekhar Nori , Bin Liu , Linux USB List , linux-omap , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, May 13, 2016 at 5:03 AM, Roger Quadros wrote: > From: Yoshihiro Shimoda > > Since some host controller (e.g. EHCI) needs a companion host controller > (e.g. OHCI), this patch adds such a configuration to use it in the OTG > core. > > Signed-off-by: Yoshihiro Shimoda > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/generic.txt | 3 +++ > drivers/usb/common/usb-otg.c | 32 ++++++++++++++++------- > include/linux/usb/otg.h | 7 ++++- > 3 files changed, 32 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt > index f6866c1..1db1c33 100644 > --- a/Documentation/devicetree/bindings/usb/generic.txt > +++ b/Documentation/devicetree/bindings/usb/generic.txt > @@ -27,6 +27,9 @@ Optional properties: > - otg-controller: phandle to otg controller. Host or gadget controllers can > contain this property to link it to a particular OTG > controller. > + - hcd-needs-companion: must be present if otg controller is dealing with > + EHCI host controller that needs a companion OHCI host > + controller. I thought the conclusion was this is not needed? One thing that is not clear here is otg-controller is a host or device property while hcd-needs-companion is an OTG controller property. These lists should be separated. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html