From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 1/6] of/serial: move earlycon early_param handling to serial Date: Tue, 22 Mar 2016 06:15:10 -0500 Message-ID: References: <1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org> <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Aleksey Makarov Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Len Brown , "linux-serial@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , Leif Lindholm , Graeme Gregory , Al Stone , Christopher Covington , Yury Norov , Peter Hurley , "Zheng, Lv" , Frank Rowand , Grant Likely , Jiri Slaby , "devicetree@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org On Tue, Mar 22, 2016 at 5:46 AM, Aleksey Makarov wrote: > From: Leif Lindholm > > We have multiple "earlycon" early_param handlers - merge the DT one into > the main earlycon one. It's a cleanup that also will be useful > to decide if ACPI SPCR earlycon should be set up. How so? Isn't that determined by whether we have ACPI tables or a DT? This goes against trying to limit places of FDT parsing and keeping the early scanning all within fdt.c. At least it is not in the arch code. That said, I'm okay with this change if it helps. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759261AbcCVLPp (ORCPT ); Tue, 22 Mar 2016 07:15:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:53008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758721AbcCVLPe (ORCPT ); Tue, 22 Mar 2016 07:15:34 -0400 MIME-Version: 1.0 In-Reply-To: <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> References: <1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org> <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> From: Rob Herring Date: Tue, 22 Mar 2016 06:15:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/6] of/serial: move earlycon early_param handling to serial To: Aleksey Makarov Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Len Brown , "linux-serial@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , Leif Lindholm , Graeme Gregory , Al Stone , Christopher Covington , Yury Norov , Peter Hurley , "Zheng, Lv" , Frank Rowand , Grant Likely , Jiri Slaby , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2016 at 5:46 AM, Aleksey Makarov wrote: > From: Leif Lindholm > > We have multiple "earlycon" early_param handlers - merge the DT one into > the main earlycon one. It's a cleanup that also will be useful > to decide if ACPI SPCR earlycon should be set up. How so? Isn't that determined by whether we have ACPI tables or a DT? This goes against trying to limit places of FDT parsing and keeping the early scanning all within fdt.c. At least it is not in the arch code. That said, I'm okay with this change if it helps. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh+dt@kernel.org (Rob Herring) Date: Tue, 22 Mar 2016 06:15:10 -0500 Subject: [PATCH v5 1/6] of/serial: move earlycon early_param handling to serial In-Reply-To: <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> References: <1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org> <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 22, 2016 at 5:46 AM, Aleksey Makarov wrote: > From: Leif Lindholm > > We have multiple "earlycon" early_param handlers - merge the DT one into > the main earlycon one. It's a cleanup that also will be useful > to decide if ACPI SPCR earlycon should be set up. How so? Isn't that determined by whether we have ACPI tables or a DT? This goes against trying to limit places of FDT parsing and keeping the early scanning all within fdt.c. At least it is not in the arch code. That said, I'm okay with this change if it helps. Rob