From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC6CC433DF for ; Tue, 18 Aug 2020 14:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C68C520786 for ; Tue, 18 Aug 2020 14:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597760637; bh=+GOujhHAY+gAEigj74Monf6Mzd+lgkl+g0F3Tv3WS8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=xba1Hd/c6fRGX9DWrlN3k5UME6ehcjuhly0nfF67OvibGSiKG5YWAKLgc1qPJtEiT LxNJBXYolfo4CgrncOJUSD3GSw6dWuWJackaR4+qkDPnfEE2uIUAsiaVPfTpOcccH3 mCMYs99dmQbm2a9JGNIaD3jfikZza05Uq+lR7lt0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgHROXy (ORCPT ); Tue, 18 Aug 2020 10:23:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:34414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbgHROXg (ORCPT ); Tue, 18 Aug 2020 10:23:36 -0400 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0585220786; Tue, 18 Aug 2020 14:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597760616; bh=+GOujhHAY+gAEigj74Monf6Mzd+lgkl+g0F3Tv3WS8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=URvpGZeB90KNMmrakNX0199Z+p6eJK53RHlpKE8iE+cnXzL6kGjr0FV70wFlRDu0b +4iIc5cxrXz4PPqUbVLnwGreeJ9OPV2INoNFJYHssg+lFDduRK2D990Zji5oSQG8mm r73S8S0ktI7fb8elJGj03MMRXYlceUxXz4PW8kQw= Received: by mail-oo1-f48.google.com with SMTP id z11so4182621oon.5; Tue, 18 Aug 2020 07:23:35 -0700 (PDT) X-Gm-Message-State: AOAM532MU8Uw9JQfb3/Z+jyhuluhrppxh35Y7A2apLxlVPNynDVSzc5b aVfBw+t9S+d0grKESJiVEMRxgGFjBvknJl63jA== X-Google-Smtp-Source: ABdhPJx/OxIxzT0i2pOqWVTEd+J0VZRhMCUcmr0cGzPYOXpagNM4BQrXXTT1e4HT0/tDAhSgVCFIOUZ0yyBT/uxJqAc= X-Received: by 2002:a4a:a60a:: with SMTP id e10mr15069228oom.25.1597760615266; Tue, 18 Aug 2020 07:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20200815125112.462652-2-maz@kernel.org> <20200815232228.GA1325245@bjorn-Precision-5520> <87pn7qnabq.wl-maz@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 18 Aug 2020 08:23:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT To: Marc Zyngier Cc: Bjorn Helgaas , PCI , "open list:ARM/Rockchip SoC..." , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , Lorenzo Pieralisi , Heiko Stuebner , Shawn Lin , Bjorn Helgaas , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > > On 2020-08-17 17:12, Rob Herring wrote: > > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> > >> On Sun, 16 Aug 2020 00:22:28 +0100, > >> Bjorn Helgaas wrote: > >> > > >> > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > >> > > Recent changes to the DT PCI bus parsing made it mandatory for > >> > > device tree nodes describing a PCI controller to have the > >> > > 'device_type = "pci"' property for the node to be matched. > >> > > > >> > > Although this follows the letter of the specification, it > >> > > breaks existing device-trees that have been working fine > >> > > for years. Rockchip rk3399-based systems are a prime example > >> > > of such collateral damage, and have stopped discovering their > >> > > PCI bus. > >> > > > >> > > In order to paper over the blunder, let's add a workaround > >> > > to the pcie-rockchip driver, adding the missing property when > >> > > none is found at boot time. A warning will hopefully nudge the > >> > > user into updating their DT to a fixed version if they can, but > >> > > the insentive is obviously pretty small. > >> > > >> > s/insentive/incentive/ (Lorenzo or I can fix this up) > >> > > >> > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser") > >> > > Suggested-by: Roh Herring > >> > > >> > s/Roh/Rob/ (similarly) > >> > >> Clearly not my day when it comes to proofreading commit messages. > >> Thanks for pointing this out, and in advance for fixing it up. > >> > >> > > >> > > Signed-off-by: Marc Zyngier > >> > > >> > This looks like a candidate for v5.9, since 2f96593ecc37 was merged > >> > during the v5.9 merge window, right? > >> > >> Absolutely. > >> > >> > I wonder how many other DTs are similarly broken? Maybe Rob's DT > >> > checker has already looked? > >> > >> I've just managed to run the checker, which comes up with all kinds of > >> goodies. Apart from the above, it also spots the following: > >> > >> - arch/arm64/boot/dts/mediatek/mt7622.dtsi: Has a device_type property > >> in its main PCIe node, but not in the child nodes. It isn't obvious > >> to me whether that's a violation or not (the spec doesn't say > >> whether the property should be set on a per-port basis). Rob? > > > > The rule is bridge nodes should have 'device_type = "pci"'. But what's > > needed to fix these cases is setting device_type where we are parsing > > ranges or dma-ranges which we're not doing on the child ndes. > > Otherwise, I don't think it matters in this case unless you have child > > (grandchild here) nodes for PCI devices. If you did have child nodes, > > the address translation was already broken before this change. > > Fair enough. > > >> - arch/arm64/boot/dts/qcom/msm8996.dtsi: Only one out of the three > >> PCIe nodes has the device_type property, probably broken similarly > >> to rk3399. > > > > The only upstream board is DB820c, so probably not as wide an impact... > > > > There are also 92 (lots of duplicates due to multiple boards) more > > cases in arch/arm/. A log is here[1]. > > Mostly Broadcom stuff, apparently. I'll see if I can have a stab > at it (although someone will have to test it). > > > > >> I could move the workaround to drivers/pci/of.c, and have it called > >> from the individual drivers. I don't have the HW to test those though. > >> > >> Thoughts? > > > > I think we should go with my other suggestion of looking at the node > > name. Looks like just checking 'pcie' is enough. We can skip 'pci' as > > I don't see any cases. > > I really dislike it. > > Once we put this node name matching in, there is no incentive for > people to write their DT correctly at all. It also sound pretty > fragile (what if the PCIe node is named something else?). That would require 2 wrongs. Both missing device_type and wrong node name. You could still warn if we matched on node name. This is just one possible error out of thousands. It's not the kernel's job to validate DTs (if it is, we're doing a horrible job). We have a solution for this with schema. The question is how to get to the point the schema checks are part of the main build flow. The primary issue is just getting to some platforms being warning free, and then they could opt in. There's effort around some platforms (Rockchip is not one), but I think we have a ways to go. The other aspect is what's the coverage with the schema. There's 2900 remaining bindings to convert to schema. We're doing about 100-200 a cycle, so that's what the next ~5 years looks like for me. :( > My preference goes towards having point fixes in the affected drivers, > clearly showing that this is addressing a firmware bug. I didn't filter down how many drivers all the failures equates to in terms of drivers. I guess all of Broadcom is just one. If you want to fixup all the drivers, then I'm fine with that. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55084C433DF for ; Tue, 18 Aug 2020 14:23:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22EBF20786 for ; Tue, 18 Aug 2020 14:23:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FWpiT+cl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="URvpGZeB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22EBF20786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dPsURATiQQRmP3iKDhR0xNMeHGKY6JyZrUWV8dxSMhU=; b=FWpiT+cl8Ym1roZHAC41SXAn7 suWJvqZOY4N4w1OOB0TVZ+mW/nKmAaa+QMu0bZj4N4okdL61vrH80q0PpLzVGzSQiimBc2XKaEyBM gSyIuBn+M7kyrfL1qI61lWV7Oxe13D4PYoll+EZi+U/AFmJzOdSqhvt3dHOliYTp8Txnh8Z9SZjMr dFjIT1BQWmiXDxxyjRYvsfXVyy6sTJcoQs/jL30rJHc1Nlj4bL8JlDASd+O3qbb7aCzhM9cjS930j CEOrWYrPWhyUcI1Hppdf4jNCAK7m4gwAyu7w3nT2jE5KvWJwS/kEg9CJrp5IvUAfJK3galM7dKgfP +VMqKUoDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k82We-00042V-GZ; Tue, 18 Aug 2020 14:23:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k82WX-00040I-Gg; Tue, 18 Aug 2020 14:23:38 +0000 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07BA1207D3; Tue, 18 Aug 2020 14:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597760616; bh=+GOujhHAY+gAEigj74Monf6Mzd+lgkl+g0F3Tv3WS8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=URvpGZeB90KNMmrakNX0199Z+p6eJK53RHlpKE8iE+cnXzL6kGjr0FV70wFlRDu0b +4iIc5cxrXz4PPqUbVLnwGreeJ9OPV2INoNFJYHssg+lFDduRK2D990Zji5oSQG8mm r73S8S0ktI7fb8elJGj03MMRXYlceUxXz4PW8kQw= Received: by mail-oo1-f49.google.com with SMTP id y30so4177476ooj.3; Tue, 18 Aug 2020 07:23:36 -0700 (PDT) X-Gm-Message-State: AOAM531dv64kIpqOlBhK7HsL33zqMriCqI62OJyIcdnFkBd3RAgPppR8 LICLJyZkxHWJMGgvLawkco0fb7xeUTEYav6cfw== X-Google-Smtp-Source: ABdhPJx/OxIxzT0i2pOqWVTEd+J0VZRhMCUcmr0cGzPYOXpagNM4BQrXXTT1e4HT0/tDAhSgVCFIOUZ0yyBT/uxJqAc= X-Received: by 2002:a4a:a60a:: with SMTP id e10mr15069228oom.25.1597760615266; Tue, 18 Aug 2020 07:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20200815125112.462652-2-maz@kernel.org> <20200815232228.GA1325245@bjorn-Precision-5520> <87pn7qnabq.wl-maz@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 18 Aug 2020 08:23:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT To: Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_102337_727592_AFC7BAA0 X-CRM114-Status: GOOD ( 45.48 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Heiko Stuebner , PCI , Shawn Lin , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Bjorn Helgaas , Bjorn Helgaas , Android Kernel Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > > On 2020-08-17 17:12, Rob Herring wrote: > > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> > >> On Sun, 16 Aug 2020 00:22:28 +0100, > >> Bjorn Helgaas wrote: > >> > > >> > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > >> > > Recent changes to the DT PCI bus parsing made it mandatory for > >> > > device tree nodes describing a PCI controller to have the > >> > > 'device_type = "pci"' property for the node to be matched. > >> > > > >> > > Although this follows the letter of the specification, it > >> > > breaks existing device-trees that have been working fine > >> > > for years. Rockchip rk3399-based systems are a prime example > >> > > of such collateral damage, and have stopped discovering their > >> > > PCI bus. > >> > > > >> > > In order to paper over the blunder, let's add a workaround > >> > > to the pcie-rockchip driver, adding the missing property when > >> > > none is found at boot time. A warning will hopefully nudge the > >> > > user into updating their DT to a fixed version if they can, but > >> > > the insentive is obviously pretty small. > >> > > >> > s/insentive/incentive/ (Lorenzo or I can fix this up) > >> > > >> > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser") > >> > > Suggested-by: Roh Herring > >> > > >> > s/Roh/Rob/ (similarly) > >> > >> Clearly not my day when it comes to proofreading commit messages. > >> Thanks for pointing this out, and in advance for fixing it up. > >> > >> > > >> > > Signed-off-by: Marc Zyngier > >> > > >> > This looks like a candidate for v5.9, since 2f96593ecc37 was merged > >> > during the v5.9 merge window, right? > >> > >> Absolutely. > >> > >> > I wonder how many other DTs are similarly broken? Maybe Rob's DT > >> > checker has already looked? > >> > >> I've just managed to run the checker, which comes up with all kinds of > >> goodies. Apart from the above, it also spots the following: > >> > >> - arch/arm64/boot/dts/mediatek/mt7622.dtsi: Has a device_type property > >> in its main PCIe node, but not in the child nodes. It isn't obvious > >> to me whether that's a violation or not (the spec doesn't say > >> whether the property should be set on a per-port basis). Rob? > > > > The rule is bridge nodes should have 'device_type = "pci"'. But what's > > needed to fix these cases is setting device_type where we are parsing > > ranges or dma-ranges which we're not doing on the child ndes. > > Otherwise, I don't think it matters in this case unless you have child > > (grandchild here) nodes for PCI devices. If you did have child nodes, > > the address translation was already broken before this change. > > Fair enough. > > >> - arch/arm64/boot/dts/qcom/msm8996.dtsi: Only one out of the three > >> PCIe nodes has the device_type property, probably broken similarly > >> to rk3399. > > > > The only upstream board is DB820c, so probably not as wide an impact... > > > > There are also 92 (lots of duplicates due to multiple boards) more > > cases in arch/arm/. A log is here[1]. > > Mostly Broadcom stuff, apparently. I'll see if I can have a stab > at it (although someone will have to test it). > > > > >> I could move the workaround to drivers/pci/of.c, and have it called > >> from the individual drivers. I don't have the HW to test those though. > >> > >> Thoughts? > > > > I think we should go with my other suggestion of looking at the node > > name. Looks like just checking 'pcie' is enough. We can skip 'pci' as > > I don't see any cases. > > I really dislike it. > > Once we put this node name matching in, there is no incentive for > people to write their DT correctly at all. It also sound pretty > fragile (what if the PCIe node is named something else?). That would require 2 wrongs. Both missing device_type and wrong node name. You could still warn if we matched on node name. This is just one possible error out of thousands. It's not the kernel's job to validate DTs (if it is, we're doing a horrible job). We have a solution for this with schema. The question is how to get to the point the schema checks are part of the main build flow. The primary issue is just getting to some platforms being warning free, and then they could opt in. There's effort around some platforms (Rockchip is not one), but I think we have a ways to go. The other aspect is what's the coverage with the schema. There's 2900 remaining bindings to convert to schema. We're doing about 100-200 a cycle, so that's what the next ~5 years looks like for me. :( > My preference goes towards having point fixes in the affected drivers, > clearly showing that this is addressing a firmware bug. I didn't filter down how many drivers all the failures equates to in terms of drivers. I guess all of Broadcom is just one. If you want to fixup all the drivers, then I'm fine with that. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127FFC433DF for ; Tue, 18 Aug 2020 14:25:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D96B420786 for ; Tue, 18 Aug 2020 14:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nr49BnWv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="URvpGZeB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D96B420786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TWUZx3Rprm+3/9Gt7nb6yBSkaopYV5gsoZow8AHJp1M=; b=nr49BnWvenWV6CtFQYAK2W0EV 4XscYxbIiVVM/WOlMh+1AQ8YHyOHrtanRPAP8VREJkcdbC7aIw7v0/PSY7QlBfFy8sgUjJEv6AQZ2 Fl4DNf7Qi6qTl3MwOzMbTqjO011jEgnb2MiSoMn4OZTnxgEVp46OOqUrZToTH46G0kCYylqa4vaCN CCLaAvMedMtnXB1E417X6ig9PauGhz1Tpyf/aawjHdp3ubc+RyGJzRrmlGpEmBuAoJBrft7u5sT+5 lP6YsAXNxGQNUzDc/yNQFRdrPa+8sLFIIAJmD9jkL6VRQ01ot7sGjGbPskTOUku4/jcTNucppE4EH eaAcHF0Qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k82Wa-00041b-Pl; Tue, 18 Aug 2020 14:23:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k82WX-00040I-Gg; Tue, 18 Aug 2020 14:23:38 +0000 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07BA1207D3; Tue, 18 Aug 2020 14:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597760616; bh=+GOujhHAY+gAEigj74Monf6Mzd+lgkl+g0F3Tv3WS8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=URvpGZeB90KNMmrakNX0199Z+p6eJK53RHlpKE8iE+cnXzL6kGjr0FV70wFlRDu0b +4iIc5cxrXz4PPqUbVLnwGreeJ9OPV2INoNFJYHssg+lFDduRK2D990Zji5oSQG8mm r73S8S0ktI7fb8elJGj03MMRXYlceUxXz4PW8kQw= Received: by mail-oo1-f49.google.com with SMTP id y30so4177476ooj.3; Tue, 18 Aug 2020 07:23:36 -0700 (PDT) X-Gm-Message-State: AOAM531dv64kIpqOlBhK7HsL33zqMriCqI62OJyIcdnFkBd3RAgPppR8 LICLJyZkxHWJMGgvLawkco0fb7xeUTEYav6cfw== X-Google-Smtp-Source: ABdhPJx/OxIxzT0i2pOqWVTEd+J0VZRhMCUcmr0cGzPYOXpagNM4BQrXXTT1e4HT0/tDAhSgVCFIOUZ0yyBT/uxJqAc= X-Received: by 2002:a4a:a60a:: with SMTP id e10mr15069228oom.25.1597760615266; Tue, 18 Aug 2020 07:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20200815125112.462652-2-maz@kernel.org> <20200815232228.GA1325245@bjorn-Precision-5520> <87pn7qnabq.wl-maz@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 18 Aug 2020 08:23:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT To: Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_102337_727592_AFC7BAA0 X-CRM114-Status: GOOD ( 45.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Heiko Stuebner , PCI , Shawn Lin , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Bjorn Helgaas , Bjorn Helgaas , Android Kernel Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > > On 2020-08-17 17:12, Rob Herring wrote: > > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> > >> On Sun, 16 Aug 2020 00:22:28 +0100, > >> Bjorn Helgaas wrote: > >> > > >> > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > >> > > Recent changes to the DT PCI bus parsing made it mandatory for > >> > > device tree nodes describing a PCI controller to have the > >> > > 'device_type = "pci"' property for the node to be matched. > >> > > > >> > > Although this follows the letter of the specification, it > >> > > breaks existing device-trees that have been working fine > >> > > for years. Rockchip rk3399-based systems are a prime example > >> > > of such collateral damage, and have stopped discovering their > >> > > PCI bus. > >> > > > >> > > In order to paper over the blunder, let's add a workaround > >> > > to the pcie-rockchip driver, adding the missing property when > >> > > none is found at boot time. A warning will hopefully nudge the > >> > > user into updating their DT to a fixed version if they can, but > >> > > the insentive is obviously pretty small. > >> > > >> > s/insentive/incentive/ (Lorenzo or I can fix this up) > >> > > >> > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser") > >> > > Suggested-by: Roh Herring > >> > > >> > s/Roh/Rob/ (similarly) > >> > >> Clearly not my day when it comes to proofreading commit messages. > >> Thanks for pointing this out, and in advance for fixing it up. > >> > >> > > >> > > Signed-off-by: Marc Zyngier > >> > > >> > This looks like a candidate for v5.9, since 2f96593ecc37 was merged > >> > during the v5.9 merge window, right? > >> > >> Absolutely. > >> > >> > I wonder how many other DTs are similarly broken? Maybe Rob's DT > >> > checker has already looked? > >> > >> I've just managed to run the checker, which comes up with all kinds of > >> goodies. Apart from the above, it also spots the following: > >> > >> - arch/arm64/boot/dts/mediatek/mt7622.dtsi: Has a device_type property > >> in its main PCIe node, but not in the child nodes. It isn't obvious > >> to me whether that's a violation or not (the spec doesn't say > >> whether the property should be set on a per-port basis). Rob? > > > > The rule is bridge nodes should have 'device_type = "pci"'. But what's > > needed to fix these cases is setting device_type where we are parsing > > ranges or dma-ranges which we're not doing on the child ndes. > > Otherwise, I don't think it matters in this case unless you have child > > (grandchild here) nodes for PCI devices. If you did have child nodes, > > the address translation was already broken before this change. > > Fair enough. > > >> - arch/arm64/boot/dts/qcom/msm8996.dtsi: Only one out of the three > >> PCIe nodes has the device_type property, probably broken similarly > >> to rk3399. > > > > The only upstream board is DB820c, so probably not as wide an impact... > > > > There are also 92 (lots of duplicates due to multiple boards) more > > cases in arch/arm/. A log is here[1]. > > Mostly Broadcom stuff, apparently. I'll see if I can have a stab > at it (although someone will have to test it). > > > > >> I could move the workaround to drivers/pci/of.c, and have it called > >> from the individual drivers. I don't have the HW to test those though. > >> > >> Thoughts? > > > > I think we should go with my other suggestion of looking at the node > > name. Looks like just checking 'pcie' is enough. We can skip 'pci' as > > I don't see any cases. > > I really dislike it. > > Once we put this node name matching in, there is no incentive for > people to write their DT correctly at all. It also sound pretty > fragile (what if the PCIe node is named something else?). That would require 2 wrongs. Both missing device_type and wrong node name. You could still warn if we matched on node name. This is just one possible error out of thousands. It's not the kernel's job to validate DTs (if it is, we're doing a horrible job). We have a solution for this with schema. The question is how to get to the point the schema checks are part of the main build flow. The primary issue is just getting to some platforms being warning free, and then they could opt in. There's effort around some platforms (Rockchip is not one), but I think we have a ways to go. The other aspect is what's the coverage with the schema. There's 2900 remaining bindings to convert to schema. We're doing about 100-200 a cycle, so that's what the next ~5 years looks like for me. :( > My preference goes towards having point fixes in the affected drivers, > clearly showing that this is addressing a firmware bug. I didn't filter down how many drivers all the failures equates to in terms of drivers. I guess all of Broadcom is just one. If you want to fixup all the drivers, then I'm fine with that. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel