All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"MTD Maling List" <linux-mtd@lists.infradead.org>,
	devicetree@vger.kernel.org,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh R" <vigneshr@ti.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Brendan Higgins" <brendanhiggins@google.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Anders Roxell" <anders.roxell@linaro.org>,
	"Mason Yang" <masonccyang@mxic.com.tw>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	"hauke.mehrtens" <hauke.mehrtens@intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	qi-ming.wu@intel.com, cheol.yong.kim@intel.com
Subject: Re: [PATCH v6 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC
Date: Mon, 18 May 2020 12:24:31 -0600	[thread overview]
Message-ID: <CAL_JsqL3g-QYMF0PMSuHeoaZ5x88fg4TbzVbDUO6=ugxEZRpbQ@mail.gmail.com> (raw)
In-Reply-To: <3248d380-1d08-3088-8d18-0373a8a5aef9@linux.intel.com>

On Thu, May 14, 2020 at 8:06 PM Ramuthevar, Vadivel MuruganX
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
> Hi Rob,
>
>     Thank you for the review comments...
>
> On 14/5/2020 9:03 pm, Rob Herring wrote:
> > On Wed, May 13, 2020 at 06:46:14PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >>
> >> Add YAML file for dt-bindings to support NAND Flash Controller
> >> on Intel's Lightning Mountain SoC.
> >>
> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >> ---
> >>   .../devicetree/bindings/mtd/intel,lgm-nand.yaml    | 83 ++++++++++++++++++++++
> >>   1 file changed, 83 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml

> >> +      clocks = <&cgu0 125>;
> >> +      dma-names = "tx", "rx";
> >> +      #address-cells = <1>;
> >> +      #size-cells = <0>;
> >> +      #clock-cells = <1>;
> >
> > This is a clock provider too?
> Yes, it is getting clock from CGU for nand-controller.

That is a clock client (e.g. 'clocks' property), not a provider. The
CGU is the provider.

Rob

WARNING: multiple messages have this Message-ID
From: Rob Herring <robh@kernel.org>
To: "Ramuthevar,
	Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: cheol.yong.kim@intel.com, devicetree@vger.kernel.org,
	qi-ming.wu@intel.com, "Anders Roxell" <anders.roxell@linaro.org>,
	"Vignesh R" <vigneshr@ti.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"hauke.mehrtens" <hauke.mehrtens@intel.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Brendan Higgins" <brendanhiggins@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"MTD Maling List" <linux-mtd@lists.infradead.org>,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Mason Yang" <masonccyang@mxic.com.tw>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC
Date: Mon, 18 May 2020 12:24:31 -0600	[thread overview]
Message-ID: <CAL_JsqL3g-QYMF0PMSuHeoaZ5x88fg4TbzVbDUO6=ugxEZRpbQ@mail.gmail.com> (raw)
In-Reply-To: <3248d380-1d08-3088-8d18-0373a8a5aef9@linux.intel.com>

On Thu, May 14, 2020 at 8:06 PM Ramuthevar, Vadivel MuruganX
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
> Hi Rob,
>
>     Thank you for the review comments...
>
> On 14/5/2020 9:03 pm, Rob Herring wrote:
> > On Wed, May 13, 2020 at 06:46:14PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >>
> >> Add YAML file for dt-bindings to support NAND Flash Controller
> >> on Intel's Lightning Mountain SoC.
> >>
> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >> ---
> >>   .../devicetree/bindings/mtd/intel,lgm-nand.yaml    | 83 ++++++++++++++++++++++
> >>   1 file changed, 83 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml

> >> +      clocks = <&cgu0 125>;
> >> +      dma-names = "tx", "rx";
> >> +      #address-cells = <1>;
> >> +      #size-cells = <0>;
> >> +      #clock-cells = <1>;
> >
> > This is a clock provider too?
> Yes, it is getting clock from CGU for nand-controller.

That is a clock client (e.g. 'clocks' property), not a provider. The
CGU is the provider.

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-05-18 18:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 10:46 [PATCH v6 0/2] mtd: rawnand: Add NAND controller support on " Ramuthevar,Vadivel MuruganX
2020-05-13 10:46 ` Ramuthevar, Vadivel MuruganX
2020-05-13 10:46 ` [PATCH v6 1/2] dt-bindings: mtd: Add Nand Flash Controller support for " Ramuthevar,Vadivel MuruganX
2020-05-13 10:46   ` Ramuthevar, Vadivel MuruganX
2020-05-14 12:57   ` Rob Herring
2020-05-14 12:57     ` Rob Herring
2020-05-15  2:08     ` Ramuthevar, Vadivel MuruganX
2020-05-15  2:08       ` Ramuthevar, Vadivel MuruganX
2020-05-15  8:06       ` Ramuthevar, Vadivel MuruganX
2020-05-15  8:06         ` Ramuthevar, Vadivel MuruganX
2020-05-18 18:27       ` Rob Herring
2020-05-18 18:27         ` Rob Herring
2020-05-19  4:51         ` Ramuthevar, Vadivel MuruganX
2020-05-19  4:51           ` Ramuthevar, Vadivel MuruganX
2020-05-14 13:03   ` Rob Herring
2020-05-14 13:03     ` Rob Herring
2020-05-15  2:06     ` Ramuthevar, Vadivel MuruganX
2020-05-15  2:06       ` Ramuthevar, Vadivel MuruganX
2020-05-18 18:24       ` Rob Herring [this message]
2020-05-18 18:24         ` Rob Herring
2020-05-13 10:46 ` [PATCH v6 2/2] mtd: rawnand: Add NAND controller support on " Ramuthevar,Vadivel MuruganX
2020-05-13 10:46   ` Ramuthevar, Vadivel MuruganX
2020-05-13 15:34   ` Andy Shevchenko
2020-05-13 15:34     ` Andy Shevchenko
2020-05-13 15:35     ` Andy Shevchenko
2020-05-13 15:35       ` Andy Shevchenko
2020-05-14  1:04       ` Ramuthevar, Vadivel MuruganX
2020-05-14  1:04         ` Ramuthevar, Vadivel MuruganX
2020-05-14  1:02     ` Ramuthevar, Vadivel MuruganX
2020-05-14  1:02       ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqL3g-QYMF0PMSuHeoaZ5x88fg4TbzVbDUO6=ugxEZRpbQ@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@collabora.com \
    --cc=brendanhiggins@google.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke.mehrtens@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=qi-ming.wu@intel.com \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    --subject='Re: [PATCH v6 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.