From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B34C433F5 for ; Mon, 27 Sep 2021 14:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAFF4604DC for ; Mon, 27 Sep 2021 14:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234918AbhI0OvW (ORCPT ); Mon, 27 Sep 2021 10:51:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:48048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234819AbhI0OvV (ORCPT ); Mon, 27 Sep 2021 10:51:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 526FB60FC2; Mon, 27 Sep 2021 14:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632754183; bh=nlm+GXqBOJFgPGuqH4ktEyVp0rZXsByzVCpaKGKn9Pw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CtSY0hs0nhLxHyr6ErsvWuAR1cv3yUK5t2GqYnY79ud/jOLtgMBvrFATh1DTQk5Wr emdDTnPAPoArKZsQl3de5W+/e+Ei/O8rV7O0zRGuu/hG2q+3r5n400glzNY3fMncfY bSsFfTIP/pPxAJ9T2baDtHFfCMU6qXpUwXfEghNuIyrGlhOP79telufsEH0MrhRfuR Uon1rEsEJDFbGdqfsvYSUDQgTmmfQCqiOuqp47yPXAUHLS0DodF2zvxGFADDNU45P8 6QyNaDEy01x74UUZCCMh3Joul+V3W09gvDMPW/qq0YTwZdYKRkrNasv7R6CLNsnUDn QI/RyzqUaefig== Received: by mail-ed1-f44.google.com with SMTP id v18so35111970edc.11; Mon, 27 Sep 2021 07:49:43 -0700 (PDT) X-Gm-Message-State: AOAM531Ko2UvvAP8b06FLyk0UhnaNVgl9vvAEyNyBWdA5Sj4GRWIZbjy aGjFR69yOPiCNg6h5FCCDiJakN4BsikI+46fag== X-Google-Smtp-Source: ABdhPJwAdi6VamHHELYSAbPUEIJOXg9VYm6jMbUqTQD67z8h2BqyDUn/kOFm4ji2hkz/vqnJ2ZIn0ddX0WT5DJGrUCg= X-Received: by 2002:a17:906:7250:: with SMTP id n16mr449630ejk.147.1632754181882; Mon, 27 Sep 2021 07:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20210927064119.127285-1-gshan@redhat.com> <20210927064119.127285-3-gshan@redhat.com> In-Reply-To: <20210927064119.127285-3-gshan@redhat.com> From: Rob Herring Date: Mon, 27 Sep 2021 09:49:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map To: Gavin Shan Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-efi , linux-arm-kernel , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Marc Zyngier , Randy Dunlap , Catalin Marinas , Will Deacon , shan.gavin@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2021 at 1:42 AM Gavin Shan wrote: > > There is no device node for the empty NUMA node. However, the > corresponding NUMA node ID and distance map is still valid in > "numa-distance-map-v1" compatible device node. > > This fetches the NUMA node ID and distance map for these empty > NUMA node from "numa-distance-map-v1" compatible device node. This is much nicer. > Signed-off-by: Gavin Shan > --- > drivers/of/of_numa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index fe6b13608e51..5949829a1b00 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -111,6 +111,8 @@ static int __init of_numa_parse_distance_map_v1(struct device_node *map) > return -EINVAL; > } > > + node_set(nodea, numa_nodes_parsed); > + With this, couldn't we remove of_numa_parse_cpu_nodes() as the only thing it does is node_set()? > numa_set_distance(nodea, nodeb, distance); > > /* Set default distance of node B->A same as A->B */ > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8378C433F5 for ; Mon, 27 Sep 2021 14:49:48 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 6601360FD7 for ; Mon, 27 Sep 2021 14:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6601360FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B01074A524; Mon, 27 Sep 2021 10:49:47 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NNK-Nc11YMV6; Mon, 27 Sep 2021 10:49:46 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A16474A534; Mon, 27 Sep 2021 10:49:46 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4AEB64A524 for ; Mon, 27 Sep 2021 10:49:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FYuuZg4VhUfN for ; Mon, 27 Sep 2021 10:49:44 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 5B3944A1B0 for ; Mon, 27 Sep 2021 10:49:44 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 48EAA60FED for ; Mon, 27 Sep 2021 14:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632754183; bh=nlm+GXqBOJFgPGuqH4ktEyVp0rZXsByzVCpaKGKn9Pw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CtSY0hs0nhLxHyr6ErsvWuAR1cv3yUK5t2GqYnY79ud/jOLtgMBvrFATh1DTQk5Wr emdDTnPAPoArKZsQl3de5W+/e+Ei/O8rV7O0zRGuu/hG2q+3r5n400glzNY3fMncfY bSsFfTIP/pPxAJ9T2baDtHFfCMU6qXpUwXfEghNuIyrGlhOP79telufsEH0MrhRfuR Uon1rEsEJDFbGdqfsvYSUDQgTmmfQCqiOuqp47yPXAUHLS0DodF2zvxGFADDNU45P8 6QyNaDEy01x74UUZCCMh3Joul+V3W09gvDMPW/qq0YTwZdYKRkrNasv7R6CLNsnUDn QI/RyzqUaefig== Received: by mail-ed1-f50.google.com with SMTP id g7so10896145edv.1 for ; Mon, 27 Sep 2021 07:49:43 -0700 (PDT) X-Gm-Message-State: AOAM533B89LH6hqWaF5JDF7RIBCGe6mJ1Naf7Y1REQZ+Ld+p6rNf4neS T/+se0UbmvKR6xN686+M43/XuwzkKU5w6m7vZg== X-Google-Smtp-Source: ABdhPJwAdi6VamHHELYSAbPUEIJOXg9VYm6jMbUqTQD67z8h2BqyDUn/kOFm4ji2hkz/vqnJ2ZIn0ddX0WT5DJGrUCg= X-Received: by 2002:a17:906:7250:: with SMTP id n16mr449630ejk.147.1632754181882; Mon, 27 Sep 2021 07:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20210927064119.127285-1-gshan@redhat.com> <20210927064119.127285-3-gshan@redhat.com> In-Reply-To: <20210927064119.127285-3-gshan@redhat.com> From: Rob Herring Date: Mon, 27 Sep 2021 09:49:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map To: Gavin Shan Cc: devicetree@vger.kernel.org, linux-efi , Marc Zyngier , Randy Dunlap , "linux-kernel@vger.kernel.org" , shan.gavin@gmail.com, Catalin Marinas , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , linux-arm-kernel X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Sep 27, 2021 at 1:42 AM Gavin Shan wrote: > > There is no device node for the empty NUMA node. However, the > corresponding NUMA node ID and distance map is still valid in > "numa-distance-map-v1" compatible device node. > > This fetches the NUMA node ID and distance map for these empty > NUMA node from "numa-distance-map-v1" compatible device node. This is much nicer. > Signed-off-by: Gavin Shan > --- > drivers/of/of_numa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index fe6b13608e51..5949829a1b00 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -111,6 +111,8 @@ static int __init of_numa_parse_distance_map_v1(struct device_node *map) > return -EINVAL; > } > > + node_set(nodea, numa_nodes_parsed); > + With this, couldn't we remove of_numa_parse_cpu_nodes() as the only thing it does is node_set()? > numa_set_distance(nodea, nodeb, distance); > > /* Set default distance of node B->A same as A->B */ > -- > 2.23.0 > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7830C433EF for ; Mon, 27 Sep 2021 14:51:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B52260FC2 for ; Mon, 27 Sep 2021 14:51:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B52260FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Dl65N4nwelE1pu2y3pVoVXADZ198utzZi7Owv7ZEjk=; b=elKaYEEHXFdlkx cZvSpJ2+EWInpg0zwplZR4YpuQ1Wpkg2nPn6/TmeQRt/qju/tURQ+X/gCxWdDjI0RSxCwNbprQqw5 GL7keZrXHceDd80RDYIbxTY9cOWrOL2dr1W9hl/BXxB7MbNkcjcjPWgfr/oKurIrecWBaeJ0kdrHy yEUIW24M6PdJK5BMehD8yHAE9SoDy2ojJAv6qfQUe6d1XI8p9L1GNozFjBFMMTRTz4Qu3lZxCGw/j D62F3U/Ht06olm/Df9OQzlZp/2DgrIjDdGkx5Pf6KaCaWCgzvJMTQZ/RC506PiL79NqKcYVda4BM5 K9/eHY8T9dtEIsQmZu+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUrwy-002xME-JN; Mon, 27 Sep 2021 14:49:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUrwu-002xLH-JR for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 14:49:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 53850604DC for ; Mon, 27 Sep 2021 14:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632754184; bh=nlm+GXqBOJFgPGuqH4ktEyVp0rZXsByzVCpaKGKn9Pw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XEb7miTd9Niw4d0Cdc2eoX9EwQwQmtV8fYAQLaP+BAfzohcQ0sKTbu2ZpnpJNQrcd q8HKiY83rK5nsTK08gNgshJ5417cBX9SP6EMxJn0/j+yT0BJRQ08mO+oBBek9uDeBF UfVdEdL62QcqDEXvDfN8RxPoNDd0QYLg8dNZ08F11tLgHat0euoVmw8uh0Z0bk2JTX lIfZNWSYCdMeHP9eDpQ7VTPFVrc0FHp96jLipkLs/60haRgCBlLoCZLBdiFvRie3+3 TeeULYH3FdLRQ3TZHUwLpXDfM5A7jmfLOCgGnhKrk8mZKa74NQR/33wHCLO6cLhPrC ahVAPQiIAunuw== Received: by mail-ed1-f48.google.com with SMTP id b26so21982887edt.0 for ; Mon, 27 Sep 2021 07:49:44 -0700 (PDT) X-Gm-Message-State: AOAM5334Z/XbHricw+Sau3RjESxvvOtXR4qkoF1B1J7fdP+o4xKE9C6B GyTTwUh4JRbjIi2OcxE/swPAkCEbjTKhluIJdQ== X-Google-Smtp-Source: ABdhPJwAdi6VamHHELYSAbPUEIJOXg9VYm6jMbUqTQD67z8h2BqyDUn/kOFm4ji2hkz/vqnJ2ZIn0ddX0WT5DJGrUCg= X-Received: by 2002:a17:906:7250:: with SMTP id n16mr449630ejk.147.1632754181882; Mon, 27 Sep 2021 07:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20210927064119.127285-1-gshan@redhat.com> <20210927064119.127285-3-gshan@redhat.com> In-Reply-To: <20210927064119.127285-3-gshan@redhat.com> From: Rob Herring Date: Mon, 27 Sep 2021 09:49:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map To: Gavin Shan Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-efi , linux-arm-kernel , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Marc Zyngier , Randy Dunlap , Catalin Marinas , Will Deacon , shan.gavin@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_074944_667166_89E18665 X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 27, 2021 at 1:42 AM Gavin Shan wrote: > > There is no device node for the empty NUMA node. However, the > corresponding NUMA node ID and distance map is still valid in > "numa-distance-map-v1" compatible device node. > > This fetches the NUMA node ID and distance map for these empty > NUMA node from "numa-distance-map-v1" compatible device node. This is much nicer. > Signed-off-by: Gavin Shan > --- > drivers/of/of_numa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index fe6b13608e51..5949829a1b00 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -111,6 +111,8 @@ static int __init of_numa_parse_distance_map_v1(struct device_node *map) > return -EINVAL; > } > > + node_set(nodea, numa_nodes_parsed); > + With this, couldn't we remove of_numa_parse_cpu_nodes() as the only thing it does is node_set()? > numa_set_distance(nodea, nodeb, distance); > > /* Set default distance of node B->A same as A->B */ > -- > 2.23.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel