From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbdJFWdU (ORCPT ); Fri, 6 Oct 2017 18:33:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:46406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdJFWdT (ORCPT ); Fri, 6 Oct 2017 18:33:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB5AF21908 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: AOwi7QAl1UCuGxYwZNdVsZAbdQLQP1RGI/R2+cxg4NrW4N4z1d+MpfldK7LYPT58BvUbDj/D+Bmwdl73Pfoq33n8vK8= MIME-Version: 1.0 In-Reply-To: <1504117946-3958-1-git-send-email-larturus2@gmail.com> References: <1504117946-3958-1-git-send-email-larturus2@gmail.com> From: Rob Herring Date: Fri, 6 Oct 2017 17:32:57 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] default implementation for of_find_all_nodes(...) To: Artur Lorincz Cc: Frank Rowand , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , larturus@yahoo.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 1:32 PM, Artur Lorincz wrote: > Added default implementation for of_find_all_nodes(). This function is > used by board.c from the board module (drivers/staging/board). Didn't even know we had this... The DT core already has some support for something like this with "auxdata" that lets you attach DT nodes to existing platform devices. Why doesn't that work? In any case, you should just make this code depend on CONFIG_OF. When there's only 3 other users of this function, that's a good sign we don't want more. Searching thru all nodes is generally not the right thing to do. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] default implementation for of_find_all_nodes(...) Date: Fri, 6 Oct 2017 17:32:57 -0500 Message-ID: References: <1504117946-3958-1-git-send-email-larturus2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1504117946-3958-1-git-send-email-larturus2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Artur Lorincz Cc: Frank Rowand , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , larturus-/E1597aS9LQAvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Aug 30, 2017 at 1:32 PM, Artur Lorincz wrote: > Added default implementation for of_find_all_nodes(). This function is > used by board.c from the board module (drivers/staging/board). Didn't even know we had this... The DT core already has some support for something like this with "auxdata" that lets you attach DT nodes to existing platform devices. Why doesn't that work? In any case, you should just make this code depend on CONFIG_OF. When there's only 3 other users of this function, that's a good sign we don't want more. Searching thru all nodes is generally not the right thing to do. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html