From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings Date: Fri, 27 Apr 2018 13:32:13 -0500 Message-ID: References: <20180426094606.4775-1-srinivas.kandagatla@linaro.org> <20180426094606.4775-5-srinivas.kandagatla@linaro.org> <20180427141323.2ykh676xpdf7b6bl@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Kandagatla Cc: Andy Gross , Mark Brown , linux-arm-msm , Linux-ALSA , Banajit Goswami , Greg Kroah-Hartman , David Brown , Mark Rutland , Liam Girdwood , Patrick Lai , Takashi Iwai , Jaroslav Kysela , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , rohkumar@qti.qualcomm.com, spatakok@qti.qualcomm.com List-Id: linux-arm-msm@vger.kernel.org On Fri, Apr 27, 2018 at 9:58 AM, Srinivas Kandagatla wrote: > Thanks for the review. > > > On 27/04/18 15:13, Rob Herring wrote: >> >> On Thu, Apr 26, 2018 at 10:45:46AM +0100, srinivas.kandagatla@linaro.org >> wrote: >>> >>> From: Srinivas Kandagatla >>> >>> This patch add DT bindings for AFE (Audio Frontend) DSP module. >>> >>> Signed-off-by: Srinivas Kandagatla >>> Reviewed-and-tested-by: Rohit kumar >>> --- >>> .../devicetree/bindings/sound/qcom,q6afe.txt | 88 >>> ++++++++++++++++++++++ >>> include/dt-bindings/sound/qcom,q6afe.h | 31 ++++++++ >>> 2 files changed, 119 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> create mode 100644 include/dt-bindings/sound/qcom,q6afe.h >>> >>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> new file mode 100644 >>> index 000000000000..05208a63dd3c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> @@ -0,0 +1,88 @@ >>> +Qualcomm Audio Front End (Q6AFE) binding >>> + >>> +AFE is one of the APR audio service on Q6DSP >>> +Please refer to qcom,apr.txt for details of the common apr service >>> bindings >>> +used by all apr services. >>> + >>> +- but must contain the following property: >>> + >>> +- compatible: >>> + Usage: required >>> + Value type: >>> + Definition: must be "qcom,q6afe-v." >>> + Or "qcom,q6afe" where the version number can be queried >>> + from DSP. >>> + example "qcom,q6afe" >> >> >> reg too. > > > I did not want to repeat what is already mandated for apr children in > qcom,apr.txt > So skipped repeating reg property in here. Okay. >>> + >>> += AFE DAIs (Digial Audio Interface) >>> +"dais" subnode of the AFE node represents dai specific configuration >>> + >>> +- #sound-dai-cells >>> + Usage: required >>> + Value type: >>> + Definition: Must be 1 >>> + >>> +- reg >> >> >> It's not clear here these are in a grandchild node. >> > Every afe port/dai has some board specifics, to allow that we need dai > specific child nodes. Yes, but what I mean is #sound-dai-cells is a property of the dais node, but reg and qcom,sd-lines are properties of child nodes under the dais node. It is evident in the example, but not without the example. Also, anywhere with reg needs #address-cells and #size-cells in the parent node. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Fri, 27 Apr 2018 13:32:13 -0500 Subject: [PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings In-Reply-To: References: <20180426094606.4775-1-srinivas.kandagatla@linaro.org> <20180426094606.4775-5-srinivas.kandagatla@linaro.org> <20180427141323.2ykh676xpdf7b6bl@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 27, 2018 at 9:58 AM, Srinivas Kandagatla wrote: > Thanks for the review. > > > On 27/04/18 15:13, Rob Herring wrote: >> >> On Thu, Apr 26, 2018 at 10:45:46AM +0100, srinivas.kandagatla at linaro.org >> wrote: >>> >>> From: Srinivas Kandagatla >>> >>> This patch add DT bindings for AFE (Audio Frontend) DSP module. >>> >>> Signed-off-by: Srinivas Kandagatla >>> Reviewed-and-tested-by: Rohit kumar >>> --- >>> .../devicetree/bindings/sound/qcom,q6afe.txt | 88 >>> ++++++++++++++++++++++ >>> include/dt-bindings/sound/qcom,q6afe.h | 31 ++++++++ >>> 2 files changed, 119 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> create mode 100644 include/dt-bindings/sound/qcom,q6afe.h >>> >>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> new file mode 100644 >>> index 000000000000..05208a63dd3c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >>> @@ -0,0 +1,88 @@ >>> +Qualcomm Audio Front End (Q6AFE) binding >>> + >>> +AFE is one of the APR audio service on Q6DSP >>> +Please refer to qcom,apr.txt for details of the common apr service >>> bindings >>> +used by all apr services. >>> + >>> +- but must contain the following property: >>> + >>> +- compatible: >>> + Usage: required >>> + Value type: >>> + Definition: must be "qcom,q6afe-v." >>> + Or "qcom,q6afe" where the version number can be queried >>> + from DSP. >>> + example "qcom,q6afe" >> >> >> reg too. > > > I did not want to repeat what is already mandated for apr children in > qcom,apr.txt > So skipped repeating reg property in here. Okay. >>> + >>> += AFE DAIs (Digial Audio Interface) >>> +"dais" subnode of the AFE node represents dai specific configuration >>> + >>> +- #sound-dai-cells >>> + Usage: required >>> + Value type: >>> + Definition: Must be 1 >>> + >>> +- reg >> >> >> It's not clear here these are in a grandchild node. >> > Every afe port/dai has some board specifics, to allow that we need dai > specific child nodes. Yes, but what I mean is #sound-dai-cells is a property of the dais node, but reg and qcom,sd-lines are properties of child nodes under the dais node. It is evident in the example, but not without the example. Also, anywhere with reg needs #address-cells and #size-cells in the parent node. Rob