From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA0AC4332B for ; Wed, 20 Jan 2021 14:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C82C123382 for ; Wed, 20 Jan 2021 14:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390651AbhATOca (ORCPT ); Wed, 20 Jan 2021 09:32:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:39318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728897AbhATOYz (ORCPT ); Wed, 20 Jan 2021 09:24:55 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E34523380; Wed, 20 Jan 2021 14:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611152653; bh=0Xtz3tkNSwsoY9gbgqE2qTK7eRaJcR+iJ9o+tD1IB+c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qkReOQiov9zXiYg96avLVaWfdyxpxanbJ1uYevLhphyxJQkpBe8s27GEbJCpbLClv Pmp53G/9+dTzLyTCKYMrBzb8Oeb0ty1Fn8tuBSP3TAltZjQLhY7enM0IaALUq7ljAb OvFYsUMQWyyYb3CafYK1WdyJvB69e9p2x6zbI07cLivlmcqDQ2fUutAbQjXxKJFdpM BdRDy0IV1M/fByAQVJdkREme6VBxXklgB99icNJAtj/fVEvRxXLZIeJdNZJoTBS1N9 ylED35lcHlOWjzm8XRXYvWs39gy8h15E+45MTK0vsKgE0SRUa2IS+L1nwwvAYSM7vY kyuWhg6uFbW6A== Received: by mail-ed1-f42.google.com with SMTP id b21so17132868edy.6; Wed, 20 Jan 2021 06:24:13 -0800 (PST) X-Gm-Message-State: AOAM532xn2y+PkWUJSOlzhj9N3RKFfofxVFsjBT/MjQIK7GvMHyUCIq7 8PDv83EOjBahZZkmOhlr9FUMs1jpJO0uVzoL4Q== X-Google-Smtp-Source: ABdhPJxsjPL+nYG7BlFb3gzD3BUJUMJLtrEcPRLAGMIcR3Rwa6WblBDjUksihZpxjJd/Vr6d3NHetWaFA5kQ/EYByFs= X-Received: by 2002:a50:fc04:: with SMTP id i4mr7590319edr.137.1611152651919; Wed, 20 Jan 2021 06:24:11 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: <20210120105246.23218-1-michael@walle.cc> From: Rob Herring Date: Wed, 20 Jan 2021 08:23:59 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle Cc: linuxppc-dev , PCI , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Bjorn Helgaas , Greg Kroah-Hartman , Saravana Kannan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). If builtin_platform_driver_probe() doesn't work with fw_devlink, then shouldn't it be fixed or removed? Then we're not fixing drivers later when folks start caring about deferred probe and devlink. I'd really prefer if we convert this to a module instead. (And all the other PCI host drivers.) > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") This happened!? > Signed-off-by: Michael Walle > --- > drivers/pci/controller/dwc/pci-layerscape.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 44ad34cdc3bc..5b9c625df7b8 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -232,7 +232,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > { }, > }; > > -static int __init ls_pcie_probe(struct platform_device *pdev) > +static int ls_pcie_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct dw_pcie *pci; > @@ -271,10 +271,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) > } > > static struct platform_driver ls_pcie_driver = { > + .probe = ls_pcie_probe, > .driver = { > .name = "layerscape-pcie", > .of_match_table = ls_pcie_of_match, > .suppress_bind_attrs = true, > }, > }; > -builtin_platform_driver_probe(ls_pcie_driver, ls_pcie_probe); > +builtin_platform_driver(ls_pcie_driver); > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7ECAC433DB for ; Wed, 20 Jan 2021 14:26:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 467FC2336D for ; Wed, 20 Jan 2021 14:26:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 467FC2336D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DLSWm2kf1zDqx4 for ; Thu, 21 Jan 2021 01:26:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=robh@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qkReOQio; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DLSSw47TkzDqpf for ; Thu, 21 Jan 2021 01:24:16 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C1FD2336E for ; Wed, 20 Jan 2021 14:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611152653; bh=0Xtz3tkNSwsoY9gbgqE2qTK7eRaJcR+iJ9o+tD1IB+c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qkReOQiov9zXiYg96avLVaWfdyxpxanbJ1uYevLhphyxJQkpBe8s27GEbJCpbLClv Pmp53G/9+dTzLyTCKYMrBzb8Oeb0ty1Fn8tuBSP3TAltZjQLhY7enM0IaALUq7ljAb OvFYsUMQWyyYb3CafYK1WdyJvB69e9p2x6zbI07cLivlmcqDQ2fUutAbQjXxKJFdpM BdRDy0IV1M/fByAQVJdkREme6VBxXklgB99icNJAtj/fVEvRxXLZIeJdNZJoTBS1N9 ylED35lcHlOWjzm8XRXYvWs39gy8h15E+45MTK0vsKgE0SRUa2IS+L1nwwvAYSM7vY kyuWhg6uFbW6A== Received: by mail-ed1-f51.google.com with SMTP id c6so18848831ede.0 for ; Wed, 20 Jan 2021 06:24:13 -0800 (PST) X-Gm-Message-State: AOAM531Tl52hwlza38WKmnM33IFJcYWD3zo3ZVLxt27xio7xw4fLDrLk Fw0soigAAiAnXFZ3eRhXB8/oDEDPHvApYzrErQ== X-Google-Smtp-Source: ABdhPJxsjPL+nYG7BlFb3gzD3BUJUMJLtrEcPRLAGMIcR3Rwa6WblBDjUksihZpxjJd/Vr6d3NHetWaFA5kQ/EYByFs= X-Received: by 2002:a50:fc04:: with SMTP id i4mr7590319edr.137.1611152651919; Wed, 20 Jan 2021 06:24:11 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: <20210120105246.23218-1-michael@walle.cc> From: Rob Herring Date: Wed, 20 Jan 2021 08:23:59 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roy Zang , Lorenzo Pieralisi , Saravana Kannan , PCI , "linux-kernel@vger.kernel.org" , Minghuan Lian , linux-arm-kernel , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). If builtin_platform_driver_probe() doesn't work with fw_devlink, then shouldn't it be fixed or removed? Then we're not fixing drivers later when folks start caring about deferred probe and devlink. I'd really prefer if we convert this to a module instead. (And all the other PCI host drivers.) > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") This happened!? > Signed-off-by: Michael Walle > --- > drivers/pci/controller/dwc/pci-layerscape.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 44ad34cdc3bc..5b9c625df7b8 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -232,7 +232,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > { }, > }; > > -static int __init ls_pcie_probe(struct platform_device *pdev) > +static int ls_pcie_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct dw_pcie *pci; > @@ -271,10 +271,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) > } > > static struct platform_driver ls_pcie_driver = { > + .probe = ls_pcie_probe, > .driver = { > .name = "layerscape-pcie", > .of_match_table = ls_pcie_of_match, > .suppress_bind_attrs = true, > }, > }; > -builtin_platform_driver_probe(ls_pcie_driver, ls_pcie_probe); > +builtin_platform_driver(ls_pcie_driver); > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C55C433DB for ; Wed, 20 Jan 2021 14:26:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91A7F23340 for ; Wed, 20 Jan 2021 14:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91A7F23340 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ixwFrK2HsMMzp20tmwwt+q3kdKhSdyjIHEv1tp+II58=; b=gdWHECkrOchmadlsEBNCOZ4nr GimuHFRvMJgDqLuHEXjiYcvpKxNk5Laacyp15ZDBuFjXNvoDb98N3j7pYsTTXsD1lfWeTfKVfRDkJ 0hKRWrmDf+GOZjiL1MNrwe72mbizVFIhAl0EWsm5itx6ZQBP2pmqXm7tgEWch9s13Adcl+/6bqGeG zUJXB++7y5NULX+jwd7UmXyibcTq4m+jptjaaqKgBXRUVN/hzCYQqXGvuwT2B+8eJFU5s4vRbM64S u6ovYruppI+YjY/DuzY2VQvIuLIPOdTxf2xUj+rwTaQZk9Lzw3jRv1yk9MG7kXcx1OnznLs5X031i YM4b3cqnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2EPF-0002W5-Vz; Wed, 20 Jan 2021 14:24:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2EP8-0002Tj-UB for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 14:24:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4277A23329 for ; Wed, 20 Jan 2021 14:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611152653; bh=0Xtz3tkNSwsoY9gbgqE2qTK7eRaJcR+iJ9o+tD1IB+c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qkReOQiov9zXiYg96avLVaWfdyxpxanbJ1uYevLhphyxJQkpBe8s27GEbJCpbLClv Pmp53G/9+dTzLyTCKYMrBzb8Oeb0ty1Fn8tuBSP3TAltZjQLhY7enM0IaALUq7ljAb OvFYsUMQWyyYb3CafYK1WdyJvB69e9p2x6zbI07cLivlmcqDQ2fUutAbQjXxKJFdpM BdRDy0IV1M/fByAQVJdkREme6VBxXklgB99icNJAtj/fVEvRxXLZIeJdNZJoTBS1N9 ylED35lcHlOWjzm8XRXYvWs39gy8h15E+45MTK0vsKgE0SRUa2IS+L1nwwvAYSM7vY kyuWhg6uFbW6A== Received: by mail-ed1-f49.google.com with SMTP id b2so25955010edm.3 for ; Wed, 20 Jan 2021 06:24:13 -0800 (PST) X-Gm-Message-State: AOAM530teETRctuGzYM/vPOhIhf6XKLc7hCwfeQw3dCsJ7AkrD3mAHYm kUWv8It9DNVPii0wCMQuETAt7ZKjtCVsRYF37A== X-Google-Smtp-Source: ABdhPJxsjPL+nYG7BlFb3gzD3BUJUMJLtrEcPRLAGMIcR3Rwa6WblBDjUksihZpxjJd/Vr6d3NHetWaFA5kQ/EYByFs= X-Received: by 2002:a50:fc04:: with SMTP id i4mr7590319edr.137.1611152651919; Wed, 20 Jan 2021 06:24:11 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: <20210120105246.23218-1-michael@walle.cc> From: Rob Herring Date: Wed, 20 Jan 2021 08:23:59 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_092415_126992_2D628CA8 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roy Zang , Lorenzo Pieralisi , Saravana Kannan , PCI , "linux-kernel@vger.kernel.org" , Minghuan Lian , linux-arm-kernel , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , Mingkai Hu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). If builtin_platform_driver_probe() doesn't work with fw_devlink, then shouldn't it be fixed or removed? Then we're not fixing drivers later when folks start caring about deferred probe and devlink. I'd really prefer if we convert this to a module instead. (And all the other PCI host drivers.) > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") This happened!? > Signed-off-by: Michael Walle > --- > drivers/pci/controller/dwc/pci-layerscape.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 44ad34cdc3bc..5b9c625df7b8 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -232,7 +232,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > { }, > }; > > -static int __init ls_pcie_probe(struct platform_device *pdev) > +static int ls_pcie_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct dw_pcie *pci; > @@ -271,10 +271,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) > } > > static struct platform_driver ls_pcie_driver = { > + .probe = ls_pcie_probe, > .driver = { > .name = "layerscape-pcie", > .of_match_table = ls_pcie_of_match, > .suppress_bind_attrs = true, > }, > }; > -builtin_platform_driver_probe(ls_pcie_driver, ls_pcie_probe); > +builtin_platform_driver(ls_pcie_driver); > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel