From: Rob Herring <robh@kernel.org>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: "moderated list:H8/300 ARCHITECTURE"
<uclinux-h8-devel@lists.sourceforge.jp>
Subject: Re: [PATCH] h8300: switch to NO_BOOTMEM
Date: Tue, 1 May 2018 21:33:41 -0500 [thread overview]
Message-ID: <CAL_JsqLUJYfFNR08-UdyQcggesOhafd6WG4uavqP9kY3f0YSZg@mail.gmail.com> (raw)
In-Reply-To: <20180316213306.20424-1-robh@kernel.org>
On Fri, Mar 16, 2018 at 4:33 PM, Rob Herring <robh@kernel.org> wrote:
> Commit 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc")
> inadvertently switched the DT unflattening allocations from memblock to
> bootmem which doesn't work because the unflattening happens before
> bootmem is initialized. Swapping the order of bootmem init and
> unflattening could also fix this, but removing bootmem is desired. So
> enable NO_BOOTMEM on h8300 like other architectures have done.
>
> Fixes: 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc")
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> I haven't seen any reports, but 4.16 is likely broken. This is compile
> tested only.
>
> Moving unflattening after bootmem_init should also work if a smaller
> change for 4.16 is desired.
Ping! Someone going to pick this up?
Rob
next prev parent reply other threads:[~2018-05-02 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 21:33 [PATCH] h8300: switch to NO_BOOTMEM Rob Herring
2018-05-02 2:33 ` Rob Herring [this message]
2018-05-02 11:53 ` Yoshinori Sato
2018-05-09 5:20 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLUJYfFNR08-UdyQcggesOhafd6WG4uavqP9kY3f0YSZg@mail.gmail.com \
--to=robh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.