From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E55C3815B for ; Mon, 20 Apr 2020 17:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D32D22145D for ; Mon, 20 Apr 2020 17:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587403100; bh=MrAH2VsY+TtODBX+fkAcZq5uw1kTGKG8R7HORSOSQ/0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=n+mCSvGW3lKDbUuTSkNBYs3ngkch1tnVvMVKPEwzSnlJWdADYDWBEjpQj12rZr1/p pH9qPlLXHVEHND+Tjd43iDmHmV09LlxMnfUgz6dDZwMmQCDlq9Le+nMyR9hNTSVBip a43jHNZp8yMaiFu6K1GGkiZr11hZ0uoVb37KvVHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbgDTRSU (ORCPT ); Mon, 20 Apr 2020 13:18:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:45174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726724AbgDTRSU (ORCPT ); Mon, 20 Apr 2020 13:18:20 -0400 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC7AE208E4; Mon, 20 Apr 2020 17:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587403099; bh=MrAH2VsY+TtODBX+fkAcZq5uw1kTGKG8R7HORSOSQ/0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JApMb1e4vC54i64Ik32l+IgfX1JaXzs+OgggR9IYG6T8OqAzdISMsR3/gqcukApT9 Ej5J3hNwvzi8GEfCZKycTuZ3e48jJoxHFMy0KKji32mE2H1mCcKP9EemAHgt5/7/ZF 04AHn/xCJO8E6lre5jdeyufKMEsTNuPdwWLdB/uE= Received: by mail-qk1-f178.google.com with SMTP id l25so11502954qkk.3; Mon, 20 Apr 2020 10:18:19 -0700 (PDT) X-Gm-Message-State: AGi0PuY4NSFrOBlhFh8GYoaOeLykZPyZZu29HkB6BFkKSIJAXT6XYrc2 pemtGA9ACjUw5OYT66uXCXA77KwiRl7mCGnFNw== X-Google-Smtp-Source: APiQypJNfkN/fMd0KGM+5Vg1LBXgehBt4JTvfg6zC0uiCkKgQlI0eLwWlHUfc/lg4IOOlDLeLOR+fGB8lSNqdL7SWWM= X-Received: by 2002:a37:c43:: with SMTP id 64mr15949855qkm.119.1587403098789; Mon, 20 Apr 2020 10:18:18 -0700 (PDT) MIME-Version: 1.0 References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-9-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Mon, 20 Apr 2020 12:18:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module To: Arnd Bergmann Cc: Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Sudeep Holla , Catalin Marinas , Greg Kroah-Hartman , Lee Jones , Sebastian Reichel , Stephen Boyd , Will Deacon , Kevin Brodsky , Linux ARM , linux-clk , Linux PM list , Michael Turquette Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, Apr 20, 2020 at 10:28 AM Arnd Bergmann wrote: > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring wrote: > > > > Enable building the vexpress-osc clock driver as a module. > > > > > config CLK_VEXPRESS_OSC > > - bool "Clock driver for Versatile Express OSC clock generators" > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > + tristate "Clock driver for Versatile Express OSC clock generators" > > + depends on VEXPRESS_CONFIG > > Why do you remove the "|| COMPILE_TEST" here? Looks like a rebasing error. I only added it in patch 5. It has to depend on VEXPRESS_CONFIG because devm_regmap_init_vexpress_config doesn't have an empty function. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FA4C3A5A0 for ; Mon, 20 Apr 2020 17:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FFDF208E4 for ; Mon, 20 Apr 2020 17:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nowu6cPV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JApMb1e4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FFDF208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K6FUVxLW1APCb0VIAIDCjqDqNbXD82Pr2NGDPxlrUdY=; b=nowu6cPVTD5nLa Yy9dBuh4jz9R5hjqDrOLqfO2JnQvjYSWNYe7TDrNXc92yoBh0HCHbABd13st2QTnnZaR+dCxZZfB+ S+OB+Mhcuo5R9/hJe1C++dN9NkX4agj8DUGJVSG2alFFptmMb91V9tSdT46Fb3wj+hGFF0UVw2r8a wT4WzmEUNuvkAL8zECM/obQ4B4vHZ+omTE81G9V24RTtovPAl5nZrHp/ZMVMwtBrLiSi3zR2q8Dvd +8z9Aof68nIAScUqkLhxlR+27k2nYqRl+kLTmV1FACZT16njOKB4NEjyb8Flyo2ymZuafdEq/7dLR ef22+6GWproJSKhWFEPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQa41-0002ff-PW; Mon, 20 Apr 2020 17:18:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQa3p-0002Ri-0b for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 17:18:22 +0000 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B86C8221F4 for ; Mon, 20 Apr 2020 17:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587403099; bh=MrAH2VsY+TtODBX+fkAcZq5uw1kTGKG8R7HORSOSQ/0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JApMb1e4vC54i64Ik32l+IgfX1JaXzs+OgggR9IYG6T8OqAzdISMsR3/gqcukApT9 Ej5J3hNwvzi8GEfCZKycTuZ3e48jJoxHFMy0KKji32mE2H1mCcKP9EemAHgt5/7/ZF 04AHn/xCJO8E6lre5jdeyufKMEsTNuPdwWLdB/uE= Received: by mail-qk1-f180.google.com with SMTP id s63so11487233qke.4 for ; Mon, 20 Apr 2020 10:18:19 -0700 (PDT) X-Gm-Message-State: AGi0PubgxpeJh0uqMW603STtQyqol2TMKDIkDaQJc8EAinnaNxqCo0Z6 apzcOYzmfeBy889qEoL8wD+lHQ+xg8fusPz40w== X-Google-Smtp-Source: APiQypJNfkN/fMd0KGM+5Vg1LBXgehBt4JTvfg6zC0uiCkKgQlI0eLwWlHUfc/lg4IOOlDLeLOR+fGB8lSNqdL7SWWM= X-Received: by 2002:a37:c43:: with SMTP id 64mr15949855qkm.119.1587403098789; Mon, 20 Apr 2020 10:18:18 -0700 (PDT) MIME-Version: 1.0 References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-9-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Mon, 20 Apr 2020 12:18:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_101821_122771_0AF27BB9 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Will Deacon , Linux PM list , Stephen Boyd , Catalin Marinas , Linus Walleij , Sudeep Holla , Liviu Dudau , Sebastian Reichel , Kevin Brodsky , Michael Turquette , Greg Kroah-Hartman , Lee Jones , linux-clk , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 20, 2020 at 10:28 AM Arnd Bergmann wrote: > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring wrote: > > > > Enable building the vexpress-osc clock driver as a module. > > > > > config CLK_VEXPRESS_OSC > > - bool "Clock driver for Versatile Express OSC clock generators" > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > + tristate "Clock driver for Versatile Express OSC clock generators" > > + depends on VEXPRESS_CONFIG > > Why do you remove the "|| COMPILE_TEST" here? Looks like a rebasing error. I only added it in patch 5. It has to depend on VEXPRESS_CONFIG because devm_regmap_init_vexpress_config doesn't have an empty function. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel