From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0DA642119175F for ; Tue, 4 Dec 2018 05:41:11 -0800 (PST) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61D872081B for ; Tue, 4 Dec 2018 13:41:11 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id y20so17971000qtm.13 for ; Tue, 04 Dec 2018 05:41:11 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Tue, 4 Dec 2018 07:40:57 -0600 Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-ID: On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC46C04EB8 for ; Tue, 4 Dec 2018 13:41:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 967FC206B7 for ; Tue, 4 Dec 2018 13:41:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KXsfRNHp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 967FC206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbeLDNlL (ORCPT ); Tue, 4 Dec 2018 08:41:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:45432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbeLDNlL (ORCPT ); Tue, 4 Dec 2018 08:41:11 -0500 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83F1621527; Tue, 4 Dec 2018 13:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543930870; bh=ZF1zX9Nn+YEZ9DPmmkONF3lFXF8mR+mJDtQBjSXTaMY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KXsfRNHp60vOts38AgaENQ8Pd9aYNoHh+g/4gXpNSIXTgq/++5m12bMW5UfIRRG2t T/1rC+26H13AvG5zlkzqOLtgftlMrlIExWqvrr3cqsEW7xYCwK1xJ6E05UmioL4Lhm D/C10UadF4GMCKyRts93a0abPZf2nILl6bah7BX0= Received: by mail-qt1-f174.google.com with SMTP id z16so18011306qtq.4; Tue, 04 Dec 2018 05:41:10 -0800 (PST) X-Gm-Message-State: AA+aEWZRDkhpOO18cAC7ebAXeB30BQTDV6D5x3XAmLcrj1v8nKu8L6Bp ZTkx6zadhRMCguw0v8aSrKSiHE9olez282H4vw== X-Google-Smtp-Source: AFSGD/XCEgRjhb8+2LWYHtGtuf3v/mMGB3e3QEVrbGarafA8XtKPNuzdHm109fPTRclXoOdzNpxSQR1B1p7g+YiFdw8= X-Received: by 2002:ac8:1712:: with SMTP id w18mr18361451qtj.76.1543930869590; Tue, 04 Dec 2018 05:41:09 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Tue, 4 Dec 2018 07:40:57 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit To: Brendan Higgins Cc: Randy Dunlap , Greg Kroah-Hartman , Kees Cook , "Luis R. Rodriguez" , shuah@kernel.org, Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, "linux-kernel@vger.kernel.org" , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Dan Williams , linux-nvdimm , Kieran Bingham , Frank Rowand , knut.omang@oracle.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh at kernel.org (Rob Herring) Date: Tue, 4 Dec 2018 07:40:57 -0600 Subject: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Message-ID: On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 4 Dec 2018 07:40:57 -0600 Subject: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20181204134057.5WLEtFYzG8Xq0hSKdT37r2ZbG9yh8QHZen27UlMCFr8@z> On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018@4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit Date: Tue, 4 Dec 2018 07:40:57 -0600 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo-b10kYP2dOMg@public.gmane.org, dri-devel , linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird, Timothy" , Kees Cook , linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Steven Rostedt , Julia Lawall , kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Luis R. Rodriguez" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-Id: dri-devel@lists.freedesktop.org On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUAwy-0004zO-UQ for linux-um@lists.infradead.org; Tue, 04 Dec 2018 13:41:22 +0000 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7527C214DA for ; Tue, 4 Dec 2018 13:41:10 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id l11so18031817qtp.0 for ; Tue, 04 Dec 2018 05:41:10 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-18-brendanhiggins@google.com> <18814973-8f0a-4647-a097-fcc3dc0b3cd3@infradead.org> In-Reply-To: From: Rob Herring Date: Tue, 4 Dec 2018 07:40:57 -0600 Message-ID: Subject: Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , Randy Dunlap , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On Mon, Dec 3, 2018 at 6:14 PM Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 4:40 PM Randy Dunlap wrote: > > > > On 11/28/18 12:56 PM, Rob Herring wrote: > > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > >> index ad3fcad4d75b8..f309399deac20 100644 > > >> --- a/drivers/of/Kconfig > > >> +++ b/drivers/of/Kconfig > > >> @@ -15,6 +15,7 @@ if OF > > >> config OF_UNITTEST > > >> bool "Device Tree runtime unit tests" > > >> depends on !SPARC > > >> + depends on KUNIT > > > Unless KUNIT has depends, better to be a select here. > > > > That's just style or taste. I would prefer to use depends > > instead of select, but that's also just my preference. > > I prefer depends too, but Rob is the maintainer here. Well, we should be consistent, not the follow the whims of each maintainer. Rob _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um