From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756206AbbA1Ctt (ORCPT ); Tue, 27 Jan 2015 21:49:49 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:33731 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbA1Ctr (ORCPT ); Tue, 27 Jan 2015 21:49:47 -0500 MIME-Version: 1.0 In-Reply-To: <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> References: <1422392405-32196-1-git-send-email-m-karicheri2@ti.com> <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> From: Rob Herring Date: Tue, 27 Jan 2015 20:49:25 -0600 Message-ID: Subject: Re: [PATCH v5 5/8] of/pci: add of_pci_dma_configure() update dma configuration To: Murali Karicheri Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linux IOMMU , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Joerg Roedel , Grant Likely , Rob Herring , Will Deacon , Russell King , Arnd Bergmann , Suravee Suthikulpanit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 27, 2015 at 3:00 PM, Murali Karicheri wrote: > Add of_pci_dma_configure() to allow updating the dma configuration > of the pci device using the configuration from DT of the parent of > the root bridge device. Use the newly added APIs > pci_get/put_host_bridge_device() for implementing this. > > Cc: Joerg Roedel > Cc: Grant Likely > Cc: Rob Herring Acked-by: Rob Herring > Cc: Will Deacon > Cc: Russell King > Cc: Arnd Bergmann > Cc: Suravee Suthikulpanit > > Acked-by: Bjorn Helgaas > Signed-off-by: Murali Karicheri > --- > drivers/of/of_pci.c | 19 +++++++++++++++++++ > include/linux/of_pci.h | 5 +++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index 88471d3..0f1dd0b 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -229,6 +230,24 @@ parse_failed: > return err; > } > EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); > + > +/** > + * of_pci_dma_configure - Setup DMA configuration > + * @dev: ptr to pci_dev struct of the pci device > + * > + * Function to update PCI devices's DMA configuration using the same > + * info from the OF node of root host bridge's parent. > + */ > +void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > + struct device *dev = &pci_dev->dev; > + struct device *bridge = pci_get_host_bridge_device(pci_dev); > + > + of_dma_configure(dev, bridge->parent->of_node); > + pci_put_host_bridge_device(bridge); > +} > +EXPORT_SYMBOL_GPL(of_pci_dma_configure); > + > #endif /* CONFIG_OF_ADDRESS */ > > #ifdef CONFIG_PCI_MSI > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h > index ce0e5ab..8f1741f 100644 > --- a/include/linux/of_pci.h > +++ b/include/linux/of_pci.h > @@ -16,6 +16,7 @@ int of_pci_get_devfn(struct device_node *np); > int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); > int of_pci_parse_bus_range(struct device_node *node, struct resource *res); > int of_get_pci_domain_nr(struct device_node *node); > +void of_pci_dma_configure(struct pci_dev *pci_dev); > #else > static inline int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq) > { > @@ -50,6 +51,10 @@ of_get_pci_domain_nr(struct device_node *node) > { > return -1; > } > + > +static inline void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > +} > #endif > > #if defined(CONFIG_OF_ADDRESS) > -- > 1.7.9.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 5/8] of/pci: add of_pci_dma_configure() update dma configuration Date: Tue, 27 Jan 2015 20:49:25 -0600 Message-ID: References: <1422392405-32196-1-git-send-email-m-karicheri2@ti.com> <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1422392405-32196-6-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Murali Karicheri Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux IOMMU , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Joerg Roedel , Grant Likely , Rob Herring , Will Deacon , Russell King , Arnd Bergmann , Suravee Suthikulpanit List-Id: devicetree@vger.kernel.org On Tue, Jan 27, 2015 at 3:00 PM, Murali Karicheri wrote: > Add of_pci_dma_configure() to allow updating the dma configuration > of the pci device using the configuration from DT of the parent of > the root bridge device. Use the newly added APIs > pci_get/put_host_bridge_device() for implementing this. > > Cc: Joerg Roedel > Cc: Grant Likely > Cc: Rob Herring Acked-by: Rob Herring > Cc: Will Deacon > Cc: Russell King > Cc: Arnd Bergmann > Cc: Suravee Suthikulpanit > > Acked-by: Bjorn Helgaas > Signed-off-by: Murali Karicheri > --- > drivers/of/of_pci.c | 19 +++++++++++++++++++ > include/linux/of_pci.h | 5 +++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index 88471d3..0f1dd0b 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -229,6 +230,24 @@ parse_failed: > return err; > } > EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); > + > +/** > + * of_pci_dma_configure - Setup DMA configuration > + * @dev: ptr to pci_dev struct of the pci device > + * > + * Function to update PCI devices's DMA configuration using the same > + * info from the OF node of root host bridge's parent. > + */ > +void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > + struct device *dev = &pci_dev->dev; > + struct device *bridge = pci_get_host_bridge_device(pci_dev); > + > + of_dma_configure(dev, bridge->parent->of_node); > + pci_put_host_bridge_device(bridge); > +} > +EXPORT_SYMBOL_GPL(of_pci_dma_configure); > + > #endif /* CONFIG_OF_ADDRESS */ > > #ifdef CONFIG_PCI_MSI > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h > index ce0e5ab..8f1741f 100644 > --- a/include/linux/of_pci.h > +++ b/include/linux/of_pci.h > @@ -16,6 +16,7 @@ int of_pci_get_devfn(struct device_node *np); > int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); > int of_pci_parse_bus_range(struct device_node *node, struct resource *res); > int of_get_pci_domain_nr(struct device_node *node); > +void of_pci_dma_configure(struct pci_dev *pci_dev); > #else > static inline int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq) > { > @@ -50,6 +51,10 @@ of_get_pci_domain_nr(struct device_node *node) > { > return -1; > } > + > +static inline void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > +} > #endif > > #if defined(CONFIG_OF_ADDRESS) > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com ([74.125.82.47]:33731 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbA1Ctr (ORCPT ); Tue, 27 Jan 2015 21:49:47 -0500 MIME-Version: 1.0 In-Reply-To: <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> References: <1422392405-32196-1-git-send-email-m-karicheri2@ti.com> <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> From: Rob Herring Date: Tue, 27 Jan 2015 20:49:25 -0600 Message-ID: Subject: Re: [PATCH v5 5/8] of/pci: add of_pci_dma_configure() update dma configuration To: Murali Karicheri Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linux IOMMU , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Joerg Roedel , Grant Likely , Rob Herring , Will Deacon , Russell King , Arnd Bergmann , Suravee Suthikulpanit Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Jan 27, 2015 at 3:00 PM, Murali Karicheri wrote: > Add of_pci_dma_configure() to allow updating the dma configuration > of the pci device using the configuration from DT of the parent of > the root bridge device. Use the newly added APIs > pci_get/put_host_bridge_device() for implementing this. > > Cc: Joerg Roedel > Cc: Grant Likely > Cc: Rob Herring Acked-by: Rob Herring > Cc: Will Deacon > Cc: Russell King > Cc: Arnd Bergmann > Cc: Suravee Suthikulpanit > > Acked-by: Bjorn Helgaas > Signed-off-by: Murali Karicheri > --- > drivers/of/of_pci.c | 19 +++++++++++++++++++ > include/linux/of_pci.h | 5 +++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index 88471d3..0f1dd0b 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -229,6 +230,24 @@ parse_failed: > return err; > } > EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); > + > +/** > + * of_pci_dma_configure - Setup DMA configuration > + * @dev: ptr to pci_dev struct of the pci device > + * > + * Function to update PCI devices's DMA configuration using the same > + * info from the OF node of root host bridge's parent. > + */ > +void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > + struct device *dev = &pci_dev->dev; > + struct device *bridge = pci_get_host_bridge_device(pci_dev); > + > + of_dma_configure(dev, bridge->parent->of_node); > + pci_put_host_bridge_device(bridge); > +} > +EXPORT_SYMBOL_GPL(of_pci_dma_configure); > + > #endif /* CONFIG_OF_ADDRESS */ > > #ifdef CONFIG_PCI_MSI > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h > index ce0e5ab..8f1741f 100644 > --- a/include/linux/of_pci.h > +++ b/include/linux/of_pci.h > @@ -16,6 +16,7 @@ int of_pci_get_devfn(struct device_node *np); > int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); > int of_pci_parse_bus_range(struct device_node *node, struct resource *res); > int of_get_pci_domain_nr(struct device_node *node); > +void of_pci_dma_configure(struct pci_dev *pci_dev); > #else > static inline int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq) > { > @@ -50,6 +51,10 @@ of_get_pci_domain_nr(struct device_node *node) > { > return -1; > } > + > +static inline void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > +} > #endif > > #if defined(CONFIG_OF_ADDRESS) > -- > 1.7.9.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Tue, 27 Jan 2015 20:49:25 -0600 Subject: [PATCH v5 5/8] of/pci: add of_pci_dma_configure() update dma configuration In-Reply-To: <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> References: <1422392405-32196-1-git-send-email-m-karicheri2@ti.com> <1422392405-32196-6-git-send-email-m-karicheri2@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 27, 2015 at 3:00 PM, Murali Karicheri wrote: > Add of_pci_dma_configure() to allow updating the dma configuration > of the pci device using the configuration from DT of the parent of > the root bridge device. Use the newly added APIs > pci_get/put_host_bridge_device() for implementing this. > > Cc: Joerg Roedel > Cc: Grant Likely > Cc: Rob Herring Acked-by: Rob Herring > Cc: Will Deacon > Cc: Russell King > Cc: Arnd Bergmann > Cc: Suravee Suthikulpanit > > Acked-by: Bjorn Helgaas > Signed-off-by: Murali Karicheri > --- > drivers/of/of_pci.c | 19 +++++++++++++++++++ > include/linux/of_pci.h | 5 +++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index 88471d3..0f1dd0b 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -229,6 +230,24 @@ parse_failed: > return err; > } > EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); > + > +/** > + * of_pci_dma_configure - Setup DMA configuration > + * @dev: ptr to pci_dev struct of the pci device > + * > + * Function to update PCI devices's DMA configuration using the same > + * info from the OF node of root host bridge's parent. > + */ > +void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > + struct device *dev = &pci_dev->dev; > + struct device *bridge = pci_get_host_bridge_device(pci_dev); > + > + of_dma_configure(dev, bridge->parent->of_node); > + pci_put_host_bridge_device(bridge); > +} > +EXPORT_SYMBOL_GPL(of_pci_dma_configure); > + > #endif /* CONFIG_OF_ADDRESS */ > > #ifdef CONFIG_PCI_MSI > diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h > index ce0e5ab..8f1741f 100644 > --- a/include/linux/of_pci.h > +++ b/include/linux/of_pci.h > @@ -16,6 +16,7 @@ int of_pci_get_devfn(struct device_node *np); > int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); > int of_pci_parse_bus_range(struct device_node *node, struct resource *res); > int of_get_pci_domain_nr(struct device_node *node); > +void of_pci_dma_configure(struct pci_dev *pci_dev); > #else > static inline int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq) > { > @@ -50,6 +51,10 @@ of_get_pci_domain_nr(struct device_node *node) > { > return -1; > } > + > +static inline void of_pci_dma_configure(struct pci_dev *pci_dev) > +{ > +} > #endif > > #if defined(CONFIG_OF_ADDRESS) > -- > 1.7.9.5 >