From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83ED5CA9EAE for ; Tue, 29 Oct 2019 18:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CE39208E3 for ; Tue, 29 Oct 2019 18:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572373652; bh=/E2fVhCHekOqPKt9Ps7vbQev1xOf+FN9GA5rs0TsWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=hlZPT3askJBn4exA4O9EZxeNSAElx5pa1V5m9/ZhSNTj1gSZjANgGHEZYYy/yaOzb rlLuIFleD5K0nhtJSCQc2p3//dvkCurZ/sUHLSu9e8rapKiaqCN507t8N5hWTwa/9p q4sBMgFuhYO+wshfRbpW07DRMcl8xFovo6EqV63E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731522AbfJ2S1b (ORCPT ); Tue, 29 Oct 2019 14:27:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:38248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbfJ2S1b (ORCPT ); Tue, 29 Oct 2019 14:27:31 -0400 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31D8C208E3 for ; Tue, 29 Oct 2019 18:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572373650; bh=/E2fVhCHekOqPKt9Ps7vbQev1xOf+FN9GA5rs0TsWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Bavd8bzTkyChea7ixRdZiKHrN1CkaRznY/Rwwkp91boGKkdf3LRQBOQ/6q48Adzp3 twS2gWAvrXw1muN9kEfzCfc+mkpAtWvC1/VIOwMl333yg7fSGDoLMAVi7IvFc1q8aU caq7MnWmwi1Mz2y62iJltZ+f477oQeLqACCf7g0I= Received: by mail-yb1-f181.google.com with SMTP id b2so1167616ybr.8 for ; Tue, 29 Oct 2019 11:27:30 -0700 (PDT) X-Gm-Message-State: APjAAAVJ5bd5jGUx4mgKfxcu1r4fHwErsbpitu0qk1EeJXppNX4cESK6 izESdrQXDC/yistfa/FD27ctH39Ufe3Z5+6Caw== X-Google-Smtp-Source: APXvYqxRyyqPo2+lGJYLHZpSU0d/i9I6p739hIebEMvjXrssaV6r1vzGfDhydNzp51UWwcKohxGJRazXeypZW+DZ0iA= X-Received: by 2002:a25:bc04:: with SMTP id i4mr19282746ybh.427.1572373649289; Tue, 29 Oct 2019 11:27:29 -0700 (PDT) MIME-Version: 1.0 References: <9a0b09e6b5851f0d4428b72dd6b8b4c0d0ef4206.1572293305.git.robin.murphy@arm.com> In-Reply-To: <9a0b09e6b5851f0d4428b72dd6b8b4c0d0ef4206.1572293305.git.robin.murphy@arm.com> From: Rob Herring Date: Tue, 29 Oct 2019 13:27:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/panfrost: Don't dereference bogus MMU pointers To: Robin Murphy Cc: Tomeu Vizoso , Steven Price , dri-devel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 3:08 PM Robin Murphy wrote: > > It seems that killing an application while faults are occurring > (particularly with a GPU in FPGA at a whopping 40MHz) can lead to > handling a lingering page fault after all the address space contexts > have already been freed. In this situation, the LRU list is empty so > addr_to_drm_mm_node() ends up dereferencing the list head as if it were > a struct panfrost_mmu entry; this leaves "mmu->as" actually pointing at > the pfdev->alloc_mask bitmap, which is also empty, and given that the > fault has a high likelihood of being in AS0, hilarity ensues. > > Sadly, the cleanest solution seems to involve another goto. Oh well, at > least it's robust... > > Signed-off-by: Robin Murphy > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to drm-misc-fixes Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4E9CA9EAE for ; Tue, 29 Oct 2019 18:27:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFDDF20874 for ; Tue, 29 Oct 2019 18:27:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFDDF20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B81F6E524; Tue, 29 Oct 2019 18:27:31 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63B8C6E524 for ; Tue, 29 Oct 2019 18:27:30 +0000 (UTC) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D1D520874 for ; Tue, 29 Oct 2019 18:27:30 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id h202so5734506ybg.13 for ; Tue, 29 Oct 2019 11:27:30 -0700 (PDT) X-Gm-Message-State: APjAAAVDZNfdM4Z9CJHjCT8jt+taQoxRQK3vE1RwkcVyP5P6cYiy9xuh r9d7FG1iATYpf3vZcSjq6YOW/5P2RzrZ+E0jYg== X-Google-Smtp-Source: APXvYqxRyyqPo2+lGJYLHZpSU0d/i9I6p739hIebEMvjXrssaV6r1vzGfDhydNzp51UWwcKohxGJRazXeypZW+DZ0iA= X-Received: by 2002:a25:bc04:: with SMTP id i4mr19282746ybh.427.1572373649289; Tue, 29 Oct 2019 11:27:29 -0700 (PDT) MIME-Version: 1.0 References: <9a0b09e6b5851f0d4428b72dd6b8b4c0d0ef4206.1572293305.git.robin.murphy@arm.com> In-Reply-To: <9a0b09e6b5851f0d4428b72dd6b8b4c0d0ef4206.1572293305.git.robin.murphy@arm.com> From: Rob Herring Date: Tue, 29 Oct 2019 13:27:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/panfrost: Don't dereference bogus MMU pointers To: Robin Murphy X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572373650; bh=/E2fVhCHekOqPKt9Ps7vbQev1xOf+FN9GA5rs0TsWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Bavd8bzTkyChea7ixRdZiKHrN1CkaRznY/Rwwkp91boGKkdf3LRQBOQ/6q48Adzp3 twS2gWAvrXw1muN9kEfzCfc+mkpAtWvC1/VIOwMl333yg7fSGDoLMAVi7IvFc1q8aU caq7MnWmwi1Mz2y62iJltZ+f477oQeLqACCf7g0I= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , dri-devel , Tomeu Vizoso , Steven Price Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191029182717.0dtHatgSDaULgu8dggGY8pSIhJ_LqKIA_2pgrJa1_dU@z> T24gTW9uLCBPY3QgMjgsIDIwMTkgYXQgMzowOCBQTSBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBo eUBhcm0uY29tPiB3cm90ZToKPgo+IEl0IHNlZW1zIHRoYXQga2lsbGluZyBhbiBhcHBsaWNhdGlv biB3aGlsZSBmYXVsdHMgYXJlIG9jY3VycmluZwo+IChwYXJ0aWN1bGFybHkgd2l0aCBhIEdQVSBp biBGUEdBIGF0IGEgd2hvcHBpbmcgNDBNSHopIGNhbiBsZWFkIHRvCj4gaGFuZGxpbmcgYSBsaW5n ZXJpbmcgcGFnZSBmYXVsdCBhZnRlciBhbGwgdGhlIGFkZHJlc3Mgc3BhY2UgY29udGV4dHMKPiBo YXZlIGFscmVhZHkgYmVlbiBmcmVlZC4gSW4gdGhpcyBzaXR1YXRpb24sIHRoZSBMUlUgbGlzdCBp cyBlbXB0eSBzbwo+IGFkZHJfdG9fZHJtX21tX25vZGUoKSBlbmRzIHVwIGRlcmVmZXJlbmNpbmcg dGhlIGxpc3QgaGVhZCBhcyBpZiBpdCB3ZXJlCj4gYSBzdHJ1Y3QgcGFuZnJvc3RfbW11IGVudHJ5 OyB0aGlzIGxlYXZlcyAibW11LT5hcyIgYWN0dWFsbHkgcG9pbnRpbmcgYXQKPiB0aGUgcGZkZXYt PmFsbG9jX21hc2sgYml0bWFwLCB3aGljaCBpcyBhbHNvIGVtcHR5LCBhbmQgZ2l2ZW4gdGhhdCB0 aGUKPiBmYXVsdCBoYXMgYSBoaWdoIGxpa2VsaWhvb2Qgb2YgYmVpbmcgaW4gQVMwLCBoaWxhcml0 eSBlbnN1ZXMuCj4KPiBTYWRseSwgdGhlIGNsZWFuZXN0IHNvbHV0aW9uIHNlZW1zIHRvIGludm9s dmUgYW5vdGhlciBnb3RvLiBPaCB3ZWxsLCBhdAo+IGxlYXN0IGl0J3Mgcm9idXN0Li4uCj4KPiBT aWduZWQtb2ZmLWJ5OiBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfbW11LmMgfCA2ICsrKy0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKQXBwbGllZCB0 byBkcm0tbWlzYy1maXhlcwoKUm9iCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbA==