From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025AbdDDQyy (ORCPT ); Tue, 4 Apr 2017 12:54:54 -0400 Received: from mail.kernel.org ([198.145.29.136]:50824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbdDDQyv (ORCPT ); Tue, 4 Apr 2017 12:54:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170404153036.6651-2-javier@osg.samsung.com> References: <20170404153036.6651-1-javier@osg.samsung.com> <20170404153036.6651-2-javier@osg.samsung.com> From: Rob Herring Date: Tue, 4 Apr 2017 11:54:27 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings To: Javier Martinez Canillas Cc: "linux-kernel@vger.kernel.org" , Aaro Koskinen , "devicetree@vger.kernel.org" , Tony Lindgren , Lee Jones , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 4, 2017 at 10:30 AM, Javier Martinez Canillas wrote: > There are Device Tree source files defining a device node for the > retu/tahvo I2C chip, but there isn't a DT binding document for it. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v4: > - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). > - Add information about what functions the device serve (Lee Jones). > - Avoid using MFD in Device Tree (Lee Jones). > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt > > diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt > new file mode 100644 > index 000000000000..7df21a2b28ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/retu.txt > @@ -0,0 +1,21 @@ > +* Device tree bindings for Nokia Retu and Tahvo multi-function device > + > +Retu and Tahvo are a multi-function devices found on Nokia Internet > +Tablets (770, N800 and N810). The Retu chip provides watchdog timer > +and power button control functionalities while Tahvo chip provides > +USB transceiver functionality. > + > +Required properties: > +- compatible: "nokia,retu" or "nokia,tahvo" > +- reg: Specifies the I2C slave address of the ASIC chip Missing interrupts here. With that: Acked-by: Rob Herring