All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: "Mark Brown" <broonie@kernel.org>, "Vignesh R" <vigneshr@ti.com>,
	"Tudor Ambarus" <tudor.ambarus@microchip.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	simon.k.r.goldschmidt@gmail.com,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Richard Weinberger" <richard@nod.at>,
	"Kim, Cheol Yong" <cheol.yong.kim@intel.com>,
	"Wu, Qiming" <qi-ming.wu@intel.com>
Subject: Re: [PATCH v6 6/6] dt-bindings: spi: Add compatible for Intel LGM SoC
Date: Mon, 9 Nov 2020 09:15:03 -0600	[thread overview]
Message-ID: <CAL_JsqLh=zGiaVaT2nyJjRDLnryR1ZNbK2D=0+MO4Lb=q--yDw@mail.gmail.com> (raw)
In-Reply-To: <12deb9bb-6b3b-d71b-0a6e-5b58da23e09d@linux.intel.com>

On Sun, Nov 8, 2020 at 7:49 PM Ramuthevar, Vadivel MuruganX
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
> Hi Rob,
>
> On 5/11/2020 6:03 am, Rob Herring wrote:
> > On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >>
> >> Add compatible for Intel LGM SoC.
> >>
> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >> ---
> >>   Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
> >> index ec22b040d804..58ecdab939df 100644
> >> --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
> >> +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
> >> @@ -19,6 +19,7 @@ properties:
> >>             - enum:
> >>                 - ti,k2g-qspi
> >>                 - ti,am654-ospi
> >> +              - intel,lgm-qspi
> >
> > As this change shows, you don't need 'oneOf' for Intel...
> As we you have suggested in the previous mail, I framed like below with
> 'oneOf'
>
> properties:
>    compatible:
>      oneOf:
>        - items:
>            - enum:
>                - ti,k2g-qspi
>                - ti,am654-ospi
>            - const: cdns,qspi-nor
>
>        - items:
>            - enum:
>                - intel,lgm-qspi
>                - cadence,qspi   #compatible for generic in future use

Why are you not using the documented vendor prefix 'cdns'?

In any case, adding this is pointless. Your 'generic' compatible is below.

And you still don't need 'oneOf' here. The enum contents here can be
in the first 'enum'.

>            - const: cdns,qspi-nor
>
> so that ignoring error message warning can be avoided as well, Thanks!

In the example? Fix the example!


Rob

  reply	other threads:[~2020-11-09 15:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  5:31 [PATCH v6 0/6] spi: cadence-quadspi: Add QSPI controller support for Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 1/6] spi: cadence-quadspi: Add QSPI " Ramuthevar,Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 2/6] spi: cadence-quadspi: Disable the DAC " Ramuthevar,Vadivel MuruganX
2020-11-03 16:09   ` Pratyush Yadav
2020-11-04  9:18     ` Ramuthevar, Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 3/6] spi: cadence-quadspi: Add multi-chipselect support " Ramuthevar,Vadivel MuruganX
2020-11-05  7:11   ` Linus Walleij
2020-11-06  4:33     ` Ramuthevar, Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 4/6] spi: Move cadence-quadspi.txt to Documentation/devicetree/bindings/spi Ramuthevar,Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 5/6] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Ramuthevar,Vadivel MuruganX
2020-10-30 15:18   ` Rob Herring
2020-11-02  5:59     ` Ramuthevar, Vadivel MuruganX
2020-11-04 22:02       ` Rob Herring
2020-11-09  1:40         ` Ramuthevar, Vadivel MuruganX
2020-10-30  5:31 ` [PATCH v6 6/6] dt-bindings: spi: Add compatible for Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-11-04 22:03   ` Rob Herring
2020-11-09  1:49     ` Ramuthevar, Vadivel MuruganX
2020-11-09 15:15       ` Rob Herring [this message]
2020-11-10  5:21         ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqLh=zGiaVaT2nyJjRDLnryR1ZNbK2D=0+MO4Lb=q--yDw@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=qi-ming.wu@intel.com \
    --cc=richard@nod.at \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.