From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B21CA9EB7 for ; Mon, 21 Oct 2019 17:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CC622077C for ; Mon, 21 Oct 2019 17:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571678937; bh=Qzg+nSzQSl15mcasjyGbnQQil/A3TPHlMSePYlNANZ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=YFQIxQFcdKWVKSRbTAKM9dPWe9OlZ2W+O8jcv1I+lPeudGA7UId7S0/tMmag//jSQ UvRMmbnsp3F73ilIp0YoqDOgNXbu6KBYynxKZz4z7UY0gODpiCHCj1/EUh6RH392IE FqDGzlq/pj4b4HphvGtmWh2hm8fSkXUI1vnD1UQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729616AbfJUR24 (ORCPT ); Mon, 21 Oct 2019 13:28:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:58648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfJUR2z (ORCPT ); Mon, 21 Oct 2019 13:28:55 -0400 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 751D32077C; Mon, 21 Oct 2019 17:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571678933; bh=Qzg+nSzQSl15mcasjyGbnQQil/A3TPHlMSePYlNANZ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RgGKvjMKa74HImO3uxjYKvw0NK90LMd1NHS62oYJe/PK7d2Wn6sNEjJ/2E2hICDBd XByPz58+kfMLYVHX1NC7mvZsqWf+FPP3777xTm0eCgqua4idWWIpn63aYOk4Fv/Qdf Ey7ZtrC9+zWSUcPXn5OWFVJdxwLias2NyrWVNb6U= Received: by mail-qt1-f171.google.com with SMTP id e14so2441067qto.1; Mon, 21 Oct 2019 10:28:53 -0700 (PDT) X-Gm-Message-State: APjAAAWE5+HVqury7By6WCJIjedzOM76I1r2t/0LNRK6JID2UPap1e4z diXGGJzTrZjDWD1GeRe6bf5Mn8QxxN8RubV/pw== X-Google-Smtp-Source: APXvYqycsWbsOq+RkNJmmVCRQvnEVotA2t3MyLrnXmKMy7TpkH+IaWBEzx0jJADgfZO6JSeE0XNQkDJsPHRfKzk4np8= X-Received: by 2002:ac8:70c4:: with SMTP id g4mr12467338qtp.136.1571678932597; Mon, 21 Oct 2019 10:28:52 -0700 (PDT) MIME-Version: 1.0 References: <20191005151404.5fc7386f@archlinux> <1571664677-6984-1-git-send-email-gupt21@gmail.com> In-Reply-To: <1571664677-6984-1-git-send-email-gupt21@gmail.com> From: Rob Herring Date: Mon, 21 Oct 2019 12:28:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/3] dt-bindings: iio: light: add veml6030 ALS bindings To: Rishi Gupta Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , alexios.zavras@intel.com, "Angus Ainslie (Purism)" , "open list:IIO SUBSYSTEM AND DRIVERS" , "linux-kernel@vger.kernel.org" , Mark Rutland , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 8:31 AM Rishi Gupta wrote: > > This commit adds device tree bindings for veml6030 ambient > light sensor. > > Signed-off-by: Rishi Gupta > --- > Changes in v3: > * None > > Changes in v2: > * Corrected grammatical mistake from 'is' to 'are' in description of bindings > > .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > new file mode 100644 > index 0000000..969b314 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0+ (GPL-2.0-only OR BSD-2-Clause) for new bindings please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: VEML6030 Ambient Light Sensor (ALS) > + > +maintainers: > + - Rishi Gupta > + > +description: | > + Bindings for the ambient light sensor veml6030 from Vishay > + Semiconductors over an i2c interface. > + > + Irrespective of whether interrupt is used or not, application > + can get the ALS and White channel reading from IIO raw interface. > + > + If the interrupts are used, application will receive an IIO event > + whenever configured threshold is crossed. > + > + Specifications about the sensor can be found at: > + https://www.vishay.com/docs/84366/veml6030.pdf > + > +properties: > + compatible: > + enum: > + - vishay,veml6030 > + > + reg: > + description: > + I2C address of the device. If the ADDR pin on veml6030 > + is pulled up, this address is 0x48. If the ADDR pin is > + pulled down, this address is 0x10. If you want to define the addresses, then you do: enum: - 0x10 # ADDR pin pulled down - 0x48 # ADDR pin pulled up > + maxItems: 1 And drop this. > + > + interrupts: > + description: > + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW. > + Refer to interrupt-controller/interrupts.txt for generic > + interrupt client node bindings. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@10 { > + compatible = "vishay,veml6030"; > + reg = <0x10>; > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... > -- > 2.7.4 >