From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4750C07E9B for ; Tue, 20 Jul 2021 16:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8932361029 for ; Tue, 20 Jul 2021 16:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhGTQAG (ORCPT ); Tue, 20 Jul 2021 12:00:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:47290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234655AbhGTP6l (ORCPT ); Tue, 20 Jul 2021 11:58:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 79F6D6120F for ; Tue, 20 Jul 2021 16:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626799159; bh=gTXKuYWTIurzIQqTGR7d+wnzFvtpIuOkmCH1n2NqvKY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MmoN+9sYQiL3qcy5sZyXFc4A8b8O4mIYQSyLDMyCtlwiG35UQVJ3LnLKsMAufh1y0 HGyjnLsU9W7VngA/TFAMQA5b5KJouhPadTvp614+RrzYDv6/3/17GEzrQmNEgwkmM3 g87X80HUAGOyS5UBqFUlqIJacccQXyFHeQExRQzFimVuJUzA4GGfTjHYdNzRXcm1lC zWgHnAOwnAmHIe7zO3p2m+VhBgPEtiVX1gg01sa4/0SEg6XCix/6qS7u9IHOdG4lXm B4YCvLjftxn15kK7vJO0sIxZFRtKR6RUuzfBQidEcEW68N5aevFFJ7ZheLYHM4kCAQ 3ODa4HeDdJXCA== Received: by mail-ed1-f54.google.com with SMTP id l1so29181816edr.11 for ; Tue, 20 Jul 2021 09:39:19 -0700 (PDT) X-Gm-Message-State: AOAM5325P6oHYYHwUdZdsV0atMtwoFs59xXxeGaGN/DxGDKjHeLXymLd 0KcykoGyHMGmzGvhO1UgCZN4pMiCXFIUDRDvyQ== X-Google-Smtp-Source: ABdhPJwIBcifE6NzK9FRUpGlqdwlYOSBR3Y10xUH7ncpjDZp6AuBiG/kFIh1H6beccYBKuapdkbMZFeUVE5P8eWzI9Q= X-Received: by 2002:aa7:cb19:: with SMTP id s25mr42400625edt.194.1626799158051; Tue, 20 Jul 2021 09:39:18 -0700 (PDT) MIME-Version: 1.0 References: <20210717001638.1292554-1-linus.walleij@linaro.org> <20210719151833.GA1908766@robh.at.kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 20 Jul 2021 10:39:05 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] bus: ixp4xx: Add DT bindings for the IXP4xx expansion bus To: Linus Walleij Cc: Linux ARM , Imre Kaloz , Krzysztof Halasa , Marc Zyngier , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 19, 2021 at 4:49 PM Linus Walleij wrote: > > On Mon, Jul 19, 2021 at 5:18 PM Rob Herring wrote: > > > > +patternProperties: > > > + "^.*@[0-7],[0-9a-f]+$": > > > + description: Devices attached to chip selects are represented as > > > + subnodes. > > > + type: object > > > + > > > + properties: > > > + intel,ixp4xx-eb-t1: > > > + description: Address timing, extend address phase with n cycles. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + maximum: 3 > > (...) > > > > + unevaluatedProperties: false > > > > This will cause failures when implemented. The problem is this won't > > allow any other child node properties as this schema and the device > > schema are evaluated independently. The only way I see to solve this is > > the child node schemas have to include some 'bus properties' schema > > which includes all possible bus controller properties. There's been a > > recent patch set doing this for SPI. At least here, I think the number > > of different child devices on parallel expansion buses are limited. > > > > So spliting this to 2 schema files would be the first step. Minimally, > > just drop unevaluatedProperties. > > SPI upstream simply uses > > additionalProperties: true > > is that acceptable for now? Yes. (That is the default) Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE37C07E9B for ; Tue, 20 Jul 2021 16:41:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B781860FF2 for ; Tue, 20 Jul 2021 16:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B781860FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uLWrs+TK8vwlTTSrilCM9SWLp66BJeqxVRm4w7ggmro=; b=b+y6Rzfq8U3qmF PaoBT9mDmS36Wb1mRAarPP93b+XL20AP2eGS7pvMf/KhM85HgC+LS3ku390HL9bPqngPjqMPIAjt8 X2YoA2EyIMBX8JB7oUkThoQ4HNWfPvEQQb9m4MUNhMttcDI29p4Lm2wPoTyF9JTHBqvc2ILBMs8nR gPrNe0cVrOVd0I1MgMvbJQHcqBBNG3H1k9kifm1m867e+Ti+CX3YIZtWQJZQW0ndCG3TwkpG41dwr yNhZlMp38mBZLn/UR0pM2vNDQ3mQhvBDSSXwzMYxQHCk3lSHCwP4Nh4lMDxAKnsAmPiFKjCEeAoAZ 7Dad5hEfJ9S4P0ZkaxMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5smC-00DZXJ-KJ; Tue, 20 Jul 2021 16:39:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5sm8-00DZWV-GF for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 16:39:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86BD76120A for ; Tue, 20 Jul 2021 16:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626799159; bh=gTXKuYWTIurzIQqTGR7d+wnzFvtpIuOkmCH1n2NqvKY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MmoN+9sYQiL3qcy5sZyXFc4A8b8O4mIYQSyLDMyCtlwiG35UQVJ3LnLKsMAufh1y0 HGyjnLsU9W7VngA/TFAMQA5b5KJouhPadTvp614+RrzYDv6/3/17GEzrQmNEgwkmM3 g87X80HUAGOyS5UBqFUlqIJacccQXyFHeQExRQzFimVuJUzA4GGfTjHYdNzRXcm1lC zWgHnAOwnAmHIe7zO3p2m+VhBgPEtiVX1gg01sa4/0SEg6XCix/6qS7u9IHOdG4lXm B4YCvLjftxn15kK7vJO0sIxZFRtKR6RUuzfBQidEcEW68N5aevFFJ7ZheLYHM4kCAQ 3ODa4HeDdJXCA== Received: by mail-ed1-f44.google.com with SMTP id l26so29212855eda.10 for ; Tue, 20 Jul 2021 09:39:19 -0700 (PDT) X-Gm-Message-State: AOAM531cO8FepZTbt2SFG+zYLRMjBnl87gEVTockU2dSTGDosnfyTezh bHsH0vwI9jRGpxcu8XKlhLw75A1VTJOmogPENA== X-Google-Smtp-Source: ABdhPJwIBcifE6NzK9FRUpGlqdwlYOSBR3Y10xUH7ncpjDZp6AuBiG/kFIh1H6beccYBKuapdkbMZFeUVE5P8eWzI9Q= X-Received: by 2002:aa7:cb19:: with SMTP id s25mr42400625edt.194.1626799158051; Tue, 20 Jul 2021 09:39:18 -0700 (PDT) MIME-Version: 1.0 References: <20210717001638.1292554-1-linus.walleij@linaro.org> <20210719151833.GA1908766@robh.at.kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 20 Jul 2021 10:39:05 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] bus: ixp4xx: Add DT bindings for the IXP4xx expansion bus To: Linus Walleij Cc: Linux ARM , Imre Kaloz , Krzysztof Halasa , Marc Zyngier , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_093920_664374_4237AD21 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 19, 2021 at 4:49 PM Linus Walleij wrote: > > On Mon, Jul 19, 2021 at 5:18 PM Rob Herring wrote: > > > > +patternProperties: > > > + "^.*@[0-7],[0-9a-f]+$": > > > + description: Devices attached to chip selects are represented as > > > + subnodes. > > > + type: object > > > + > > > + properties: > > > + intel,ixp4xx-eb-t1: > > > + description: Address timing, extend address phase with n cycles. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + maximum: 3 > > (...) > > > > + unevaluatedProperties: false > > > > This will cause failures when implemented. The problem is this won't > > allow any other child node properties as this schema and the device > > schema are evaluated independently. The only way I see to solve this is > > the child node schemas have to include some 'bus properties' schema > > which includes all possible bus controller properties. There's been a > > recent patch set doing this for SPI. At least here, I think the number > > of different child devices on parallel expansion buses are limited. > > > > So spliting this to 2 schema files would be the first step. Minimally, > > just drop unevaluatedProperties. > > SPI upstream simply uses > > additionalProperties: true > > is that acceptable for now? Yes. (That is the default) Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel