From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CC2C433EF for ; Thu, 31 Mar 2022 15:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233900AbiCaPxe (ORCPT ); Thu, 31 Mar 2022 11:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233019AbiCaPxe (ORCPT ); Thu, 31 Mar 2022 11:53:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 649B7606F4; Thu, 31 Mar 2022 08:51:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E324560C35; Thu, 31 Mar 2022 15:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53C6AC34111; Thu, 31 Mar 2022 15:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648741905; bh=k9Ttwe47dSKB//4XyhIsQOi+168C1hhlSrXlQ8RS5Qc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XsUXwi1IjUUN7j7u1Sp3CxErD4DzJAqg0jgz4skj1CR320YstT+0KB3Chzlk9I1Y+ /vlM+RTDgly9Q9QJ5ZCp3JpilOqC7oX8ltxA8QafU91Vt47feMV80dxYHYdo3PZKqn TTlHO2nlB1gV3C2iMg+7tS7rznDLl0Zm6uAaSTlKkpwQV6mtQbUHWbL3JZrXXpjqie kILZeYH9I1J7gFoYYiGPYqLUKvmcOrWTpoQ8DEcc0wwm7DS5Z6aIJE0Jh3E7iHg+H9 dCR2SeLuvs1+yca1ZRKXp7mxOEc6sRx+FkbVpgDPuVVlmaOMo5Xj9W9Hao9ap1keJ6 i2GNzDRUUwuMA== Received: by mail-il1-f169.google.com with SMTP id t15so52099ilq.12; Thu, 31 Mar 2022 08:51:45 -0700 (PDT) X-Gm-Message-State: AOAM532mp7hf6bQvSjpQ1rNhs8QAClmhcrZfrGI3gCs1xPPfrkgGOCsy c3Tkw4QG8VoVVV35glY/eVFli6yLoFPodAxTqw== X-Google-Smtp-Source: ABdhPJwfhuDLSTUugNUrq3UCbhD/GyXM9vgEU4DBm47fXU5hBu6gsJGmx+1IQd9N12SFQjndRYNBevb+f+MIHqebLD0= X-Received: by 2002:a05:6e02:1c2b:b0:2c9:b42e:981b with SMTP id m11-20020a056e021c2b00b002c9b42e981bmr10724018ilh.37.1648741904453; Thu, 31 Mar 2022 08:51:44 -0700 (PDT) MIME-Version: 1.0 References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> <12b0056b-8032-452b-f325-6f36037b5a80@linaro.org> In-Reply-To: From: Rob Herring Date: Thu, 31 Mar 2022 10:51:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells To: Dmitry Baryshkov Cc: Vinod Koul , Krzysztof Kozlowski , Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , Krzysztof Kozlowski , linux-arm-msm , dri-devel , freedreno , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 31, 2022 at 4:35 AM Dmitry Baryshkov wrote: > > On Thu, 31 Mar 2022 at 09:05, Vinod Koul wrote: > > > > On 29-03-22, 10:52, Rob Herring wrote: > > > On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote: > > > > On 28-03-22, 13:21, Rob Herring wrote: > > > > > On Mon, Mar 28, 2022 at 12:18 PM Krzysztof Kozlowski > > > > > wrote: > > > > > > > > > > > > On 28/03/2022 19:16, Vinod Koul wrote: > > > > > > > On 28-03-22, 19:43, Dmitry Baryshkov wrote: > > > > > > >> On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > > > > > > >> wrote: > > > > > > >>> > > > > > > >>> The DSI node is not a bus and the children do not have unit addresses. > > > > > > >>> > > > > > > >>> Reported-by: Vinod Koul > > > > > > >>> Signed-off-by: Krzysztof Kozlowski > > > > > > >> > > > > > > >> NAK. > > > > > > >> DSI panels are children of the DSI device tree node with the reg = <0>; address. > > > > > > >> This is the convention used by other platforms too (see e.g. > > > > > > >> arch/arm64/boot/dts/freescale/imx8mq-evk.dts). > > > > > > > > > > > > > > So we should add reg = 0, i will update my dtsi fix > > > > > > > > > > > > > > > > > > > To "ports" node? No. The reg=0 is for children of the bus, so the > > > > > > panels. How to combine both without warnings - ports and panel@0 - I > > > > > > don't know yet... > > > > > > > > > > I don't think that should case a warning. Or at least it's one we turn off. > > > > > > > > Well in this case I think we might need a fix: > > > > Here is the example quoted in the binding. We have ports{} and then the > > > > two port@0 and port@1 underneath. > > > > > > It's the #address-cells/#size-cells under 'ports' that applies to 'port' > > > nodes. As 'ports' has no address (reg) itself, it doesn't need > > > #address-cells/#size-cells in its parent node. > > > > > > > > > > > So it should be okay to drop #address-cells/#size-cells from dsi node > > > > but keep in ports node... > > > > > > Yes. > > > > > > > Thoughts...? > > > > > > But I thought a panel@0 node was being added? If so then you need to add > > > them back. > > > > I guess we should make this optional, keep it when adding panel@0 node > > and skip for rest where not applicable..? Dmitry is that fine with you? > > This sounds like a workaround. When a panel node is added together > with the '#address-cells' / '#size-cells' properties, we will get > warnings for the 'ports' node. What warning exactly? Is that with W=1? Some warnings are more "don't do this on new designs" rather than never allowed and need to fix current bindings/dts. As such, these warnings will probably never be enabled by default. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2B44C433EF for ; Thu, 31 Mar 2022 15:51:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E573B10F3FB; Thu, 31 Mar 2022 15:51:51 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 293BF10F3FB; Thu, 31 Mar 2022 15:51:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 85632B81B7F; Thu, 31 Mar 2022 15:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48E69C340F3; Thu, 31 Mar 2022 15:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648741905; bh=k9Ttwe47dSKB//4XyhIsQOi+168C1hhlSrXlQ8RS5Qc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XsUXwi1IjUUN7j7u1Sp3CxErD4DzJAqg0jgz4skj1CR320YstT+0KB3Chzlk9I1Y+ /vlM+RTDgly9Q9QJ5ZCp3JpilOqC7oX8ltxA8QafU91Vt47feMV80dxYHYdo3PZKqn TTlHO2nlB1gV3C2iMg+7tS7rznDLl0Zm6uAaSTlKkpwQV6mtQbUHWbL3JZrXXpjqie kILZeYH9I1J7gFoYYiGPYqLUKvmcOrWTpoQ8DEcc0wwm7DS5Z6aIJE0Jh3E7iHg+H9 dCR2SeLuvs1+yca1ZRKXp7mxOEc6sRx+FkbVpgDPuVVlmaOMo5Xj9W9Hao9ap1keJ6 i2GNzDRUUwuMA== Received: by mail-il1-f174.google.com with SMTP id j15so47936ila.13; Thu, 31 Mar 2022 08:51:45 -0700 (PDT) X-Gm-Message-State: AOAM533fK4bUMhJIO7XxAWJ9BvQ7jQcxN5c1hjiqT42rEIOf1ldm/ORQ QmLd0FVgKkyxtdfLalmxNOjjgzQDSdb5syam5w== X-Google-Smtp-Source: ABdhPJwfhuDLSTUugNUrq3UCbhD/GyXM9vgEU4DBm47fXU5hBu6gsJGmx+1IQd9N12SFQjndRYNBevb+f+MIHqebLD0= X-Received: by 2002:a05:6e02:1c2b:b0:2c9:b42e:981b with SMTP id m11-20020a056e021c2b00b002c9b42e981bmr10724018ilh.37.1648741904453; Thu, 31 Mar 2022 08:51:44 -0700 (PDT) MIME-Version: 1.0 References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> <12b0056b-8032-452b-f325-6f36037b5a80@linaro.org> In-Reply-To: From: Rob Herring Date: Thu, 31 Mar 2022 10:51:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells To: Dmitry Baryshkov Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno , devicetree@vger.kernel.org, David Airlie , linux-arm-msm , Vinod Koul , dri-devel , Abhinav Kumar , Krzysztof Kozlowski , Krzysztof Kozlowski , Sean Paul , "linux-kernel@vger.kernel.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 31, 2022 at 4:35 AM Dmitry Baryshkov wrote: > > On Thu, 31 Mar 2022 at 09:05, Vinod Koul wrote: > > > > On 29-03-22, 10:52, Rob Herring wrote: > > > On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote: > > > > On 28-03-22, 13:21, Rob Herring wrote: > > > > > On Mon, Mar 28, 2022 at 12:18 PM Krzysztof Kozlowski > > > > > wrote: > > > > > > > > > > > > On 28/03/2022 19:16, Vinod Koul wrote: > > > > > > > On 28-03-22, 19:43, Dmitry Baryshkov wrote: > > > > > > >> On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > > > > > > >> wrote: > > > > > > >>> > > > > > > >>> The DSI node is not a bus and the children do not have unit addresses. > > > > > > >>> > > > > > > >>> Reported-by: Vinod Koul > > > > > > >>> Signed-off-by: Krzysztof Kozlowski > > > > > > >> > > > > > > >> NAK. > > > > > > >> DSI panels are children of the DSI device tree node with the reg = <0>; address. > > > > > > >> This is the convention used by other platforms too (see e.g. > > > > > > >> arch/arm64/boot/dts/freescale/imx8mq-evk.dts). > > > > > > > > > > > > > > So we should add reg = 0, i will update my dtsi fix > > > > > > > > > > > > > > > > > > > To "ports" node? No. The reg=0 is for children of the bus, so the > > > > > > panels. How to combine both without warnings - ports and panel@0 - I > > > > > > don't know yet... > > > > > > > > > > I don't think that should case a warning. Or at least it's one we turn off. > > > > > > > > Well in this case I think we might need a fix: > > > > Here is the example quoted in the binding. We have ports{} and then the > > > > two port@0 and port@1 underneath. > > > > > > It's the #address-cells/#size-cells under 'ports' that applies to 'port' > > > nodes. As 'ports' has no address (reg) itself, it doesn't need > > > #address-cells/#size-cells in its parent node. > > > > > > > > > > > So it should be okay to drop #address-cells/#size-cells from dsi node > > > > but keep in ports node... > > > > > > Yes. > > > > > > > Thoughts...? > > > > > > But I thought a panel@0 node was being added? If so then you need to add > > > them back. > > > > I guess we should make this optional, keep it when adding panel@0 node > > and skip for rest where not applicable..? Dmitry is that fine with you? > > This sounds like a workaround. When a panel node is added together > with the '#address-cells' / '#size-cells' properties, we will get > warnings for the 'ports' node. What warning exactly? Is that with W=1? Some warnings are more "don't do this on new designs" rather than never allowed and need to fix current bindings/dts. As such, these warnings will probably never be enabled by default. Rob