From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763042AbbA3VEA (ORCPT ); Fri, 30 Jan 2015 16:04:00 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:39931 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753982AbbA3VD6 convert rfc822-to-8bit (ORCPT ); Fri, 30 Jan 2015 16:03:58 -0500 MIME-Version: 1.0 In-Reply-To: <201501301514.14884@pali> References: <1403110464-29646-1-git-send-email-pali.rohar@gmail.com> <201501262009.45854@pali> <201501301514.14884@pali> From: Rob Herring Date: Fri, 30 Jan 2015 15:03:36 -0600 Message-ID: Subject: Re: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Russell King , Will Deacon , Ivaylo Dimitrov , Sebastian Reichel , Pavel Machek , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org lOn Fri, Jan 30, 2015 at 8:14 AM, Pali Rohár wrote: > On Monday 26 January 2015 21:22:27 Rob Herring wrote: >> On Mon, Jan 26, 2015 at 1:09 PM, Pali Rohár > wrote: >> > Ok, here is patch which set Revision field (global variable >> > system_rev) in /proc/cpuinfo from DT revision property: [...] >> > I do not know which DT property to use for storing HW >> > Revision, so if "/revision" is not correct one, let me know >> > what to use instead. Also you can add my Signed-off-by for >> > both patches. >> >> It is the correct property, but /revision in DT is a string. >> >> You need to add your own sign-off. >> >> Rob > > Any documentation which says that /revision is string? Sorry, I was confusing this with serial-number, so I guess a number is fine here. > If it is really string, how to store ATAG_REVISON (number) to > string? dec or hex? However /proc/cpuinfo displays it would be fine if you stay with a string. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Fri, 30 Jan 2015 15:03:36 -0600 Subject: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision In-Reply-To: <201501301514.14884@pali> References: <1403110464-29646-1-git-send-email-pali.rohar@gmail.com> <201501262009.45854@pali> <201501301514.14884@pali> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org lOn Fri, Jan 30, 2015 at 8:14 AM, Pali Roh?r wrote: > On Monday 26 January 2015 21:22:27 Rob Herring wrote: >> On Mon, Jan 26, 2015 at 1:09 PM, Pali Roh?r > wrote: >> > Ok, here is patch which set Revision field (global variable >> > system_rev) in /proc/cpuinfo from DT revision property: [...] >> > I do not know which DT property to use for storing HW >> > Revision, so if "/revision" is not correct one, let me know >> > what to use instead. Also you can add my Signed-off-by for >> > both patches. >> >> It is the correct property, but /revision in DT is a string. >> >> You need to add your own sign-off. >> >> Rob > > Any documentation which says that /revision is string? Sorry, I was confusing this with serial-number, so I guess a number is fine here. > If it is really string, how to store ATAG_REVISON (number) to > string? dec or hex? However /proc/cpuinfo displays it would be fine if you stay with a string. Rob