From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C330DC3B187 for ; Wed, 12 Feb 2020 01:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B5DB2168B for ; Wed, 12 Feb 2020 01:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581472719; bh=5xMV5/TVGRr+5n3CDhQK+BAq0L+GSeKCKbxA7n55/wE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=wLY5Ofd4Qu6fHQFrUQ8bmz5IxJ3rzSg7oEb68BeaSUlpAPO19i72oCY44udGxkEC8 M/ARjMEx7FBfa9janO5yWAXXyVXPyNC2+lF0kWMlYvI5eagK/VHYEGuqXVxrvIWn6F 6VifxtMXsLIiCz+1ZcFWrT0ip1t6VcA6i0o99nPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727584AbgBLB6j (ORCPT ); Tue, 11 Feb 2020 20:58:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:52380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727414AbgBLB6i (ORCPT ); Tue, 11 Feb 2020 20:58:38 -0500 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDAA7215A4; Wed, 12 Feb 2020 01:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581472717; bh=5xMV5/TVGRr+5n3CDhQK+BAq0L+GSeKCKbxA7n55/wE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2h7KjcUk9Sp8aOwuyZi4JC/C8u8EEDPgWxCQewplP19CLItSG4UXpvP9eb+acJoOl F/TlUc0oQ5Ot12JROwBghL5wRhYNEa38T/MPyEHN9hM+GIbCCFf0OHqcnONKZHNUcq qHkRWYtjr3XzRQ9h52PLmLIwStzBoPna6fKAvWgo= Received: by mail-qt1-f180.google.com with SMTP id n17so465958qtv.2; Tue, 11 Feb 2020 17:58:36 -0800 (PST) X-Gm-Message-State: APjAAAWe5CDl4iBp0F9kSQnCDlxzbDmag0MVuQ6swbImslYyc04YRWso ra5MVvNWKyfOnwAM4p/EsbF4CmU0AMyvsS8Xkw== X-Google-Smtp-Source: APXvYqzJvq766HYoGaDSEwrefuEPoAikZi/pD9TMZnClXZXfoYeHa0Z1pBt1X/JlPhjCMqHKV9W/WdNr2bG7DidQlDY= X-Received: by 2002:aed:2344:: with SMTP id i4mr17639114qtc.136.1581472715957; Tue, 11 Feb 2020 17:58:35 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 19:58:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Saravana Kannan Cc: Nicolas Boichat , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is technically > > > equivalent to having not power domain specified at all). > > > > > > However, when there are multiple domains, as in MT8183 Bifrost > > > GPU, we need to handle them in driver code. > > > > > > Signed-off-by: Nicolas Boichat > > > > > > --- > > > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > > additional devices in device tree to accomodate for this [1], but > > > I believe this solution is cleaner. > > > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > > > v4: > > > - Match the exact power domain names as specified in the compatible > > > struct, instead of just matching the number of power domains. > > > [Review: Ulf Hansson] > > > - Dropped print and reordered function [Review: Steven Price] > > > - nits: Run through latest version of checkpatch: > > > - Use WARN instead of BUG_ON. > > > - Drop braces for single expression if block. > > > v3: > > > - Use the compatible matching data to specify the number of power > > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > > as the core will handle these 2 cases in the exact same way > > > (automatically, without driver intervention), and there should > > > be no adverse consequence in this case (the concern is about > > > switching on only some power domains and not others). > > > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > > @@ -5,6 +5,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include "panfrost_device.h" > > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > > pfdev->regulators); > > > } > > > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > > + if (!pfdev->pm_domain_devs[i]) > > > + break; > > > + > > > + if (pfdev->pm_domain_links[i]) > > > + device_link_del(pfdev->pm_domain_links[i]); > > > + > > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > > + } > > > +} > > > + > > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > > +{ > > > + int err; > > > + int i, num_domains; > > > + > > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > > + "power-domains", > > > + "#power-domain-cells"); > > > + > > > + /* > > > + * Single domain is handled by the core, and, if only a single power > > > + * the power domain is requested, the property is optional. > > > + */ > > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > > + return 0; > > > + > > > + if (num_domains != pfdev->comp->num_pm_domains) { > > > + dev_err(pfdev->dev, > > > + "Incorrect number of power domains: %d provided, %d needed\n", > > > + num_domains, pfdev->comp->num_pm_domains); > > > + return -EINVAL; > > > + } > > > + > > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > > + "Too many supplies in compatible structure.\n")) > > > + return -EINVAL; > > > + > > > + for (i = 0; i < num_domains; i++) { > > > + pfdev->pm_domain_devs[i] = > > > + dev_pm_domain_attach_by_name(pfdev->dev, > > > + pfdev->comp->pm_domain_names[i]); > > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > > + pfdev->pm_domain_devs[i] = NULL; > > > + dev_err(pfdev->dev, > > > + "failed to get pm-domain %s(%d): %d\n", > > > + pfdev->comp->pm_domain_names[i], i, err); > > > + goto err; > > > + } > > > + > > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > > > We're in the process of adding device links based on DT properties. > > Shouldn't we add power domains to that? See drivers/of/property.c for > > what's handled. > > Rob, > > drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME > flags. Wanted to start off conservative. I worry that you can't add it later without potentially breaking platforms. I haven't checked, but I assume these flags make runtime PM honor device links? That seems like the more conservative option (more reasons why a device can't suspend). > But adding command line ops > to change the default flags shouldn't be difficult. But before I do > that, I want to change of_devlink to > fw_devlink=. May be I can extend that to > "disabled, permissive, suspend, runtime". I think any command line option should be debug primarily. It's kind of a big hammer. Can drivers adjust the flags themselves? Just modify the flags rather than trying to create new links? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06273C35242 for ; Wed, 12 Feb 2020 01:59:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE50A2082F for ; Wed, 12 Feb 2020 01:58:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bbmwp4ZK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2h7KjcUk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE50A2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G4n1585oWfLpdbGmMSDHYuUX93mV1chHiV8luJ9JZdE=; b=bbmwp4ZKQmGi96 VcNlqYSkZXOBduUNqldfMu7KLfBttI+gZ+Tm0oJJ/0kLRKAWP2jpzaY/bRQHlaiQcg+Zmkyswci5q ctLKpvDTAn8kK9iYIFB5dS5rpdHiqsmBNkeaXiSoAVPuaF2PgfFOnwTZki1jsI6oANCvwAkLBnPzA rXFJGb9IXoDEcdj8WMEZSLVZHEXm0Zo+WE861nG0pa/w81u6TLFqmhdxEy0l26GH7/n/KHyJ4veXy iRVM06O3xPHIATfgnK8oZhWD2pjBsOWW211bLLqfx7DYgh6DAgzIR/vGk91nB5e5Ku/dfJOkqZVA2 v4gtuYeosFa37IiYkcLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1hIc-00088g-Tz; Wed, 12 Feb 2020 01:58:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1hIT-000823-Rn; Wed, 12 Feb 2020 01:58:39 +0000 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01DFF21739; Wed, 12 Feb 2020 01:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581472717; bh=5xMV5/TVGRr+5n3CDhQK+BAq0L+GSeKCKbxA7n55/wE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2h7KjcUk9Sp8aOwuyZi4JC/C8u8EEDPgWxCQewplP19CLItSG4UXpvP9eb+acJoOl F/TlUc0oQ5Ot12JROwBghL5wRhYNEa38T/MPyEHN9hM+GIbCCFf0OHqcnONKZHNUcq qHkRWYtjr3XzRQ9h52PLmLIwStzBoPna6fKAvWgo= Received: by mail-qt1-f170.google.com with SMTP id d5so476130qto.0; Tue, 11 Feb 2020 17:58:36 -0800 (PST) X-Gm-Message-State: APjAAAXUgrzkY6oGOYoNquddO31yzItsS7iD+j0VnOgZ+Iea6qqAfw1v fEtM76K9Rj1eW+3imhfnKBZZLXOEsOTwDGA3Yw== X-Google-Smtp-Source: APXvYqzJvq766HYoGaDSEwrefuEPoAikZi/pD9TMZnClXZXfoYeHa0Z1pBt1X/JlPhjCMqHKV9W/WdNr2bG7DidQlDY= X-Received: by 2002:aed:2344:: with SMTP id i4mr17639114qtc.136.1581472715957; Tue, 11 Feb 2020 17:58:35 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 19:58:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Saravana Kannan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_175837_948778_A9AEE81B X-CRM114-Status: GOOD ( 32.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , Greg Kroah-Hartman , David Airlie , "linux-kernel@vger.kernel.org" , Liam Girdwood , dri-devel , Steven Price , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is technically > > > equivalent to having not power domain specified at all). > > > > > > However, when there are multiple domains, as in MT8183 Bifrost > > > GPU, we need to handle them in driver code. > > > > > > Signed-off-by: Nicolas Boichat > > > > > > --- > > > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > > additional devices in device tree to accomodate for this [1], but > > > I believe this solution is cleaner. > > > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > > > v4: > > > - Match the exact power domain names as specified in the compatible > > > struct, instead of just matching the number of power domains. > > > [Review: Ulf Hansson] > > > - Dropped print and reordered function [Review: Steven Price] > > > - nits: Run through latest version of checkpatch: > > > - Use WARN instead of BUG_ON. > > > - Drop braces for single expression if block. > > > v3: > > > - Use the compatible matching data to specify the number of power > > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > > as the core will handle these 2 cases in the exact same way > > > (automatically, without driver intervention), and there should > > > be no adverse consequence in this case (the concern is about > > > switching on only some power domains and not others). > > > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > > @@ -5,6 +5,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include "panfrost_device.h" > > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > > pfdev->regulators); > > > } > > > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > > + if (!pfdev->pm_domain_devs[i]) > > > + break; > > > + > > > + if (pfdev->pm_domain_links[i]) > > > + device_link_del(pfdev->pm_domain_links[i]); > > > + > > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > > + } > > > +} > > > + > > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > > +{ > > > + int err; > > > + int i, num_domains; > > > + > > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > > + "power-domains", > > > + "#power-domain-cells"); > > > + > > > + /* > > > + * Single domain is handled by the core, and, if only a single power > > > + * the power domain is requested, the property is optional. > > > + */ > > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > > + return 0; > > > + > > > + if (num_domains != pfdev->comp->num_pm_domains) { > > > + dev_err(pfdev->dev, > > > + "Incorrect number of power domains: %d provided, %d needed\n", > > > + num_domains, pfdev->comp->num_pm_domains); > > > + return -EINVAL; > > > + } > > > + > > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > > + "Too many supplies in compatible structure.\n")) > > > + return -EINVAL; > > > + > > > + for (i = 0; i < num_domains; i++) { > > > + pfdev->pm_domain_devs[i] = > > > + dev_pm_domain_attach_by_name(pfdev->dev, > > > + pfdev->comp->pm_domain_names[i]); > > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > > + pfdev->pm_domain_devs[i] = NULL; > > > + dev_err(pfdev->dev, > > > + "failed to get pm-domain %s(%d): %d\n", > > > + pfdev->comp->pm_domain_names[i], i, err); > > > + goto err; > > > + } > > > + > > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > > > We're in the process of adding device links based on DT properties. > > Shouldn't we add power domains to that? See drivers/of/property.c for > > what's handled. > > Rob, > > drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME > flags. Wanted to start off conservative. I worry that you can't add it later without potentially breaking platforms. I haven't checked, but I assume these flags make runtime PM honor device links? That seems like the more conservative option (more reasons why a device can't suspend). > But adding command line ops > to change the default flags shouldn't be difficult. But before I do > that, I want to change of_devlink to > fw_devlink=. May be I can extend that to > "disabled, permissive, suspend, runtime". I think any command line option should be debug primarily. It's kind of a big hammer. Can drivers adjust the flags themselves? Just modify the flags rather than trying to create new links? Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5990FC35242 for ; Wed, 12 Feb 2020 01:58:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 297052082F for ; Wed, 12 Feb 2020 01:58:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sqgiRV36"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2h7KjcUk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 297052082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=69MQtX+stFhwLKoLixGT3sdsxnwOenI+lEfGF4fDP5Y=; b=sqgiRV36uB8+fL t4coOGw2T8O+Exr3Nr7Z8KitgW+QIhLHbyze037Ic2IU/FB1bGEvDWnxodzqXcXUrlVmqsJbXfmvN yRwlnRzRuIMiRyZEk6PGGxL5o4J79LL0p3HzQ1O4mtGLBXjRRVeCxITU3lia0DD//R+CRp+7h28HX aohXO3/IMGoGths1Ba+9jVXxVIMqKF/iecpQBYclw5Oi73Z1RX6XhZGwEs/yqikM7Y76ethb72kxs WleXUxHN/Mv5ZnEWOKDRek5H31qVnVRbiqwgBLulG3rrdgvGd8qeg3GAovlFRux6sFcKhdsUocwAA GSaNGPb/EVTXIq8NPIig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1hIX-00082S-JP; Wed, 12 Feb 2020 01:58:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1hIT-000823-Rn; Wed, 12 Feb 2020 01:58:39 +0000 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01DFF21739; Wed, 12 Feb 2020 01:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581472717; bh=5xMV5/TVGRr+5n3CDhQK+BAq0L+GSeKCKbxA7n55/wE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2h7KjcUk9Sp8aOwuyZi4JC/C8u8EEDPgWxCQewplP19CLItSG4UXpvP9eb+acJoOl F/TlUc0oQ5Ot12JROwBghL5wRhYNEa38T/MPyEHN9hM+GIbCCFf0OHqcnONKZHNUcq qHkRWYtjr3XzRQ9h52PLmLIwStzBoPna6fKAvWgo= Received: by mail-qt1-f170.google.com with SMTP id d5so476130qto.0; Tue, 11 Feb 2020 17:58:36 -0800 (PST) X-Gm-Message-State: APjAAAXUgrzkY6oGOYoNquddO31yzItsS7iD+j0VnOgZ+Iea6qqAfw1v fEtM76K9Rj1eW+3imhfnKBZZLXOEsOTwDGA3Yw== X-Google-Smtp-Source: APXvYqzJvq766HYoGaDSEwrefuEPoAikZi/pD9TMZnClXZXfoYeHa0Z1pBt1X/JlPhjCMqHKV9W/WdNr2bG7DidQlDY= X-Received: by 2002:aed:2344:: with SMTP id i4mr17639114qtc.136.1581472715957; Tue, 11 Feb 2020 17:58:35 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 19:58:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Saravana Kannan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_175837_948778_A9AEE81B X-CRM114-Status: GOOD ( 32.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , Greg Kroah-Hartman , David Airlie , "linux-kernel@vger.kernel.org" , Liam Girdwood , dri-devel , Steven Price , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is technically > > > equivalent to having not power domain specified at all). > > > > > > However, when there are multiple domains, as in MT8183 Bifrost > > > GPU, we need to handle them in driver code. > > > > > > Signed-off-by: Nicolas Boichat > > > > > > --- > > > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > > additional devices in device tree to accomodate for this [1], but > > > I believe this solution is cleaner. > > > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > > > v4: > > > - Match the exact power domain names as specified in the compatible > > > struct, instead of just matching the number of power domains. > > > [Review: Ulf Hansson] > > > - Dropped print and reordered function [Review: Steven Price] > > > - nits: Run through latest version of checkpatch: > > > - Use WARN instead of BUG_ON. > > > - Drop braces for single expression if block. > > > v3: > > > - Use the compatible matching data to specify the number of power > > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > > as the core will handle these 2 cases in the exact same way > > > (automatically, without driver intervention), and there should > > > be no adverse consequence in this case (the concern is about > > > switching on only some power domains and not others). > > > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > > @@ -5,6 +5,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include "panfrost_device.h" > > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > > pfdev->regulators); > > > } > > > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > > + if (!pfdev->pm_domain_devs[i]) > > > + break; > > > + > > > + if (pfdev->pm_domain_links[i]) > > > + device_link_del(pfdev->pm_domain_links[i]); > > > + > > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > > + } > > > +} > > > + > > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > > +{ > > > + int err; > > > + int i, num_domains; > > > + > > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > > + "power-domains", > > > + "#power-domain-cells"); > > > + > > > + /* > > > + * Single domain is handled by the core, and, if only a single power > > > + * the power domain is requested, the property is optional. > > > + */ > > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > > + return 0; > > > + > > > + if (num_domains != pfdev->comp->num_pm_domains) { > > > + dev_err(pfdev->dev, > > > + "Incorrect number of power domains: %d provided, %d needed\n", > > > + num_domains, pfdev->comp->num_pm_domains); > > > + return -EINVAL; > > > + } > > > + > > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > > + "Too many supplies in compatible structure.\n")) > > > + return -EINVAL; > > > + > > > + for (i = 0; i < num_domains; i++) { > > > + pfdev->pm_domain_devs[i] = > > > + dev_pm_domain_attach_by_name(pfdev->dev, > > > + pfdev->comp->pm_domain_names[i]); > > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > > + pfdev->pm_domain_devs[i] = NULL; > > > + dev_err(pfdev->dev, > > > + "failed to get pm-domain %s(%d): %d\n", > > > + pfdev->comp->pm_domain_names[i], i, err); > > > + goto err; > > > + } > > > + > > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > > > We're in the process of adding device links based on DT properties. > > Shouldn't we add power domains to that? See drivers/of/property.c for > > what's handled. > > Rob, > > drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME > flags. Wanted to start off conservative. I worry that you can't add it later without potentially breaking platforms. I haven't checked, but I assume these flags make runtime PM honor device links? That seems like the more conservative option (more reasons why a device can't suspend). > But adding command line ops > to change the default flags shouldn't be difficult. But before I do > that, I want to change of_devlink to > fw_devlink=. May be I can extend that to > "disabled, permissive, suspend, runtime". I think any command line option should be debug primarily. It's kind of a big hammer. Can drivers adjust the flags themselves? Just modify the flags rather than trying to create new links? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7332EC35242 for ; Wed, 12 Feb 2020 01:58:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40DAE2082F for ; Wed, 12 Feb 2020 01:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2h7KjcUk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DAE2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A04BC6E514; Wed, 12 Feb 2020 01:58:38 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C1E36E514 for ; Wed, 12 Feb 2020 01:58:37 +0000 (UTC) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFB2D2086A for ; Wed, 12 Feb 2020 01:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581472717; bh=5xMV5/TVGRr+5n3CDhQK+BAq0L+GSeKCKbxA7n55/wE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2h7KjcUk9Sp8aOwuyZi4JC/C8u8EEDPgWxCQewplP19CLItSG4UXpvP9eb+acJoOl F/TlUc0oQ5Ot12JROwBghL5wRhYNEa38T/MPyEHN9hM+GIbCCFf0OHqcnONKZHNUcq qHkRWYtjr3XzRQ9h52PLmLIwStzBoPna6fKAvWgo= Received: by mail-qt1-f177.google.com with SMTP id e21so420022qtp.13 for ; Tue, 11 Feb 2020 17:58:36 -0800 (PST) X-Gm-Message-State: APjAAAUTDG8IZtZQn+DXJM/fbRKc1C4xrmTQn2N/AEegv3KfIGsUc804 muLC7Z+awXXFLKgor/YiIHha3gpN7+g1/Sfy+g== X-Google-Smtp-Source: APXvYqzJvq766HYoGaDSEwrefuEPoAikZi/pD9TMZnClXZXfoYeHa0Z1pBt1X/JlPhjCMqHKV9W/WdNr2bG7DidQlDY= X-Received: by 2002:aed:2344:: with SMTP id i4mr17639114qtc.136.1581472715957; Tue, 11 Feb 2020 17:58:35 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 19:58:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Saravana Kannan X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , Greg Kroah-Hartman , David Airlie , "linux-kernel@vger.kernel.org" , Liam Girdwood , dri-devel , Steven Price , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Hsin-Yi Wang , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is technically > > > equivalent to having not power domain specified at all). > > > > > > However, when there are multiple domains, as in MT8183 Bifrost > > > GPU, we need to handle them in driver code. > > > > > > Signed-off-by: Nicolas Boichat > > > > > > --- > > > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > > additional devices in device tree to accomodate for this [1], but > > > I believe this solution is cleaner. > > > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > > > v4: > > > - Match the exact power domain names as specified in the compatible > > > struct, instead of just matching the number of power domains. > > > [Review: Ulf Hansson] > > > - Dropped print and reordered function [Review: Steven Price] > > > - nits: Run through latest version of checkpatch: > > > - Use WARN instead of BUG_ON. > > > - Drop braces for single expression if block. > > > v3: > > > - Use the compatible matching data to specify the number of power > > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > > as the core will handle these 2 cases in the exact same way > > > (automatically, without driver intervention), and there should > > > be no adverse consequence in this case (the concern is about > > > switching on only some power domains and not others). > > > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > > @@ -5,6 +5,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include "panfrost_device.h" > > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > > pfdev->regulators); > > > } > > > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > > + if (!pfdev->pm_domain_devs[i]) > > > + break; > > > + > > > + if (pfdev->pm_domain_links[i]) > > > + device_link_del(pfdev->pm_domain_links[i]); > > > + > > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > > + } > > > +} > > > + > > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > > +{ > > > + int err; > > > + int i, num_domains; > > > + > > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > > + "power-domains", > > > + "#power-domain-cells"); > > > + > > > + /* > > > + * Single domain is handled by the core, and, if only a single power > > > + * the power domain is requested, the property is optional. > > > + */ > > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > > + return 0; > > > + > > > + if (num_domains != pfdev->comp->num_pm_domains) { > > > + dev_err(pfdev->dev, > > > + "Incorrect number of power domains: %d provided, %d needed\n", > > > + num_domains, pfdev->comp->num_pm_domains); > > > + return -EINVAL; > > > + } > > > + > > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > > + "Too many supplies in compatible structure.\n")) > > > + return -EINVAL; > > > + > > > + for (i = 0; i < num_domains; i++) { > > > + pfdev->pm_domain_devs[i] = > > > + dev_pm_domain_attach_by_name(pfdev->dev, > > > + pfdev->comp->pm_domain_names[i]); > > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > > + pfdev->pm_domain_devs[i] = NULL; > > > + dev_err(pfdev->dev, > > > + "failed to get pm-domain %s(%d): %d\n", > > > + pfdev->comp->pm_domain_names[i], i, err); > > > + goto err; > > > + } > > > + > > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > > > We're in the process of adding device links based on DT properties. > > Shouldn't we add power domains to that? See drivers/of/property.c for > > what's handled. > > Rob, > > drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME > flags. Wanted to start off conservative. I worry that you can't add it later without potentially breaking platforms. I haven't checked, but I assume these flags make runtime PM honor device links? That seems like the more conservative option (more reasons why a device can't suspend). > But adding command line ops > to change the default flags shouldn't be difficult. But before I do > that, I want to change of_devlink to > fw_devlink=. May be I can extend that to > "disabled, permissive, suspend, runtime". I think any command line option should be debug primarily. It's kind of a big hammer. Can drivers adjust the flags themselves? Just modify the flags rather than trying to create new links? Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel