From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE82C433FE for ; Tue, 30 Nov 2021 21:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235778AbhK3WAf (ORCPT ); Tue, 30 Nov 2021 17:00:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232274AbhK3WAd (ORCPT ); Tue, 30 Nov 2021 17:00:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19C32C061574; Tue, 30 Nov 2021 13:57:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD150B81D35; Tue, 30 Nov 2021 21:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55BCBC53FCC; Tue, 30 Nov 2021 21:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638309431; bh=kUUQXubL4SraGE4IjF0ilacjwCfmZF9yFAI38NtvZbo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GDjCD1WVlw4mzytOHo5U2hOk9KUhveswvx2prh0JshYqr6baLtxg5w6XDiYjSmtLW ymslIwK6wsLG63vxDvEqn7IJN0FdgYsXI8b94QoCMHqILWXonh+QenENeoHDbPQFGV kRqkEEepoKf1Ehefs8skdlJ9FzMccfPdBlSJHSItw8UjLN1aEuGmMFUxnegMwKyvFE jy4NmfcsskCm4Bm3YQxp2Lb063vJUPrkalqjdbN3KJFHQS3FwFE94/apTkJJS0xVfM xIy+HV+1//QXs86NThip6K7N2uNNwxDnh3Ed0eYEXSzDU8RzE5Efk4LIhi2LSQpQkm 3dP+dpdu9hokg== Received: by mail-ed1-f51.google.com with SMTP id v1so92713660edx.2; Tue, 30 Nov 2021 13:57:11 -0800 (PST) X-Gm-Message-State: AOAM530xQTur0nDBOw/bOf4AxxkPEBkRWudkIWCYohmKV9/cD/4V8Ey8 7FnzrQKyIJbDI3qFi0QEQIIcwW0FXmsqADSwkw== X-Google-Smtp-Source: ABdhPJy67ASe7BHIiZBS6nwrHr+brgKBXklp9nqQR+8Kf7spUabgBasdxj96SHCwNwEpF3O2Eu8GrhD2c+BUUvd18CE= X-Received: by 2002:aa7:cc82:: with SMTP id p2mr2380619edt.201.1638309427941; Tue, 30 Nov 2021 13:57:07 -0800 (PST) MIME-Version: 1.0 References: <20211027201641.2076427-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 30 Nov 2021 15:56:56 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 0/5] Another version of arm64 userspace counter access support. To: Will Deacon , Mark Rutland , Peter Zijlstra Cc: Jonathan Corbet , Catalin Marinas , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , X86 ML , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , linux-arm-kernel , linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 15, 2021 at 10:57 AM Rob Herring wrote: > > On Wed, Oct 27, 2021 at 3:16 PM Rob Herring wrote: > > > > The arm64 support departs from the x86 implementation by requiring the user > > to explicitly request user access (via attr.config1) and only enables access > > for task bound events. Since usage is explicitly requested, access is > > enabled at perf_event_open() rather than on mmap() as that greatly > > simplifies the implementation. Rather than trying to lock down the access > > as the x86 implementation has been doing, we can start with only a limited > > use case enabled and later expand it if needed. > > > > I've run this version thru Vince's perf tests[14] with arm64 support added. > > I wish I'd found these tests sooner... > > > > This originally resurrected Raphael's series[1] to enable userspace counter > > access on arm64. My previous versions are here > > [2][3][4][5][6][7][8][9][10][11][12]. > > A git branch is here[13]. > > > > Changes in v12: > > - Zero PMSELR_EL0 when userspace access is enabled > > - Return -EOPNOTSUPP for if h/w doesn't support 64-bit counters > > Will, the series rebases cleanly on v5.16-rc1. Please let me know if > you want me to resend. > > Peter, Will is waiting on an ack on the core/x86 bits from you. Ping! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A5D2C433EF for ; Tue, 30 Nov 2021 21:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dAneTYxg3C7MnwwuLu04pSi2jChyofFplOWrVB7LW8=; b=cdrbe2KVssVLzR pbRAonleLY5F76tromBVDHhqfWG/pBTrLl3a0Hhx4B4euBntvm+kO8ChuviVZ55oD9BmFMhMam8eM JVJ5Dm7RHPO7CAEO70a8axxcu8aY+YvScUtZSj/Wel/fSvF7VQB9K84ofvOwTr6YsKN0Isb/mkGJ1 LT4/vBOMG/1gqQFeVVjZpfsT09w8C5NgW8D0tKMHs505Df+eHHwGdnI/lA/32RHBtF/+BOhMePxN4 PIDtoKous21AohoR+v640O6ZKR5ZuBfuxUOV2/HhkzD5pIzMj952P8dRCYmMsCKxQuL1XXs/a/ozN XtJPeLXiMVJy2wFOicjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msB7s-006rL1-4x; Tue, 30 Nov 2021 21:57:24 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msB7n-006rHe-W7 for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 21:57:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EDBD9B81CDD for ; Tue, 30 Nov 2021 21:57:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B574AC53FD2 for ; Tue, 30 Nov 2021 21:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638309429; bh=kUUQXubL4SraGE4IjF0ilacjwCfmZF9yFAI38NtvZbo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fBh1TyZCYjxDarqr56xlVwtuyX3W/ZAyV/bLI5svoldBviLKwv/hc3v7vNoUimy3v x+zhcqJV0vJBruE7DrosUhsEAVm1RVP4AX+ytfbssfG96LG8sCFMKjdKdKcuLNCSMQ AZ1RYX+VihGvQoC95tKItWpYGaR/+dlE0cNabBDNB5fF8x/6j/H1Mxt3gfMdplOQF5 3OAjmzQNQiSVx0Mh9W+OG8cz6V1nJtcSI+qc+/TeV3v9BaECsm0wXvlDH2Zlquje85 Yk6AT3PsgCZ+1K02mLWikQjwtfv1ItchTGwqebwmmyeUPYRqFa3nSd/0+yhtf2MOUB N+EMnAKHn5Y2g== Received: by mail-ed1-f46.google.com with SMTP id e3so92857266edu.4 for ; Tue, 30 Nov 2021 13:57:09 -0800 (PST) X-Gm-Message-State: AOAM531Pa5WgqpZPtNNWCiDayN8vmbXMtcF4W880kWQUjbAPU2awWFcw 0e+KvNFSkwMvX4H4Cr6ahMv98elG8JCywMSj9A== X-Google-Smtp-Source: ABdhPJy67ASe7BHIiZBS6nwrHr+brgKBXklp9nqQR+8Kf7spUabgBasdxj96SHCwNwEpF3O2Eu8GrhD2c+BUUvd18CE= X-Received: by 2002:aa7:cc82:: with SMTP id p2mr2380619edt.201.1638309427941; Tue, 30 Nov 2021 13:57:07 -0800 (PST) MIME-Version: 1.0 References: <20211027201641.2076427-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 30 Nov 2021 15:56:56 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 0/5] Another version of arm64 userspace counter access support. To: Will Deacon , Mark Rutland , Peter Zijlstra Cc: Jonathan Corbet , Catalin Marinas , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , X86 ML , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , linux-arm-kernel , linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_135720_349466_80882CA5 X-CRM114-Status: GOOD ( 25.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 15, 2021 at 10:57 AM Rob Herring wrote: > > On Wed, Oct 27, 2021 at 3:16 PM Rob Herring wrote: > > > > The arm64 support departs from the x86 implementation by requiring the user > > to explicitly request user access (via attr.config1) and only enables access > > for task bound events. Since usage is explicitly requested, access is > > enabled at perf_event_open() rather than on mmap() as that greatly > > simplifies the implementation. Rather than trying to lock down the access > > as the x86 implementation has been doing, we can start with only a limited > > use case enabled and later expand it if needed. > > > > I've run this version thru Vince's perf tests[14] with arm64 support added. > > I wish I'd found these tests sooner... > > > > This originally resurrected Raphael's series[1] to enable userspace counter > > access on arm64. My previous versions are here > > [2][3][4][5][6][7][8][9][10][11][12]. > > A git branch is here[13]. > > > > Changes in v12: > > - Zero PMSELR_EL0 when userspace access is enabled > > - Return -EOPNOTSUPP for if h/w doesn't support 64-bit counters > > Will, the series rebases cleanly on v5.16-rc1. Please let me know if > you want me to resend. > > Peter, Will is waiting on an ack on the core/x86 bits from you. Ping! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel