From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92693C7618E for ; Thu, 16 Mar 2023 19:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 5C324C433A0; Thu, 16 Mar 2023 19:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 464BBC433D2; Thu, 16 Mar 2023 19:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678996310; bh=zJnu6WZbbOrEPFIzFpFrY/DR/GnxDmEoNXhsslkKARU=; h=References:In-Reply-To:From:Date:Subject:List-Id:To:Cc:From; b=EhHAplpsZ1gp7OvBJL8TsEw7cyaajYiyJxRiNpOXdcvG79kAtceo6I57qdcCZwqRr 10TcaS3f9daZdCZCkn5zqSHRFs8l7UeutzHb9LkxczSxt3ws29N2OxKGxIvJS9DUZE 717k0pAmkcIryooeAw+HVQuuXOldtD+r2LCKauBRLAy6jkW8KUuuILgs7GL0+66deF ld48BAkwyzkZ2e6bacGxwYTCgAjCTrR6ZJn5LDjSARm8D/ubctZTxr80NDzcHALBZ3 8Kgc/DwQxnMTJxBO6f+ODVDQImTskVzTzPLUEralo3uF5MSgO0HB/3Jpm5Rlvm/lsn e7zdxGjYY1ekQ== Received: by mail-vs1-f48.google.com with SMTP id o2so2543146vss.8; Thu, 16 Mar 2023 12:51:50 -0700 (PDT) X-Gm-Message-State: AO0yUKVWeCpmCSGei1HHcKbOjPUT8M1bgARfMH1ujHK0vKDUzAUm+bgF QHZL2uD1Ye5W1qqrDPrzkE/eKOeOR7rG9fFCGA== X-Google-Smtp-Source: AK7set8/uY+rnVD9Tg3305Y6q91Hm6ecvF29SGXPPeBhHrNC6cfRN8YTeXkx74+l+JV1XRJK2qi3EQpZz0LFS+I3IKU= X-Received: by 2002:a67:fb46:0:b0:425:a28f:2e09 with SMTP id e6-20020a67fb46000000b00425a28f2e09mr7185807vsr.7.1678996309167; Thu, 16 Mar 2023 12:51:49 -0700 (PDT) MIME-Version: 1.0 References: <20230208185506.2305349-1-robh@kernel.org> In-Reply-To: <20230208185506.2305349-1-robh@kernel.org> From: Rob Herring Date: Thu, 16 Mar 2023 14:51:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: cavium: Fix GICv3 ITS nodes List-Id: To: Krzysztof Kozlowski , Robert Richter , SoC Team Cc: Robin Murphy , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 8, 2023 at 12:55=E2=80=AFPM Rob Herring wrote= : > > The GICv3 ITS is an MSI controller, therefore its node name should be > 'msi-controller'. The ITS node is also expected to have '#msi-cells'. > Add it on Thunder as there are no users. Thunder2 uses 'msi-parent', but > Robin says that should be 'msi-map' instead and I'm not sure what's > correct for it. > > The unit-addresses of both the ITS and main GIC node on thunder2 are also > wrong, so fix them while we're here. > > Cc: Robin Murphy > Signed-off-by: Rob Herring > --- > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 3 ++- > arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Ping! Should we remove these platforms instead if they aren't maintained? > > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/bo= ot/dts/cavium/thunder-88xx.dtsi > index e0a71795261b..8ad31dee11a3 100644 > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > @@ -389,9 +389,10 @@ gic0: interrupt-controller@8010,00000000 { > <0x8010 0x80000000 0x0 0x600000>; /* GICR *= / > interrupts =3D <1 9 0xf04>; > > - its: gic-its@8010,00020000 { > + its: msi-controller@801000020000 { > compatible =3D "arm,gic-v3-its"; > msi-controller; > + #msi-cells =3D <1>; > reg =3D <0x8010 0x20000 0x0 0x200000>; > }; > }; > diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/b= oot/dts/cavium/thunder2-99xx.dtsi > index dfb41705a9a9..3419bd252696 100644 > --- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi > +++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi > @@ -55,7 +55,7 @@ psci { > method =3D "smc"; > }; > > - gic: interrupt-controller@400080000 { > + gic: interrupt-controller@4000080000 { > compatible =3D "arm,gic-v3"; > #interrupt-cells =3D <3>; > #address-cells =3D <2>; > @@ -67,7 +67,7 @@ gic: interrupt-controller@400080000 { > <0x04 0x01000000 0x0 0x1000000>; /* GICR */ > interrupts =3D ; > > - gicits: gic-its@40010000 { > + gicits: msi-controller@4000100000 { > compatible =3D "arm,gic-v3-its"; > msi-controller; > reg =3D <0x04 0x00100000 0x0 0x20000>; /* GIC = ITS */ > -- > 2.39.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89F23C6FD1F for ; Thu, 16 Mar 2023 19:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X+OfgIkxYPOON9rWt2jiJzXS4y1E0SjmYiNiBDhCwjM=; b=Km+SCfLHQGnIEZ +66SkeSKvBvrOGIFToDgbx5mvYwvNsj1Oe1jqpoXpxTSxcRRTj+l/NKHHM1KYVUp+XVyosrAuNE6n NFnftaHaL7gJx1PeMM55deaQ7hvLUPp5EZ5ZfwTuHjDXQ1Y5IIelDhZmW34BIpSpQUkaXDZcBM7Vv YNycuIVKuWLh7MyGiQpsonv0fWhIBVDOkS8eu9hXvOVp7BSDHWj8OmFi1jF/WMa63udccC6dtOlZa xnMtU3fsTikIDBglkmCmT2tW8xRotKKBfPo4YpK+YVrsQCnnDa4HE/WJfriQZNRzmenByLhjx6kdt V7NsITydLcFSlU0613tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pctdm-00HQMg-2p; Thu, 16 Mar 2023 19:51:58 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pctdh-00HQKy-1F for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 19:51:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C15DB82346 for ; Thu, 16 Mar 2023 19:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48999C4339E for ; Thu, 16 Mar 2023 19:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678996310; bh=zJnu6WZbbOrEPFIzFpFrY/DR/GnxDmEoNXhsslkKARU=; h=References:In-Reply-To:From:Date:Subject:List-Id:To:Cc:From; b=EhHAplpsZ1gp7OvBJL8TsEw7cyaajYiyJxRiNpOXdcvG79kAtceo6I57qdcCZwqRr 10TcaS3f9daZdCZCkn5zqSHRFs8l7UeutzHb9LkxczSxt3ws29N2OxKGxIvJS9DUZE 717k0pAmkcIryooeAw+HVQuuXOldtD+r2LCKauBRLAy6jkW8KUuuILgs7GL0+66deF ld48BAkwyzkZ2e6bacGxwYTCgAjCTrR6ZJn5LDjSARm8D/ubctZTxr80NDzcHALBZ3 8Kgc/DwQxnMTJxBO6f+ODVDQImTskVzTzPLUEralo3uF5MSgO0HB/3Jpm5Rlvm/lsn e7zdxGjYY1ekQ== Received: by mail-vs1-f49.google.com with SMTP id e19so2570196vsu.4 for ; Thu, 16 Mar 2023 12:51:50 -0700 (PDT) X-Gm-Message-State: AO0yUKV8t8EvohnqMjbgIjZ0rhTgCSoNpoXX8lqU3bmON6N5ajkD+O9b 693wFeDHFTYjFfH26rUnvF5wIQQxx0m0CPWIgw== X-Google-Smtp-Source: AK7set8/uY+rnVD9Tg3305Y6q91Hm6ecvF29SGXPPeBhHrNC6cfRN8YTeXkx74+l+JV1XRJK2qi3EQpZz0LFS+I3IKU= X-Received: by 2002:a67:fb46:0:b0:425:a28f:2e09 with SMTP id e6-20020a67fb46000000b00425a28f2e09mr7185807vsr.7.1678996309167; Thu, 16 Mar 2023 12:51:49 -0700 (PDT) MIME-Version: 1.0 References: <20230208185506.2305349-1-robh@kernel.org> In-Reply-To: <20230208185506.2305349-1-robh@kernel.org> From: Rob Herring Date: Thu, 16 Mar 2023 14:51:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: cavium: Fix GICv3 ITS nodes To: Krzysztof Kozlowski , Robert Richter , SoC Team Cc: Robin Murphy , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_125153_728706_D8C5BF09 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBGZWIgOCwgMjAyMyBhdCAxMjo1NeKAr1BNIFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5l bC5vcmc+IHdyb3RlOgo+Cj4gVGhlIEdJQ3YzIElUUyBpcyBhbiBNU0kgY29udHJvbGxlciwgdGhl cmVmb3JlIGl0cyBub2RlIG5hbWUgc2hvdWxkIGJlCj4gJ21zaS1jb250cm9sbGVyJy4gVGhlIElU UyBub2RlIGlzIGFsc28gZXhwZWN0ZWQgdG8gaGF2ZSAnI21zaS1jZWxscycuCj4gQWRkIGl0IG9u IFRodW5kZXIgYXMgdGhlcmUgYXJlIG5vIHVzZXJzLiBUaHVuZGVyMiB1c2VzICdtc2ktcGFyZW50 JywgYnV0Cj4gUm9iaW4gc2F5cyB0aGF0IHNob3VsZCBiZSAnbXNpLW1hcCcgaW5zdGVhZCBhbmQg SSdtIG5vdCBzdXJlIHdoYXQncwo+IGNvcnJlY3QgZm9yIGl0Lgo+Cj4gVGhlIHVuaXQtYWRkcmVz c2VzIG9mIGJvdGggdGhlIElUUyBhbmQgbWFpbiBHSUMgbm9kZSBvbiB0aHVuZGVyMiBhcmUgYWxz bwo+IHdyb25nLCBzbyBmaXggdGhlbSB3aGlsZSB3ZSdyZSBoZXJlLgo+Cj4gQ2M6IFJvYmluIE11 cnBoeSA8cm9iaW4ubXVycGh5QGFybS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9iIEhlcnJpbmcg PHJvYmhAa2VybmVsLm9yZz4KPiAtLS0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9jYXZpdW0vdGh1 bmRlci04OHh4LmR0c2kgIHwgMyArKy0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9jYXZpdW0vdGh1 bmRlcjItOTl4eC5kdHNpIHwgNCArKy0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKUGluZyEKClNob3VsZCB3ZSByZW1vdmUgdGhlc2UgcGxhdGZv cm1zIGluc3RlYWQgaWYgdGhleSBhcmVuJ3QgbWFpbnRhaW5lZD8KCj4KPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9ib290L2R0cy9jYXZpdW0vdGh1bmRlci04OHh4LmR0c2kgYi9hcmNoL2FybTY0 L2Jvb3QvZHRzL2Nhdml1bS90aHVuZGVyLTg4eHguZHRzaQo+IGluZGV4IGUwYTcxNzk1MjYxYi4u OGFkMzFkZWUxMWEzIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvY2F2aXVtL3Ro dW5kZXItODh4eC5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9jYXZpdW0vdGh1bmRl ci04OHh4LmR0c2kKPiBAQCAtMzg5LDkgKzM4OSwxMCBAQCBnaWMwOiBpbnRlcnJ1cHQtY29udHJv bGxlckA4MDEwLDAwMDAwMDAwIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8MHg4 MDEwIDB4ODAwMDAwMDAgMHgwIDB4NjAwMDAwPjsgLyogR0lDUiAqLwo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGludGVycnVwdHMgPSA8MSA5IDB4ZjA0PjsKPgo+IC0gICAgICAgICAgICAgICAg ICAgICAgIGl0czogZ2ljLWl0c0A4MDEwLDAwMDIwMDAwIHsKPiArICAgICAgICAgICAgICAgICAg ICAgICBpdHM6IG1zaS1jb250cm9sbGVyQDgwMTAwMDAyMDAwMCB7Cj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImFybSxnaWMtdjMtaXRzIjsKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG1zaS1jb250cm9sbGVyOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgI21zaS1jZWxscyA9IDwxPjsKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJlZyA9IDwweDgwMTAgMHgyMDAwMCAweDAgMHgyMDAwMDA+Owo+ICAgICAg ICAgICAgICAgICAgICAgICAgIH07Cj4gICAgICAgICAgICAgICAgIH07Cj4gZGlmZiAtLWdpdCBh L2FyY2gvYXJtNjQvYm9vdC9kdHMvY2F2aXVtL3RodW5kZXIyLTk5eHguZHRzaSBiL2FyY2gvYXJt NjQvYm9vdC9kdHMvY2F2aXVtL3RodW5kZXIyLTk5eHguZHRzaQo+IGluZGV4IGRmYjQxNzA1YTlh OS4uMzQxOWJkMjUyNjk2IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvY2F2aXVt L3RodW5kZXIyLTk5eHguZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvY2F2aXVtL3Ro dW5kZXIyLTk5eHguZHRzaQo+IEBAIC01NSw3ICs1NSw3IEBAIHBzY2kgewo+ICAgICAgICAgICAg ICAgICBtZXRob2QgPSAic21jIjsKPiAgICAgICAgIH07Cj4KPiAtICAgICAgIGdpYzogaW50ZXJy dXB0LWNvbnRyb2xsZXJANDAwMDgwMDAwIHsKPiArICAgICAgIGdpYzogaW50ZXJydXB0LWNvbnRy b2xsZXJANDAwMDA4MDAwMCB7Cj4gICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiYXJtLGdp Yy12MyI7Cj4gICAgICAgICAgICAgICAgICNpbnRlcnJ1cHQtY2VsbHMgPSA8Mz47Cj4gICAgICAg ICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Owo+IEBAIC02Nyw3ICs2Nyw3IEBAIGdpYzog aW50ZXJydXB0LWNvbnRyb2xsZXJANDAwMDgwMDAwIHsKPiAgICAgICAgICAgICAgICAgICAgICAg PDB4MDQgMHgwMTAwMDAwMCAweDAgMHgxMDAwMDAwPjsgIC8qIEdJQ1IgKi8KPiAgICAgICAgICAg ICAgICAgaW50ZXJydXB0cyA9IDxHSUNfUFBJIDkgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4KPiAt ICAgICAgICAgICAgICAgZ2ljaXRzOiBnaWMtaXRzQDQwMDEwMDAwIHsKPiArICAgICAgICAgICAg ICAgZ2ljaXRzOiBtc2ktY29udHJvbGxlckA0MDAwMTAwMDAwIHsKPiAgICAgICAgICAgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0gImFybSxnaWMtdjMtaXRzIjsKPiAgICAgICAgICAgICAgICAg ICAgICAgICBtc2ktY29udHJvbGxlcjsKPiAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8 MHgwNCAweDAwMTAwMDAwIDB4MCAweDIwMDAwPjsgICAgLyogR0lDIElUUyAqLwo+IC0tCj4gMi4z OS4xCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK