On Fri, May 21, 2021 at 4:44 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Fri, May 21, 2021 at 10:28 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Fri, 2021-05-21 at 14:20 +0200, Ming Liu wrote:
> > > From: Ming Liu <liu.ming50@gmail.com>
> > >
> > > Change to use '-' rather than '@' as separators.
> >
> > Why? The commit message needs more information.
> >
>
> I had exactly the same question/comment!

I guess this comes from the attempt to fix CVE-2021-27138, which was
already addressed in U-Boot with commit 3f04db891a35 ("image: Check
for unit addresses in FITs").

`@` is prohibied, so the `-` should be used instead.

I believe it would throw the build error, somethign like this:
| ./tools/mkimage: verify_header failed for FIT Image support with exit
| code 1

I do agree though - commit message should state this reason for this change.

>
> Bruce
>
> > Cheers,
> >
> > Richard
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
>


--
Regards,
Andrey.